From: Matthew Schwartz <matthew.schwartz@linux.dev>
To: dmitry.torokhov@gmail.com
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Matthew Schwartz <matthew.schwartz@linux.dev>
Subject: [PATCH 2/2] Input: i8042 - Disable keyboard wakeup from s2idle on MSI Claw devices
Date: Mon, 16 Jun 2025 22:19:30 -0700 [thread overview]
Message-ID: <20250617051930.3376981-3-matthew.schwartz@linux.dev> (raw)
In-Reply-To: <20250617051930.3376981-1-matthew.schwartz@linux.dev>
On MSI Claw handheld gaming PCs, the volume buttons are considered a part
of an i8042 keyboard device and can wake the system from s2idle. This is
not expected behavior on a handheld gaming device, as the volume buttons
can easily be pressed while handling the device in its s2idle state.
To avoid this behavior, enable the SERIO_QUIRK_NOKBDWAKEUP quirk for all
current MSI Claw models to disallow wakeup via the i8042 keyboard device
while maintaining volume button functionality.
Signed-off-by: Matthew Schwartz <matthew.schwartz@linux.dev>
---
drivers/input/serio/i8042-acpipnpio.h | 24 ++++++++++++++++++++++++
1 file changed, 24 insertions(+)
diff --git a/drivers/input/serio/i8042-acpipnpio.h b/drivers/input/serio/i8042-acpipnpio.h
index 6dbe9d8523f49..c1874a309c69b 100644
--- a/drivers/input/serio/i8042-acpipnpio.h
+++ b/drivers/input/serio/i8042-acpipnpio.h
@@ -897,6 +897,30 @@ static const struct dmi_system_id i8042_dmi_quirk_table[] __initconst = {
},
.driver_data = (void *)(SERIO_QUIRK_RESET_ALWAYS)
},
+ {
+ /* MSI Claw A1M */
+ .matches = {
+ DMI_MATCH(DMI_BOARD_VENDOR, "Micro-Star International Co., Ltd."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "Claw A1M"),
+ },
+ .driver_data = (void *)(SERIO_QUIRK_NOKBDWAKEUP)
+ },
+ {
+ /* MSI Claw 7 AI+ A2VM */
+ .matches = {
+ DMI_MATCH(DMI_BOARD_VENDOR, "Micro-Star International Co., Ltd."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "Claw 7 AI+ A2VM"),
+ },
+ .driver_data = (void *)(SERIO_QUIRK_NOKBDWAKEUP)
+ },
+ {
+ /* MSI Claw 8 AI+ A2VM */
+ .matches = {
+ DMI_MATCH(DMI_BOARD_VENDOR, "Micro-Star International Co., Ltd."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "Claw 8 AI+ A2VM"),
+ },
+ .driver_data = (void *)(SERIO_QUIRK_NOKBDWAKEUP)
+ },
{
/* MSI Wind U-100 */
.matches = {
--
2.49.0
next prev parent reply other threads:[~2025-06-17 5:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-17 5:19 [PATCH 0/2] Add nokbdwakeup quirk and enable it for MSI Claw Matthew Schwartz
2025-06-17 5:19 ` [PATCH 1/2] Input: i8042 - Add nokbdwakeup quirk to stop keyboard wakeup from s2idle Matthew Schwartz
2025-06-17 5:19 ` Matthew Schwartz [this message]
2025-06-17 20:50 ` [PATCH 0/2] Add nokbdwakeup quirk and enable it for MSI Claw Dmitry Torokhov
2025-06-17 21:33 ` Matthew Schwartz
2025-06-17 21:45 ` Dmitry Torokhov
2025-06-17 21:50 ` Matthew Schwartz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250617051930.3376981-3-matthew.schwartz@linux.dev \
--to=matthew.schwartz@linux.dev \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).