From: Mario Limonciello <superm1@kernel.org>
To: Hans de Goede <hansg@kernel.org>,
Mika Westerberg <westeri@kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-gpio@vger.kernel.org (open list:GPIO ACPI SUPPORT),
linux-acpi@vger.kernel.org (open list:GPIO ACPI SUPPORT),
linux-kernel@vger.kernel.org (open list),
linux-input@vger.kernel.org (open list:INPUT (KEYBOARD, MOUSE,
JOYSTICK, TOUCHSCREEN)...),
Mario Limonciello <mario.limonciello@amd.com>
Subject: [PATCH 2/2] Revert "Input: soc_button_array - debounce the buttons"
Date: Tue, 24 Jun 2025 15:22:11 -0500 [thread overview]
Message-ID: <20250624202211.1088738-3-superm1@kernel.org> (raw)
In-Reply-To: <20250624202211.1088738-1-superm1@kernel.org>
From: Mario Limonciello <mario.limonciello@amd.com>
commit 5c4fa2a6da7fb ("Input: soc_button_array - debounce the buttons")
hardcoded all soc-button-array devices to use a 50ms debounce timeout
but this doesn't work on all hardware. The hardware I have on hand
actually prescribes in the ASL that the timeout should be 0:
GpioInt (Edge, ActiveBoth, Exclusive, PullUp, 0x0000,
"\\_SB.GPIO", 0x00, ResourceConsumer, ,)
{ // Pin list
0x0000
}
Let the GPIO core program the debounce instead of hardcoding it into a
driver.
This reverts commit 5c4fa2a6da7fbc76290d1cb54a7e35633517a522.
Cc: Hans de Goede <hansg@kernel.org>
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
drivers/input/misc/soc_button_array.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/input/misc/soc_button_array.c b/drivers/input/misc/soc_button_array.c
index b8cad415c62ca..99490df42b6f2 100644
--- a/drivers/input/misc/soc_button_array.c
+++ b/drivers/input/misc/soc_button_array.c
@@ -219,8 +219,6 @@ soc_button_device_create(struct platform_device *pdev,
gpio_keys[n_buttons].active_low = info->active_low;
gpio_keys[n_buttons].desc = info->name;
gpio_keys[n_buttons].wakeup = info->wakeup;
- /* These devices often use cheap buttons, use 50 ms debounce */
- gpio_keys[n_buttons].debounce_interval = 50;
n_buttons++;
}
--
2.43.0
next prev parent reply other threads:[~2025-06-24 20:22 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-24 20:22 [PATCH 0/2] Fix soc-button-array debounce Mario Limonciello
2025-06-24 20:22 ` [PATCH 1/2] gpiolib: acpi: Program debounce when finding GPIO Mario Limonciello
2025-06-25 9:02 ` Hans de Goede
2025-06-25 12:19 ` Andy Shevchenko
2025-06-24 20:22 ` Mario Limonciello [this message]
2025-06-25 9:09 ` [PATCH 2/2] Revert "Input: soc_button_array - debounce the buttons" Hans de Goede
2025-06-25 14:09 ` Mario Limonciello
2025-06-25 14:31 ` Hans de Goede
2025-06-25 14:41 ` Mario Limonciello
2025-06-25 15:02 ` Limonciello, Mario
2025-06-25 15:10 ` Andy Shevchenko
2025-06-25 15:14 ` Limonciello, Mario
2025-06-25 15:17 ` Andy Shevchenko
2025-06-25 15:34 ` Limonciello, Mario
2025-06-25 17:54 ` Andy Shevchenko
2025-06-25 17:59 ` Limonciello, Mario
2025-06-25 18:03 ` Andy Shevchenko
2025-06-25 18:57 ` Hans de Goede
2025-06-25 19:10 ` Mario Limonciello
2025-06-25 19:32 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250624202211.1088738-3-superm1@kernel.org \
--to=superm1@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=brgl@bgdev.pl \
--cc=dmitry.torokhov@gmail.com \
--cc=hansg@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=westeri@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).