* [PATCH v1 1/1] Input: alps - switch to use scnprintf() to suppress truncation warning
@ 2025-06-30 8:21 Andy Shevchenko
2025-06-30 16:47 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Andy Shevchenko @ 2025-06-30 8:21 UTC (permalink / raw)
To: Dmitry Torokhov, linux-input, linux-kernel
Cc: Pali Rohár, Andy Shevchenko
The commit 76c968e75715 ("Input: alps - switch to use scnprintf() to suppress
truncation warning") converted one place in the driver while the other left
untouched. Convert the other place as well.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
Dmitry, thanks for fixing those problems! This one can be folded into mentioned
commit if you are still can / want to rebase.
drivers/input/mouse/alps.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/input/mouse/alps.c b/drivers/input/mouse/alps.c
index a1ebc30c11a9..d0cb9fb94821 100644
--- a/drivers/input/mouse/alps.c
+++ b/drivers/input/mouse/alps.c
@@ -3103,8 +3103,8 @@ int alps_init(struct psmouse *psmouse)
goto init_fail;
}
- snprintf(priv->phys2, sizeof(priv->phys2), "%s/input1",
- psmouse->ps2dev.serio->phys);
+ scnprintf(priv->phys2, sizeof(priv->phys2), "%s/input1",
+ psmouse->ps2dev.serio->phys);
dev2->phys = priv->phys2;
/*
--
2.47.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v1 1/1] Input: alps - switch to use scnprintf() to suppress truncation warning
2025-06-30 8:21 [PATCH v1 1/1] Input: alps - switch to use scnprintf() to suppress truncation warning Andy Shevchenko
@ 2025-06-30 16:47 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2025-06-30 16:47 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: linux-input, linux-kernel, Pali Rohár
On Mon, Jun 30, 2025 at 11:21:52AM +0300, Andy Shevchenko wrote:
> The commit 76c968e75715 ("Input: alps - switch to use scnprintf() to suppress
> truncation warning") converted one place in the driver while the other left
> untouched. Convert the other place as well.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>
> Dmitry, thanks for fixing those problems! This one can be folded into mentioned
> commit if you are still can / want to rebase.
Thank you Andy, I strongly prefer not to rebase for-linus branch so I
applied this as a separate patch.
Thanks.
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-06-30 16:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-30 8:21 [PATCH v1 1/1] Input: alps - switch to use scnprintf() to suppress truncation warning Andy Shevchenko
2025-06-30 16:47 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).