public inbox for linux-input@vger.kernel.org
 help / color / mirror / Atom feed
From: Francesco Dolcini <francesco@dolcini.it>
To: "Joe Hung (洪銘陽)" <joe_hung@ilitek.com>
Cc: "dmitry.torokhov@gmail.com" <dmitry.torokhov@gmail.com>,
	"francesco.dolcini@toradex.com" <francesco.dolcini@toradex.com>,
	"emanuele.ghidoli@toradex.com" <emanuele.ghidoli@toradex.com>,
	linux-input <linux-input@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Luca Hsu (徐嘉鍊)" <luca_hsu@ilitek.com>
Subject: Re: [PATCH] input: ilitek_ts_i2c: report key event for palm
Date: Wed, 23 Jul 2025 17:57:28 +0200	[thread overview]
Message-ID: <20250723155728.GA61254@francesco-nb> (raw)
In-Reply-To: <b372a99d01c14d1690afba4ceedd0936@ilitek.com>

On Mon, Jul 14, 2025 at 09:51:42AM +0000, Joe Hung (洪銘陽) wrote:
> From ec0d80214fee6acc0b38f33ad0b6b487098963bc Mon Sep 17 00:00:00 2001
> From: Joe Hong <joe_hung@ilitek.com>
> Date: Mon, 14 Jul 2025 17:20:11 +0800
> Subject: [PATCH] input: ilitek_ts_i2c: report key event for palm

something wrong on this headers, check your setup

> Add support for reporting user-defined key event while getting palm event.
> 
> Signed-off-by: Joe Hong <joe_hung@ilitek.com>
> ---
>  drivers/input/touchscreen/ilitek_ts_i2c.c | 42 +++++++++++++++++++++++
>  1 file changed, 42 insertions(+)
> 
> diff --git a/drivers/input/touchscreen/ilitek_ts_i2c.c b/drivers/input/touchscreen/ilitek_ts_i2c.c
> index 0dd632724a00..fdcb4ab66fbb 100644
> --- a/drivers/input/touchscreen/ilitek_ts_i2c.c
> +++ b/drivers/input/touchscreen/ilitek_ts_i2c.c
> @@ -39,8 +39,13 @@
>  #define ILITEK_TP_I2C_REPORT_ID				0x48
>  
>  #define REPORT_COUNT_ADDRESS				61
> +#define ALGO_MODE_ADDRESS				62
>  #define ILITEK_SUPPORT_MAX_POINT			40
>  
> +static uint palm_key;
> +module_param(palm_key, uint, 0664);
> +MODULE_PARM_DESC(palm_key, "Set palm key code when palm is detected");

I do not think that putting some kind of configuration in a kernel
module param is an option

Francesco


  reply	other threads:[~2025-07-23 15:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-14  9:51 [PATCH] input: ilitek_ts_i2c: report key event for palm Joe Hung (洪銘陽)
2025-07-23 15:57 ` Francesco Dolcini [this message]
2025-07-23 16:09 ` dmitry.torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250723155728.GA61254@francesco-nb \
    --to=francesco@dolcini.it \
    --cc=dmitry.torokhov@gmail.com \
    --cc=emanuele.ghidoli@toradex.com \
    --cc=francesco.dolcini@toradex.com \
    --cc=joe_hung@ilitek.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luca_hsu@ilitek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox