From: Julien Massot <julien.massot@collabora.com>
To: kernel@collabora.com, Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org,
Julien Massot <julien.massot@collabora.com>
Subject: [PATCH 1/3] Input: mtk-pmic-keys - MT6359 has a specific release irq
Date: Fri, 01 Aug 2025 15:16:49 +0200 [thread overview]
Message-ID: <20250801-radxa-nio-12-l-gpio-v1-1-d0840f85d2c8@collabora.com> (raw)
In-Reply-To: <20250801-radxa-nio-12-l-gpio-v1-0-d0840f85d2c8@collabora.com>
A recent commit in linux-next added support for key events.
However, the key release event is not properly handled: only key press events
are generated, leaving key states stuck in "pressed".
This patch ensures that both key press and key release events are properly
emitted by handling the release logic correctly.
Note: the code was introduced in linux-next by commit
bc25e6bf032e ("Input: mtk-pmic-keys - add support for MT6359 PMIC keys")
and is not yet present in mainline.
Signed-off-by: Julien Massot <julien.massot@collabora.com>
---
drivers/input/keyboard/mtk-pmic-keys.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/input/keyboard/mtk-pmic-keys.c b/drivers/input/keyboard/mtk-pmic-keys.c
index 50e2e792c91d2626d3f282d04a1db60845827ef2..0f9a589306482265f1f65c5a100b3f4aba0a2ed3 100644
--- a/drivers/input/keyboard/mtk-pmic-keys.c
+++ b/drivers/input/keyboard/mtk-pmic-keys.c
@@ -129,6 +129,7 @@ static const struct mtk_pmic_regs mt6359_regs = {
MTK_PMIC_HOMEKEY_RST),
.pmic_rst_reg = MT6359_TOP_RST_MISC,
.rst_lprst_mask = MTK_PMIC_RST_DU_MASK,
+ .key_release_irq = true,
};
struct mtk_pmic_keys_info {
--
2.50.1
next prev parent reply other threads:[~2025-08-01 13:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-01 13:16 [PATCH 0/3] Radxa NIO 12L: Add GPIO keys and LED support Julien Massot
2025-08-01 13:16 ` Julien Massot [this message]
2025-08-02 1:02 ` [PATCH 1/3] Input: mtk-pmic-keys - MT6359 has a specific release irq kernel test robot
2025-08-04 8:05 ` AngeloGioacchino Del Regno
2025-08-06 16:49 ` Dmitry Torokhov
2025-08-26 13:51 ` Julien Massot
2025-08-01 13:16 ` [PATCH 2/3] arm64: dts: mediatek: mt8395-nio-12l: add PMIC and GPIO keys support Julien Massot
2025-08-04 8:05 ` AngeloGioacchino Del Regno
2025-08-01 13:16 ` [PATCH 3/3] arm64: dts: mediatek: mt8395-nio-12l: add support for blue and red LEDs Julien Massot
2025-08-04 8:05 ` AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250801-radxa-nio-12-l-gpio-v1-1-d0840f85d2c8@collabora.com \
--to=julien.massot@collabora.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=kernel@collabora.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).