[PATCH 0/3] Radxa NIO 12L: Add GPIO keys and LED support

[PATCH 0/3] Radxa NIO 12L: Add GPIO keys and LED support

[Julien Massot]

This patchset adds support for the GPIO-connected red and blue LEDs, as well as the various hardware buttons present on the Radxa NIO 12L board.

It also includes a fix for the missing release (key-up) interrupt handling for PMIC-managed GPIO keys.

Signed-off-by: Julien Massot <julien.massot@collabora.com>
---
Julien Massot (3):
      Input: mtk-pmic-keys - MT6359 has a specific release irq
      arm64: dts: mediatek: mt8395-nio-12l: add PMIC and GPIO keys support
      arm64: dts: mediatek: mt8395-nio-12l: add support for blue and red LEDs

 .../boot/dts/mediatek/mt8395-radxa-nio-12l.dts     | 67 ++++++++++++++++++++++
 drivers/input/keyboard/mtk-pmic-keys.c             |  1 +
 2 files changed, 68 insertions(+)
---
base-commit: b9ddaa95fd283bce7041550ddbbe7e764c477110
change-id: 20250801-radxa-nio-12-l-gpio-54f208c25333

Best regards,
-- 
Julien Massot <julien.massot@collabora.com>

[PATCH 1/3] Input: mtk-pmic-keys - MT6359 has a specific release irq

[Julien Massot]

A recent commit in linux-next added support for key events.
However, the key release event is not properly handled: only key press events
are generated, leaving key states stuck in "pressed".

This patch ensures that both key press and key release events are properly
emitted by handling the release logic correctly.

Note: the code was introduced in linux-next by commit
bc25e6bf032e ("Input: mtk-pmic-keys - add support for MT6359 PMIC keys")
and is not yet present in mainline.

Signed-off-by: Julien Massot <julien.massot@collabora.com>
---
 drivers/input/keyboard/mtk-pmic-keys.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/input/keyboard/mtk-pmic-keys.c b/drivers/input/keyboard/mtk-pmic-keys.c
index 50e2e792c91d2626d3f282d04a1db60845827ef2..0f9a589306482265f1f65c5a100b3f4aba0a2ed3 100644
--- a/drivers/input/keyboard/mtk-pmic-keys.c
+++ b/drivers/input/keyboard/mtk-pmic-keys.c
@@ -129,6 +129,7 @@ static const struct mtk_pmic_regs mt6359_regs = {
 				   MTK_PMIC_HOMEKEY_RST),
 	.pmic_rst_reg = MT6359_TOP_RST_MISC,
 	.rst_lprst_mask = MTK_PMIC_RST_DU_MASK,
+	.key_release_irq = true,
 };
 
 struct mtk_pmic_keys_info {

-- 
2.50.1

Re: [PATCH 1/3] Input: mtk-pmic-keys - MT6359 has a specific release irq

[kernel test robot]

Hi Julien,

kernel test robot noticed the following build errors:

[auto build test ERROR on b9ddaa95fd283bce7041550ddbbe7e764c477110]

url:    https://github.com/intel-lab-lkp/linux/commits/Julien-Massot/Input-mtk-pmic-keys-MT6359-has-a-specific-release-irq/20250801-211817
base:   b9ddaa95fd283bce7041550ddbbe7e764c477110
patch link:    https://lore.kernel.org/r/20250801-radxa-nio-12-l-gpio-v1-1-d0840f85d2c8%40collabora.com
patch subject: [PATCH 1/3] Input: mtk-pmic-keys - MT6359 has a specific release irq
config: arc-randconfig-002-20250802 (https://download.01.org/0day-ci/archive/20250802/202508020802.nZBo2mGV-lkp@intel.com/config)
compiler: arc-linux-gcc (GCC) 14.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250802/202508020802.nZBo2mGV-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202508020802.nZBo2mGV-lkp@intel.com/

All error/warnings (new ones prefixed by >>):

>> drivers/input/keyboard/mtk-pmic-keys.c:132:10: error: 'const struct mtk_pmic_regs' has no member named 'key_release_irq'
     132 |         .key_release_irq = true,
         |          ^~~~~~~~~~~~~~~
>> drivers/input/keyboard/mtk-pmic-keys.c:132:28: warning: excess elements in struct initializer
     132 |         .key_release_irq = true,
         |                            ^~~~
   drivers/input/keyboard/mtk-pmic-keys.c:132:28: note: (near initialization for 'mt6359_regs')


vim +132 drivers/input/keyboard/mtk-pmic-keys.c

   120	
   121	static const struct mtk_pmic_regs mt6359_regs = {
   122		.keys_regs[MTK_PMIC_PWRKEY_INDEX] =
   123			MTK_PMIC_KEYS_REGS(MT6359_TOPSTATUS,
   124					   0x2, MT6359_PSC_TOP_INT_CON0, 0x5,
   125					   MTK_PMIC_PWRKEY_RST),
   126		.keys_regs[MTK_PMIC_HOMEKEY_INDEX] =
   127			MTK_PMIC_KEYS_REGS(MT6359_TOPSTATUS,
   128					   0x8, MT6359_PSC_TOP_INT_CON0, 0xa,
   129					   MTK_PMIC_HOMEKEY_RST),
   130		.pmic_rst_reg = MT6359_TOP_RST_MISC,
   131		.rst_lprst_mask = MTK_PMIC_RST_DU_MASK,
 > 132		.key_release_irq = true,
   133	};
   134	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Re: [PATCH 1/3] Input: mtk-pmic-keys - MT6359 has a specific release irq

[AngeloGioacchino Del Regno]

Il 01/08/25 15:16, Julien Massot ha scritto:
> A recent commit in linux-next added support for key events.
> However, the key release event is not properly handled: only key press events
> are generated, leaving key states stuck in "pressed".
> 
> This patch ensures that both key press and key release events are properly
> emitted by handling the release logic correctly.
> 
> Note: the code was introduced in linux-next by commit
> bc25e6bf032e ("Input: mtk-pmic-keys - add support for MT6359 PMIC keys")
> and is not yet present in mainline.
> 
> Signed-off-by: Julien Massot <julien.massot@collabora.com>

Well, you are effectively fixing the commit that you pointed out, so this needs

Fixes: bc25e6bf032e ("Input: mtk-pmic-keys - add support for MT6359 PMIC keys")

and

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

Cheers,
Angelo

Re: [PATCH 1/3] Input: mtk-pmic-keys - MT6359 has a specific release irq

[Dmitry Torokhov]

On Mon, Aug 04, 2025 at 10:05:21AM +0200, AngeloGioacchino Del Regno wrote:
> Il 01/08/25 15:16, Julien Massot ha scritto:
> > A recent commit in linux-next added support for key events.
> > However, the key release event is not properly handled: only key press events
> > are generated, leaving key states stuck in "pressed".
> > 
> > This patch ensures that both key press and key release events are properly
> > emitted by handling the release logic correctly.
> > 
> > Note: the code was introduced in linux-next by commit
> > bc25e6bf032e ("Input: mtk-pmic-keys - add support for MT6359 PMIC keys")
> > and is not yet present in mainline.
> > 
> > Signed-off-by: Julien Massot <julien.massot@collabora.com>
> 
> Well, you are effectively fixing the commit that you pointed out, so this needs
> 
> Fixes: bc25e6bf032e ("Input: mtk-pmic-keys - add support for MT6359 PMIC keys")
> 
> and
> 
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

I am really interested in how exactly this was developed, tested, and
reviewed...

Thanks.

-- 
Dmitry

Re: [PATCH 1/3] Input: mtk-pmic-keys - MT6359 has a specific release irq

[Julien Massot]

Hi Dmitry

On Wed, 2025-08-06 at 09:49 -0700, Dmitry Torokhov wrote:
> On Mon, Aug 04, 2025 at 10:05:21AM +0200, AngeloGioacchino Del Regno
> wrote:
> > Il 01/08/25 15:16, Julien Massot ha scritto:
> > > A recent commit in linux-next added support for key events.
> > > However, the key release event is not properly handled: only key
> > > press events
> > > are generated, leaving key states stuck in "pressed".
> > > 
> > > This patch ensures that both key press and key release events are
> > > properly
> > > emitted by handling the release logic correctly.
> > > 
> > > Note: the code was introduced in linux-next by commit
> > > bc25e6bf032e ("Input: mtk-pmic-keys - add support for MT6359 PMIC
> > > keys")
> > > and is not yet present in mainline.
> > > 
> > > Signed-off-by: Julien Massot <julien.massot@collabora.com>
> > 
> > Well, you are effectively fixing the commit that you pointed out, so
> > this needs
> > 
> > Fixes: bc25e6bf032e ("Input: mtk-pmic-keys - add support for MT6359
> > PMIC keys")
> > 
> > and
> > 
> > Reviewed-by: AngeloGioacchino Del Regno
> > <angelogioacchino.delregno@collabora.com>
> 
> I am really interested in how exactly this was developed, tested, and
> reviewed...
> 
> Thanks.

You are right, the issue comes from my side.
I prepared the patch against a slightly different tree, which led to the
discrepancy. I’ll respin it on top of the current linux-next and re-test
it properly to ensure the fix behaves as expected.

Thanks for catching this, and thanks for your time.
Julien

[PATCH 2/3] arm64: dts: mediatek: mt8395-nio-12l: add PMIC and GPIO keys support

[Julien Massot]

Add support for PMIC and GPIO keys on the Radxa NIO 12L board:
Declare a gpio-keys node for the Volume Up button using GPIO106.
Add the corresponding pin configuration in the pinctrl node.
Add a mediatek,mt6359-keys subnode under the PMIC to handle the
power and home buttons exposed by the MT6359.

Signed-off-by: Julien Massot <julien.massot@collabora.com>
---
 .../boot/dts/mediatek/mt8395-radxa-nio-12l.dts     | 36 ++++++++++++++++++++++
 1 file changed, 36 insertions(+)

diff --git a/arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts b/arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts
index 329c60cc6a6be0b4be8c0b8bb033b32d35302804..fd596e2298285361ad7c2fb828feec598d75a73e 100644
--- a/arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts
+++ b/arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts
@@ -8,6 +8,7 @@
 #include "mt8195.dtsi"
 #include "mt6359.dtsi"
 #include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/input/input.h>
 #include <dt-bindings/interrupt-controller/irq.h>
 #include <dt-bindings/pinctrl/mt8195-pinfunc.h>
 #include <dt-bindings/regulator/mediatek,mt6360-regulator.h>
@@ -60,6 +61,18 @@ backlight: backlight {
 		status = "disabled";
 	};
 
+	keys: gpio-keys {
+		compatible = "gpio-keys";
+
+		button-volume-up {
+			wakeup-source;
+			debounce-interval = <100>;
+			gpios = <&pio 106 GPIO_ACTIVE_LOW>;
+			label = "volume_up";
+			linux,code = <KEY_VOLUMEUP>;
+		};
+	};
+
 	wifi_vreg: regulator-wifi-3v3-en {
 		compatible = "regulator-fixed";
 		regulator-name = "wifi_3v3_en";
@@ -626,6 +639,14 @@ pins-txd {
 		};
 	};
 
+	gpio_key_pins: gpio-keys-pins {
+		pins {
+			pinmux = <PINMUX_GPIO106__FUNC_GPIO106>;
+			bias-pull-up;
+			input-enable;
+		};
+	};
+
 	i2c2_pins: i2c2-pins {
 		pins-bus {
 			pinmux = <PINMUX_GPIO12__FUNC_SDA2>,
@@ -880,6 +901,21 @@ &pciephy {
 
 &pmic {
 	interrupts-extended = <&pio 222 IRQ_TYPE_LEVEL_HIGH>;
+
+	mt6359keys: keys {
+		compatible = "mediatek,mt6359-keys";
+		mediatek,long-press-mode = <1>;
+		power-off-time-sec = <0>;
+
+		power-key {
+			linux,keycodes = <KEY_POWER>;
+			wakeup-source;
+		};
+
+		home {
+			linux,keycodes = <KEY_HOME>;
+		};
+	};
 };
 
 &scp {

-- 
2.50.1

Re: [PATCH 2/3] arm64: dts: mediatek: mt8395-nio-12l: add PMIC and GPIO keys support

[AngeloGioacchino Del Regno]

Il 01/08/25 15:16, Julien Massot ha scritto:
> Add support for PMIC and GPIO keys on the Radxa NIO 12L board:
> Declare a gpio-keys node for the Volume Up button using GPIO106.
> Add the corresponding pin configuration in the pinctrl node.
> Add a mediatek,mt6359-keys subnode under the PMIC to handle the
> power and home buttons exposed by the MT6359.
> 
> Signed-off-by: Julien Massot <julien.massot@collabora.com>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

[PATCH 3/3] arm64: dts: mediatek: mt8395-nio-12l: add support for blue and red LEDs

[Julien Massot]

The Radxa NIO 12L board has an RGB LED, of which only red and blue
are controllable.

Red and blue LEDs: no need to choose, both are enabled.

Signed-off-by: Julien Massot <julien.massot@collabora.com>
---
 .../boot/dts/mediatek/mt8395-radxa-nio-12l.dts     | 31 ++++++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts b/arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts
index fd596e2298285361ad7c2fb828feec598d75a73e..12288ad4d2932b7f78c96c0efe366a046721f919 100644
--- a/arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts
+++ b/arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts
@@ -10,6 +10,7 @@
 #include <dt-bindings/gpio/gpio.h>
 #include <dt-bindings/input/input.h>
 #include <dt-bindings/interrupt-controller/irq.h>
+#include <dt-bindings/leds/common.h>
 #include <dt-bindings/pinctrl/mt8195-pinfunc.h>
 #include <dt-bindings/regulator/mediatek,mt6360-regulator.h>
 #include <dt-bindings/spmi/spmi.h>
@@ -73,6 +74,28 @@ button-volume-up {
 		};
 	};
 
+	gpio-leds {
+		compatible = "gpio-leds";
+		pinctrl-0 = <&gpio_leds_pins>;
+		pinctrl-names = "default";
+
+		/*
+		 * This board has a RGB LED, of which only R and B
+		 * are controllable.
+		 */
+		led-0 {
+			label = "rgb-blue";
+			color = <LED_COLOR_ID_BLUE>;
+			gpios = <&pio 6 GPIO_ACTIVE_HIGH>;
+		};
+
+		led-1 {
+			label = "rgb-red";
+			color = <LED_COLOR_ID_RED>;
+			gpios = <&pio 7 GPIO_ACTIVE_HIGH>;
+		};
+	};
+
 	wifi_vreg: regulator-wifi-3v3-en {
 		compatible = "regulator-fixed";
 		regulator-name = "wifi_3v3_en";
@@ -647,6 +670,14 @@ pins {
 		};
 	};
 
+	gpio_leds_pins: gpio-leds-pins {
+		pins {
+			pinmux = <PINMUX_GPIO6__FUNC_GPIO6>,
+				 <PINMUX_GPIO7__FUNC_GPIO7>;
+			output-low;
+		};
+	};
+
 	i2c2_pins: i2c2-pins {
 		pins-bus {
 			pinmux = <PINMUX_GPIO12__FUNC_SDA2>,

-- 
2.50.1

Re: [PATCH 3/3] arm64: dts: mediatek: mt8395-nio-12l: add support for blue and red LEDs

[AngeloGioacchino Del Regno]

Il 01/08/25 15:16, Julien Massot ha scritto:
> The Radxa NIO 12L board has an RGB LED, of which only red and blue
> are controllable.
> 
> Red and blue LEDs: no need to choose, both are enabled.
> 
> Signed-off-by: Julien Massot <julien.massot@collabora.com>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>