From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3AB3A2036E9; Tue, 16 Sep 2025 19:27:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758050834; cv=none; b=NYLfmi3/YlSLBRwndV3fCdwOPf0/503hN0NGk5rMOpWv09h7W3irbB5kYh38JCvTB96tkwgjSLJ+gv5UONWPoqfhPfzzh0QJIPTUsNvqMHZAkPjixhFxiksbYTpaLCatXGXvheY8nxiRxCGCO62Pwe/5mc+aqRhtWtx91kidh6g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758050834; c=relaxed/simple; bh=SvkZnrjbq/9F17psAbb495EqR7oYJMGmVyT9vm58sw8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hfG9AKVjsa34nNiel6VLulio7BW/CaMrOI6PTsxQ0TB94tqXmYUkWNlruhToXiQg45sTP5DaUvuNDtzfZuGYBmKZi3cJJRYQIHgY8N23folr+BteEt8Rg43gk8U/lKzr1oZjfteBUwsrI278CFDtVaz7z+7nlFJI5S9C4da9YCw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=js4XbzbF; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="js4XbzbF" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 966D0C4CEEB; Tue, 16 Sep 2025 19:27:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1758050833; bh=SvkZnrjbq/9F17psAbb495EqR7oYJMGmVyT9vm58sw8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=js4XbzbFp9Re2Q6jO01FPk9zXAX1E8lWkZQajgfn4JESITqYqcKPOwYNeJTNBkgra 1OHurdgLt+TY+SkbTWIYwdiITROKwGsy3OuNqVX6DnDJ2c+s2leAYQArIqWzaj23AD bEQePVlxQBWbcF6/udOSI5phoGcDrmSEf92vqw3LbROQTIudGQB95RJQ4vE4rvd0qt mGJo7+qITyjv9/bHBZ+Px+wBhUE80M6+SMIX2vEWGt+gNEZTlkAIhdy6ruvhLTbJ7t 5VPfb5c+Ir0YjBSz0zBEdM9r/f7l/NKBg2XOsGwFLofL2bPJ+yI1TinOTh1rOoCpG1 6fXs8/60vRhBQ== Date: Tue, 16 Sep 2025 20:27:08 +0100 From: Conor Dooley To: Frank Li Cc: Dario Binacchi , linux-kernel@vger.kernel.org, linux-amarula@amarulasolutions.com, Conor Dooley , Dmitry Torokhov , Fabio Estevam , Haibo Chen , Krzysztof Kozlowski , Pengutronix Kernel Team , Rob Herring , Sascha Hauer , Shawn Guo , devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org Subject: Re: [PATCH v3 4/6] dt-bindings: touchscreen: fsl,imx6ul-tsc: support glitch thresold Message-ID: <20250916-envelope-depict-7c321fe12341@spud> References: <20250915195335.1710780-1-dario.binacchi@amarulasolutions.com> <20250915195335.1710780-5-dario.binacchi@amarulasolutions.com> <20250916-auction-angelfish-0239691a54e5@spud> Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="up2hkdYrwSZhILqz" Content-Disposition: inline In-Reply-To: <20250916-auction-angelfish-0239691a54e5@spud> --up2hkdYrwSZhILqz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Sep 16, 2025 at 08:25:53PM +0100, Conor Dooley wrote: > On Tue, Sep 16, 2025 at 11:55:17AM -0400, Frank Li wrote: > > On Mon, Sep 15, 2025 at 09:53:06PM +0200, Dario Binacchi wrote: > > > Support the touchscreen-glitch-threshold-ns property. Unlike the > > > generic description in touchscreen.yaml, this controller maps the > > > provided value to one of four discrete thresholds internally. > > > > > > Signed-off-by: Dario Binacchi > > > > > > --- > > > > > > Changes in v3: > > > - Remove the final part of the description that refers to > > > implementation details. > > > > > > .../bindings/input/touchscreen/fsl,imx6ul-tsc.yaml | 12 ++++++++++= ++ > > > 1 file changed, 12 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/input/touchscreen/fsl,= imx6ul-tsc.yaml b/Documentation/devicetree/bindings/input/touchscreen/fsl,i= mx6ul-tsc.yaml > > > index 678756ad0f92..6214d8be5a99 100644 > > > --- a/Documentation/devicetree/bindings/input/touchscreen/fsl,imx6ul-= tsc.yaml > > > +++ b/Documentation/devicetree/bindings/input/touchscreen/fsl,imx6ul-= tsc.yaml > > > @@ -62,6 +62,18 @@ properties: > > > description: Number of data samples which are averaged for each = read. > > > enum: [ 1, 4, 8, 16, 32 ] > > > > > > + touchscreen-glitch-threshold-ns: > > > + description: | > > > + Unlike the generic property defined in touchscreen.yaml, this > > > + controller does not allow arbitrary values. Internally the val= ue is > > > + converted to IPG clock cycles and mapped to one of four discre= te > > > + thresholds exposed by the TSC_DEBUG_MODE2 register: > > > + > > > + 0: 8191 IPG cycles > > > + 1: 4095 IPG cycles > > > + 2: 2047 IPG cycles > > > + 3: 1023 IPG cycles > > > + > >=20 > > You have to use ns here. You can caculate in driver to match to closed = one. >=20 > That is what he is saying it is doing - "internally the value is > converted to IPG clock cycles" and so on. Your repeated misunderstanding > of this though points out that maybe the description is still lacking? >=20 > Dario, how about: > | The gitch threshold in nanoseconds. Drivers must convert this value to Or maybe instead of what I did here for the first sentence, yoink the text =66rom [3/6] instead and re-use it. > | IPG clock cycles and map it to one of the four discrete thresholds > | exposed by the TSC_DEBUG_MODE2 register: > |=20 > | 0: 8191 IPG cycles > | 1: 4095 IPG cycles > | 2: 2047 IPG cycles > | 3: 1023 IPG cycles > ?=20 > I dropped the bit about arbitrary values, due to my comment on the other > version a few mins ago. --up2hkdYrwSZhILqz Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCaMm6DAAKCRB4tDGHoIJi 0r+8AQCh1pvwS8dKmQpDjpCd2rHydQeIys66IYitwQfTMldZQwD/fMpbr0KvyaCW iM0erGHkx+tSkhIfbPbPTddxQMz+wwM= =0w/+ -----END PGP SIGNATURE----- --up2hkdYrwSZhILqz--