From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9CC992D879C; Wed, 24 Sep 2025 10:01:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758708081; cv=none; b=dwHhuk+SFL8OpQeuAmuC5qTW6AXSfV0UnFdPeHbpGdmzDXX9CKLdNg6+qohsA1wfxWY33Xv16aeHNXDZOG0+kZBjTdFp+oVuyDImAnxsTz6x8KmmYKVUbYKRivqDa+/TrsMjrwDn9olXWDXfInTWyHQbUe2+M6DbDXXTOCgdHbc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758708081; c=relaxed/simple; bh=L9rXAO4TRnu0P7LaCvfTltUKK+P3dX9M0cRaUN0Iwdc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=sCXD60xII3+e6yEqXkMOObArjvodv4N6eSu9n1gFYez5HsDOiPqyckuD57+6oGsD98S+UYs11teXK6vwnOKqqG2BorupXax5d0jj9r+nIONYVnn9BrOqJWkIIpTIkRV+WO+DYejCIK3JCue7ek8DGKQKk2SDo9xWwrpS76wlAS8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=B1enMBCA; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="B1enMBCA" Received: from pendragon.ideasonboard.com (85-76-33-231-nat.elisa-mobile.fi [85.76.33.231]) by perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 441F31E30; Wed, 24 Sep 2025 11:59:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1758707990; bh=L9rXAO4TRnu0P7LaCvfTltUKK+P3dX9M0cRaUN0Iwdc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=B1enMBCAJTNPmqlep7QPL1M88eaOslsfCubzJXVt1jFe2bNqpYXIFknc1vrkemusH W3NU0ZYxMqErtoTcmr5AWb3ocnTot8PQqwUsoQey4HoqbXpka4iZwClSdeMrL/q81n RqH2JCgcfOkiCmrHiC2w9WN+KuC3VyQIVufdVslo= Date: Wed, 24 Sep 2025 13:00:40 +0300 From: Laurent Pinchart To: Sakari Ailus Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-leds@vger.kernel.org, linux-media@vger.kernel.org, netdev@vger.kernel.org, linux-spi@vger.kernel.org, "Rafael J. Wysocki" , Len Brown , Greg Kroah-Hartman , Danilo Krummrich , Andy Shevchenko , Daniel Scally , Heikki Krogerus , Javier Carrasco , Dmitry Torokhov , Lee Jones , Pavel Machek , Matthias Fend , Chanwoo Choi , Krzysztof Kozlowski , Paul Elder , Mauro Carvalho Chehab , Horatiu Vultur , UNGLinuxDriver@microchip.com, Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Mark Brown , Thomas Gleixner , Ingo Molnar , Jonathan Cameron Subject: Re: [PATCH v2 07/16] property: Drop DEVICE_DISABLED flag in fwnode_graph_get_endpoint_count() Message-ID: <20250924100040.GA9827@pendragon.ideasonboard.com> References: <20250924074602.266292-1-sakari.ailus@linux.intel.com> <20250924074602.266292-8-sakari.ailus@linux.intel.com> Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20250924074602.266292-8-sakari.ailus@linux.intel.com> On Wed, Sep 24, 2025 at 10:45:53AM +0300, Sakari Ailus wrote: > FWNODE_GRAPH_DEVICE_DISABLED flag isn't used anywhere, drop the flag and > support for it in fwnode_graph_get_endpoint_count(). > > Signed-off-by: Sakari Ailus > Reviewed-by: Andy Shevchenko With 06/16 squashed into this, Reviewed-by: Laurent Pinchart > --- > drivers/base/property.c | 10 ++-------- > include/linux/property.h | 8 +------- > 2 files changed, 3 insertions(+), 15 deletions(-) > > diff --git a/drivers/base/property.c b/drivers/base/property.c > index 7fc3257f223d..4bd64e729431 100644 > --- a/drivers/base/property.c > +++ b/drivers/base/property.c > @@ -1291,21 +1291,15 @@ EXPORT_SYMBOL_GPL(fwnode_graph_get_endpoint_by_id); > /** > * fwnode_graph_get_endpoint_count - Count endpoints on a device node > * @fwnode: The node related to a device > - * @flags: fwnode lookup flags > * Count endpoints in a device node. > - * > - * If FWNODE_GRAPH_DEVICE_DISABLED flag is specified, also unconnected endpoints > - * and endpoints connected to disabled devices are counted. > */ > -unsigned int fwnode_graph_get_endpoint_count(const struct fwnode_handle *fwnode, > - unsigned long flags) > +unsigned int fwnode_graph_get_endpoint_count(const struct fwnode_handle *fwnode) > { > struct fwnode_handle *ep; > unsigned int count = 0; > > fwnode_graph_for_each_endpoint(fwnode, ep) { > - if (flags & FWNODE_GRAPH_DEVICE_DISABLED || > - fwnode_graph_remote_available(ep)) > + if (fwnode_graph_remote_available(ep)) > count++; > } > > diff --git a/include/linux/property.h b/include/linux/property.h > index d1e80b3c9918..8b8bbbe6b5b7 100644 > --- a/include/linux/property.h > +++ b/include/linux/property.h > @@ -503,19 +503,13 @@ static inline bool fwnode_graph_is_endpoint(const struct fwnode_handle *fwnode) > * @FWNODE_GRAPH_ENDPOINT_NEXT: In the case of no exact match, look for the > * closest endpoint ID greater than the specified > * one. > - * @FWNODE_GRAPH_DEVICE_DISABLED: That the device to which the remote > - * endpoint of the given endpoint belongs to, > - * may be disabled, or that the endpoint is not > - * connected. > */ > #define FWNODE_GRAPH_ENDPOINT_NEXT BIT(0) > -#define FWNODE_GRAPH_DEVICE_DISABLED BIT(1) > > struct fwnode_handle * > fwnode_graph_get_endpoint_by_id(const struct fwnode_handle *fwnode, > u32 port, u32 endpoint, unsigned long flags); > -unsigned int fwnode_graph_get_endpoint_count(const struct fwnode_handle *fwnode, > - unsigned long flags); > +unsigned int fwnode_graph_get_endpoint_count(const struct fwnode_handle *fwnode); > > #define fwnode_graph_for_each_endpoint(fwnode, child) \ > for (child = fwnode_graph_get_next_endpoint(fwnode, NULL); child; \ -- Regards, Laurent Pinchart