linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 1/2] dt-bindings: touchscreen: rename maxim,max11801.yaml to trivial-touch.yaml
@ 2025-09-26 18:47 Frank Li
  2025-09-26 18:47 ` [PATCH v2 2/2] dt-bindings: touchscreen: move ar1021.txt " Frank Li
                   ` (2 more replies)
  0 siblings, 3 replies; 8+ messages in thread
From: Frank Li @ 2025-09-26 18:47 UTC (permalink / raw)
  To: Dmitry Torokhov, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	open list:INPUT (KEYBOARD, MOUSE, JOYSTICK, TOUCHSCREEN)...,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	open list
  Cc: imx

Rename maxim,max11801.yaml to trivial-touch.yaml for simple i2c touch
controller with one interrupt and common touch properties.

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
change in v2
new patch

previous discussion
https://lore.kernel.org/imx/20250925-swimming-overspend-ddf7ab4a252c@spud/T/#t
---
 .../{maxim,max11801.yaml => trivial-touch.yaml}           | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)
 rename Documentation/devicetree/bindings/input/touchscreen/{maxim,max11801.yaml => trivial-touch.yaml} (74%)

diff --git a/Documentation/devicetree/bindings/input/touchscreen/maxim,max11801.yaml b/Documentation/devicetree/bindings/input/touchscreen/trivial-touch.yaml
similarity index 74%
rename from Documentation/devicetree/bindings/input/touchscreen/maxim,max11801.yaml
rename to Documentation/devicetree/bindings/input/touchscreen/trivial-touch.yaml
index 4f528d2201992..c393cce273c5b 100644
--- a/Documentation/devicetree/bindings/input/touchscreen/maxim,max11801.yaml
+++ b/Documentation/devicetree/bindings/input/touchscreen/trivial-touch.yaml
@@ -1,17 +1,19 @@
 # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
 %YAML 1.2
 ---
-$id: http://devicetree.org/schemas/input/touchscreen/maxim,max11801.yaml#
+$id: http://devicetree.org/schemas/input/touchscreen/trivial-touch.yaml#
 $schema: http://devicetree.org/meta-schemas/core.yaml#
 
-title: MAXI MAX11801 Resistive touch screen controller with i2c interface
+title: Trivial touch screen controller with i2c interface
 
 maintainers:
   - Frank Li <Frank.Li@nxp.com>
 
 properties:
   compatible:
-    const: maxim,max11801
+    enum:
+      # MAXI MAX11801 Resistive touch screen controller with i2c interface
+      - maxim,max11801
 
   reg:
     maxItems: 1
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH v2 2/2] dt-bindings: touchscreen: move ar1021.txt to trivial-touch.yaml
  2025-09-26 18:47 [PATCH v2 1/2] dt-bindings: touchscreen: rename maxim,max11801.yaml to trivial-touch.yaml Frank Li
@ 2025-09-26 18:47 ` Frank Li
  2025-09-30 19:05   ` Conor Dooley
  2025-10-18  4:22   ` Dmitry Torokhov
  2025-10-02  3:07 ` [PATCH v2 1/2] dt-bindings: touchscreen: rename maxim,max11801.yaml " Rob Herring (Arm)
  2025-10-18  4:22 ` Dmitry Torokhov
  2 siblings, 2 replies; 8+ messages in thread
From: Frank Li @ 2025-09-26 18:47 UTC (permalink / raw)
  To: Dmitry Torokhov, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	open list:INPUT (KEYBOARD, MOUSE, JOYSTICK, TOUCHSCREEN)...,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	open list
  Cc: imx

ar1021 have only reg and interrupts property beside touch common
properties. So move context of ar1021.txt into trivial-touch.yaml.

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
change in v2
 move to trivial-touch.yaml

previous discussion
    https://lore.kernel.org/imx/20250925-swimming-overspend-ddf7ab4a252c@spud/T/#t
---
 .../bindings/input/touchscreen/ar1021.txt         | 15 ---------------
 .../bindings/input/touchscreen/trivial-touch.yaml |  2 ++
 2 files changed, 2 insertions(+), 15 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/input/touchscreen/ar1021.txt

diff --git a/Documentation/devicetree/bindings/input/touchscreen/ar1021.txt b/Documentation/devicetree/bindings/input/touchscreen/ar1021.txt
deleted file mode 100644
index 82019bd6094ee..0000000000000
--- a/Documentation/devicetree/bindings/input/touchscreen/ar1021.txt
+++ /dev/null
@@ -1,15 +0,0 @@
-* Microchip AR1020 and AR1021 touchscreen interface (I2C)
-
-Required properties:
-- compatible		: "microchip,ar1021-i2c"
-- reg			: I2C slave address
-- interrupts		: touch controller interrupt
-
-Example:
-
-	touchscreen@4d {
-		compatible = "microchip,ar1021-i2c";
-		reg = <0x4d>;
-		interrupt-parent = <&gpio3>;
-		interrupts = <11 IRQ_TYPE_LEVEL_HIGH>;
-	};
diff --git a/Documentation/devicetree/bindings/input/touchscreen/trivial-touch.yaml b/Documentation/devicetree/bindings/input/touchscreen/trivial-touch.yaml
index c393cce273c5b..d6aed3afd4acb 100644
--- a/Documentation/devicetree/bindings/input/touchscreen/trivial-touch.yaml
+++ b/Documentation/devicetree/bindings/input/touchscreen/trivial-touch.yaml
@@ -14,6 +14,8 @@ properties:
     enum:
       # MAXI MAX11801 Resistive touch screen controller with i2c interface
       - maxim,max11801
+      # Microchip AR1020 and AR1021 touchscreen interface (I2C)
+      - microchip,ar1021-i2c
 
   reg:
     maxItems: 1
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH v2 2/2] dt-bindings: touchscreen: move ar1021.txt to trivial-touch.yaml
  2025-09-26 18:47 ` [PATCH v2 2/2] dt-bindings: touchscreen: move ar1021.txt " Frank Li
@ 2025-09-30 19:05   ` Conor Dooley
  2025-10-01 21:34     ` Frank Li
  2025-10-18  4:22   ` Dmitry Torokhov
  1 sibling, 1 reply; 8+ messages in thread
From: Conor Dooley @ 2025-09-30 19:05 UTC (permalink / raw)
  To: Frank Li
  Cc: Dmitry Torokhov, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	open list:INPUT (KEYBOARD, MOUSE, JOYSTICK, TOUCHSCREEN)...,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	open list, imx

[-- Attachment #1: Type: text/plain, Size: 2225 bytes --]

On Fri, Sep 26, 2025 at 02:47:12PM -0400, Frank Li wrote:
> ar1021 have only reg and interrupts property beside touch common
> properties. So move context of ar1021.txt into trivial-touch.yaml.
> 
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> change in v2
>  move to trivial-touch.yaml
> 
> previous discussion
>     https://lore.kernel.org/imx/20250925-swimming-overspend-ddf7ab4a252c@spud/T/#t

You mentioned there were a load of other devices using just these 3
properties. Do you intend moving those too?

> ---
>  .../bindings/input/touchscreen/ar1021.txt         | 15 ---------------
>  .../bindings/input/touchscreen/trivial-touch.yaml |  2 ++
>  2 files changed, 2 insertions(+), 15 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/input/touchscreen/ar1021.txt
> 
> diff --git a/Documentation/devicetree/bindings/input/touchscreen/ar1021.txt b/Documentation/devicetree/bindings/input/touchscreen/ar1021.txt
> deleted file mode 100644
> index 82019bd6094ee..0000000000000
> --- a/Documentation/devicetree/bindings/input/touchscreen/ar1021.txt
> +++ /dev/null
> @@ -1,15 +0,0 @@
> -* Microchip AR1020 and AR1021 touchscreen interface (I2C)
> -
> -Required properties:
> -- compatible		: "microchip,ar1021-i2c"
> -- reg			: I2C slave address
> -- interrupts		: touch controller interrupt
> -
> -Example:
> -
> -	touchscreen@4d {
> -		compatible = "microchip,ar1021-i2c";
> -		reg = <0x4d>;
> -		interrupt-parent = <&gpio3>;
> -		interrupts = <11 IRQ_TYPE_LEVEL_HIGH>;
> -	};
> diff --git a/Documentation/devicetree/bindings/input/touchscreen/trivial-touch.yaml b/Documentation/devicetree/bindings/input/touchscreen/trivial-touch.yaml
> index c393cce273c5b..d6aed3afd4acb 100644
> --- a/Documentation/devicetree/bindings/input/touchscreen/trivial-touch.yaml
> +++ b/Documentation/devicetree/bindings/input/touchscreen/trivial-touch.yaml
> @@ -14,6 +14,8 @@ properties:
>      enum:
>        # MAXI MAX11801 Resistive touch screen controller with i2c interface
>        - maxim,max11801
> +      # Microchip AR1020 and AR1021 touchscreen interface (I2C)
> +      - microchip,ar1021-i2c
>  
>    reg:
>      maxItems: 1
> -- 
> 2.34.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v2 2/2] dt-bindings: touchscreen: move ar1021.txt to trivial-touch.yaml
  2025-09-30 19:05   ` Conor Dooley
@ 2025-10-01 21:34     ` Frank Li
  2025-10-02  3:06       ` Rob Herring
  0 siblings, 1 reply; 8+ messages in thread
From: Frank Li @ 2025-10-01 21:34 UTC (permalink / raw)
  To: Conor Dooley
  Cc: Dmitry Torokhov, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	open list:INPUT (KEYBOARD, MOUSE, JOYSTICK, TOUCHSCREEN)...,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	open list, imx

On Tue, Sep 30, 2025 at 08:05:56PM +0100, Conor Dooley wrote:
> On Fri, Sep 26, 2025 at 02:47:12PM -0400, Frank Li wrote:
> > ar1021 have only reg and interrupts property beside touch common
> > properties. So move context of ar1021.txt into trivial-touch.yaml.
> >
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > ---
> > change in v2
> >  move to trivial-touch.yaml
> >
> > previous discussion
> >     https://lore.kernel.org/imx/20250925-swimming-overspend-ddf7ab4a252c@spud/T/#t
>
> You mentioned there were a load of other devices using just these 3
> properties. Do you intend moving those too?

I go through other yaml, I have not found more. But there are somes, which
have one additonal properties reset-gpios.

If add 'reset-gpios' as optional property here, I can move more these into
this files. But I am not sure if it is good idea to lose restriction or
use if branch in trivial-touch.yaml.

In other trivial-*.yaml, there are one reset-gpios and one power-supply.

Frank
>
> > ---
> >  .../bindings/input/touchscreen/ar1021.txt         | 15 ---------------
> >  .../bindings/input/touchscreen/trivial-touch.yaml |  2 ++
> >  2 files changed, 2 insertions(+), 15 deletions(-)
> >  delete mode 100644 Documentation/devicetree/bindings/input/touchscreen/ar1021.txt
> >
> > diff --git a/Documentation/devicetree/bindings/input/touchscreen/ar1021.txt b/Documentation/devicetree/bindings/input/touchscreen/ar1021.txt
> > deleted file mode 100644
> > index 82019bd6094ee..0000000000000
> > --- a/Documentation/devicetree/bindings/input/touchscreen/ar1021.txt
> > +++ /dev/null
> > @@ -1,15 +0,0 @@
> > -* Microchip AR1020 and AR1021 touchscreen interface (I2C)
> > -
> > -Required properties:
> > -- compatible		: "microchip,ar1021-i2c"
> > -- reg			: I2C slave address
> > -- interrupts		: touch controller interrupt
> > -
> > -Example:
> > -
> > -	touchscreen@4d {
> > -		compatible = "microchip,ar1021-i2c";
> > -		reg = <0x4d>;
> > -		interrupt-parent = <&gpio3>;
> > -		interrupts = <11 IRQ_TYPE_LEVEL_HIGH>;
> > -	};
> > diff --git a/Documentation/devicetree/bindings/input/touchscreen/trivial-touch.yaml b/Documentation/devicetree/bindings/input/touchscreen/trivial-touch.yaml
> > index c393cce273c5b..d6aed3afd4acb 100644
> > --- a/Documentation/devicetree/bindings/input/touchscreen/trivial-touch.yaml
> > +++ b/Documentation/devicetree/bindings/input/touchscreen/trivial-touch.yaml
> > @@ -14,6 +14,8 @@ properties:
> >      enum:
> >        # MAXI MAX11801 Resistive touch screen controller with i2c interface
> >        - maxim,max11801
> > +      # Microchip AR1020 and AR1021 touchscreen interface (I2C)
> > +      - microchip,ar1021-i2c
> >
> >    reg:
> >      maxItems: 1
> > --
> > 2.34.1
> >



^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v2 2/2] dt-bindings: touchscreen: move ar1021.txt to trivial-touch.yaml
  2025-10-01 21:34     ` Frank Li
@ 2025-10-02  3:06       ` Rob Herring
  0 siblings, 0 replies; 8+ messages in thread
From: Rob Herring @ 2025-10-02  3:06 UTC (permalink / raw)
  To: Frank Li
  Cc: Conor Dooley, Dmitry Torokhov, Krzysztof Kozlowski, Conor Dooley,
	open list:INPUT (KEYBOARD, MOUSE, JOYSTICK, TOUCHSCREEN)...,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	open list, imx

On Wed, Oct 01, 2025 at 05:34:18PM -0400, Frank Li wrote:
> On Tue, Sep 30, 2025 at 08:05:56PM +0100, Conor Dooley wrote:
> > On Fri, Sep 26, 2025 at 02:47:12PM -0400, Frank Li wrote:
> > > ar1021 have only reg and interrupts property beside touch common
> > > properties. So move context of ar1021.txt into trivial-touch.yaml.
> > >
> > > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > > ---
> > > change in v2
> > >  move to trivial-touch.yaml
> > >
> > > previous discussion
> > >     https://lore.kernel.org/imx/20250925-swimming-overspend-ddf7ab4a252c@spud/T/#t
> >
> > You mentioned there were a load of other devices using just these 3
> > properties. Do you intend moving those too?
> 
> I go through other yaml, I have not found more. But there are somes, which
> have one additonal properties reset-gpios.
> 
> If add 'reset-gpios' as optional property here, I can move more these into
> this files. But I am not sure if it is good idea to lose restriction or
> use if branch in trivial-touch.yaml.

That seems fine. Unless reset-gpios is required, I don't think you need 
an if/then schema. Even required probably doesn't make sense. Any board 
design could tie off the reset or make it not s/w controlled.

Rob

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v2 1/2] dt-bindings: touchscreen: rename maxim,max11801.yaml to trivial-touch.yaml
  2025-09-26 18:47 [PATCH v2 1/2] dt-bindings: touchscreen: rename maxim,max11801.yaml to trivial-touch.yaml Frank Li
  2025-09-26 18:47 ` [PATCH v2 2/2] dt-bindings: touchscreen: move ar1021.txt " Frank Li
@ 2025-10-02  3:07 ` Rob Herring (Arm)
  2025-10-18  4:22 ` Dmitry Torokhov
  2 siblings, 0 replies; 8+ messages in thread
From: Rob Herring (Arm) @ 2025-10-02  3:07 UTC (permalink / raw)
  To: Frank Li
  Cc: Conor Dooley, linux-kernel, devicetree, linux-input, imx,
	Dmitry Torokhov, Krzysztof Kozlowski


On Fri, 26 Sep 2025 14:47:11 -0400, Frank Li wrote:
> Rename maxim,max11801.yaml to trivial-touch.yaml for simple i2c touch
> controller with one interrupt and common touch properties.
> 
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> change in v2
> new patch
> 
> previous discussion
> https://lore.kernel.org/imx/20250925-swimming-overspend-ddf7ab4a252c@spud/T/#t
> ---
>  .../{maxim,max11801.yaml => trivial-touch.yaml}           | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
>  rename Documentation/devicetree/bindings/input/touchscreen/{maxim,max11801.yaml => trivial-touch.yaml} (74%)
> 

Reviewed-by: Rob Herring (Arm) <robh@kernel.org>


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v2 1/2] dt-bindings: touchscreen: rename maxim,max11801.yaml to trivial-touch.yaml
  2025-09-26 18:47 [PATCH v2 1/2] dt-bindings: touchscreen: rename maxim,max11801.yaml to trivial-touch.yaml Frank Li
  2025-09-26 18:47 ` [PATCH v2 2/2] dt-bindings: touchscreen: move ar1021.txt " Frank Li
  2025-10-02  3:07 ` [PATCH v2 1/2] dt-bindings: touchscreen: rename maxim,max11801.yaml " Rob Herring (Arm)
@ 2025-10-18  4:22 ` Dmitry Torokhov
  2 siblings, 0 replies; 8+ messages in thread
From: Dmitry Torokhov @ 2025-10-18  4:22 UTC (permalink / raw)
  To: Frank Li
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	open list:INPUT (KEYBOARD, MOUSE, JOYSTICK, TOUCHSCREEN)...,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	open list, imx

On Fri, Sep 26, 2025 at 02:47:11PM -0400, Frank Li wrote:
> Rename maxim,max11801.yaml to trivial-touch.yaml for simple i2c touch
> controller with one interrupt and common touch properties.
> 
> Signed-off-by: Frank Li <Frank.Li@nxp.com>

Applied, thank you.

-- 
Dmitry

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v2 2/2] dt-bindings: touchscreen: move ar1021.txt to trivial-touch.yaml
  2025-09-26 18:47 ` [PATCH v2 2/2] dt-bindings: touchscreen: move ar1021.txt " Frank Li
  2025-09-30 19:05   ` Conor Dooley
@ 2025-10-18  4:22   ` Dmitry Torokhov
  1 sibling, 0 replies; 8+ messages in thread
From: Dmitry Torokhov @ 2025-10-18  4:22 UTC (permalink / raw)
  To: Frank Li
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	open list:INPUT (KEYBOARD, MOUSE, JOYSTICK, TOUCHSCREEN)...,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	open list, imx

On Fri, Sep 26, 2025 at 02:47:12PM -0400, Frank Li wrote:
> ar1021 have only reg and interrupts property beside touch common
> properties. So move context of ar1021.txt into trivial-touch.yaml.
> 
> Signed-off-by: Frank Li <Frank.Li@nxp.com>

Applied, thank you.

-- 
Dmitry

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2025-10-18  4:22 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-26 18:47 [PATCH v2 1/2] dt-bindings: touchscreen: rename maxim,max11801.yaml to trivial-touch.yaml Frank Li
2025-09-26 18:47 ` [PATCH v2 2/2] dt-bindings: touchscreen: move ar1021.txt " Frank Li
2025-09-30 19:05   ` Conor Dooley
2025-10-01 21:34     ` Frank Li
2025-10-02  3:06       ` Rob Herring
2025-10-18  4:22   ` Dmitry Torokhov
2025-10-02  3:07 ` [PATCH v2 1/2] dt-bindings: touchscreen: rename maxim,max11801.yaml " Rob Herring (Arm)
2025-10-18  4:22 ` Dmitry Torokhov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).