linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Frank Li <Frank.li@nxp.com>
Cc: Conor Dooley <conor@kernel.org>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	"open list:INPUT (KEYBOARD, MOUSE, JOYSTICK,
	TOUCHSCREEN)..." <linux-input@vger.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>,
	imx@lists.linux.dev
Subject: Re: [PATCH v2 2/2] dt-bindings: touchscreen: move ar1021.txt to trivial-touch.yaml
Date: Wed, 1 Oct 2025 22:06:36 -0500	[thread overview]
Message-ID: <20251002030636.GA2975104-robh@kernel.org> (raw)
In-Reply-To: <aN2eWrTWsonkchJT@lizhi-Precision-Tower-5810>

On Wed, Oct 01, 2025 at 05:34:18PM -0400, Frank Li wrote:
> On Tue, Sep 30, 2025 at 08:05:56PM +0100, Conor Dooley wrote:
> > On Fri, Sep 26, 2025 at 02:47:12PM -0400, Frank Li wrote:
> > > ar1021 have only reg and interrupts property beside touch common
> > > properties. So move context of ar1021.txt into trivial-touch.yaml.
> > >
> > > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > > ---
> > > change in v2
> > >  move to trivial-touch.yaml
> > >
> > > previous discussion
> > >     https://lore.kernel.org/imx/20250925-swimming-overspend-ddf7ab4a252c@spud/T/#t
> >
> > You mentioned there were a load of other devices using just these 3
> > properties. Do you intend moving those too?
> 
> I go through other yaml, I have not found more. But there are somes, which
> have one additonal properties reset-gpios.
> 
> If add 'reset-gpios' as optional property here, I can move more these into
> this files. But I am not sure if it is good idea to lose restriction or
> use if branch in trivial-touch.yaml.

That seems fine. Unless reset-gpios is required, I don't think you need 
an if/then schema. Even required probably doesn't make sense. Any board 
design could tie off the reset or make it not s/w controlled.

Rob

  reply	other threads:[~2025-10-02  3:06 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-26 18:47 [PATCH v2 1/2] dt-bindings: touchscreen: rename maxim,max11801.yaml to trivial-touch.yaml Frank Li
2025-09-26 18:47 ` [PATCH v2 2/2] dt-bindings: touchscreen: move ar1021.txt " Frank Li
2025-09-30 19:05   ` Conor Dooley
2025-10-01 21:34     ` Frank Li
2025-10-02  3:06       ` Rob Herring [this message]
2025-10-18  4:22   ` Dmitry Torokhov
2025-10-02  3:07 ` [PATCH v2 1/2] dt-bindings: touchscreen: rename maxim,max11801.yaml " Rob Herring (Arm)
2025-10-18  4:22 ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251002030636.GA2975104-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=Frank.li@nxp.com \
    --cc=conor+dt@kernel.org \
    --cc=conor@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=imx@lists.linux.dev \
    --cc=krzk+dt@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).