From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D3A6B309EE8 for ; Mon, 13 Oct 2025 14:15:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760364925; cv=none; b=tlD7GPuoiZEfgeClT+TzPc1xK8Z4Bw01y6CVGCjAQ0S0I8RYdNWs7/2qr5CxgZ6Xo739IuygV9LhY+7gjcZdmilZhLOYYK2uUPrqB+udOaby9/4KjvIxhvY9IkTpuIh6oV/2hcYr/6Qn2DBQrvARji72gUyvGXFzbEYtFCRYiG0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760364925; c=relaxed/simple; bh=/OmRUoPBoEYkKTL+GrsA3lQ6tTfUILZu4X7YtVySLKM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=QDCNkvLZhyuZejXpIyrmpbSts4J/wLTQfWmcRgASRBZFWbTllbKEsz6F5THHwakP+XAvsn0vyi2UToTiOpOCqevPUY0Rvw5Sw42qQlkq+gA6Jp0yBqmuQGH8wm1vpPlZDJZNTZn63SMuO56Y/NpTolFrHqtSFtI4V2xWOs3zOi4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=SFdqfhh3; arc=none smtp.client-ip=209.85.167.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="SFdqfhh3" Received: by mail-lf1-f50.google.com with SMTP id 2adb3069b0e04-58b025fce96so3764071e87.1 for ; Mon, 13 Oct 2025 07:15:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1760364906; x=1760969706; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=7VLNzWiaaayGbLPJ+CR/kQopGEdhcg7BnTJUn+bNJDA=; b=SFdqfhh3bczcf41j5XUUtuiDMCkMAMYAetRyTM+H84dwbdWGACADRM4A9KxOSvn06q 3qhYDRbdXb/EtD9N8ilQPL9LPSwbTUFAj6Y2lkLNERqX4mhLjSb4kjxvC7wPgGJjZbK1 em6Tndb17CQMg0HeViCsEF2XeNQZvWvKqbk90= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760364906; x=1760969706; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7VLNzWiaaayGbLPJ+CR/kQopGEdhcg7BnTJUn+bNJDA=; b=R0c8j4Mnq8sMcniAx1ekSGGfi9N4xzsGzP8Mqy1UESpeOy1PA60fsFyRKRGlfy/Lwt CEEi20TazpdoA08e9mKlYMDlma94j65mlNE4wrHC15oVSN0VuhtAdYLx8uWEQwR3Pe+4 7AVj8ZzwNeAp5XQjahk9UR6f/DxtaQoNB+GZeucGXz0APkAK9qyWvQbG+rDhb9mpSiri LyCb98ORv40o94bkHnU9vBdZKkNCIC3adLN4WJ8ImfuI+boaMjs5Hyagr9/wwaOjPWvZ F6xdd6MfeJ5hPhgvuKkxQhe2+/RxVwGKU80HdFsswgsZuYssLu0tIRV8VqyEk4w+KTtK uH/Q== X-Gm-Message-State: AOJu0YwBsY++0R4m/O1mnb8MCIn07KuzXMUo+aErzYvcbREI/kgwUyVc MeXpa0HHUrT0atmUlpvoDfB9Hrb4J9CZyRpbVRV33C7GriLPD1cby1v2NZJNV6BqLA== X-Gm-Gg: ASbGncv9HnZLd7tvHuq2yV9ZxBTL/l5594gNhkJ2wUPWbg7VrXSo7VwrI8N3uwj04Sy 55QXux/taZ6YP2Ck2+sbOzlKyxp4v0+7s8+SHVoOA73FzDl3rW+W3QgwLqyN42CA5tVNm/hLLTw Vh5CRYyYOjn+1CEIXk3/yDxdMrYdb1HhSmSBs5Wl//wPjBXvhiq/tXHFmq020H1HW1f36YlWdHv hPQsAp4XyKmE/v818k+SkrigoaWhn+M3eq53PuZmjJSadoIXXa6IO3G8fm0G0GrNNDDo8M8HkLo BmY1ZhGlPz9RStr8Ue7S1veYVwOJP8H2pCNAR3dycBWtcJEoVr/A1SIa2fsJI+cLOmICUIOzeFb hPkpKG/bRgqk4PXsF6FfSNCoSj4zrx2lNNUrQsC9MwEisG/OVos1ZUMUdX+UGvNsA05ECxi9Dv3 IBtsNRSSCC1vg6BWDang== X-Google-Smtp-Source: AGHT+IHgQ/WMhPa6rwn8Aka868vYVRu77lc4adXi44XLWG27weltH/9eVYPP+kQHy8I85fd7fOXyWw== X-Received: by 2002:a05:6512:3c87:b0:58b:23e:5ec with SMTP id 2adb3069b0e04-5906d8e5b43mr6011775e87.26.1760364906103; Mon, 13 Oct 2025 07:15:06 -0700 (PDT) Received: from ribalda.c.googlers.com (56.213.88.34.bc.googleusercontent.com. [34.88.213.56]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-590881e4e58sm4165256e87.25.2025.10.13.07.15.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Oct 2025 07:15:05 -0700 (PDT) From: Ricardo Ribalda Date: Mon, 13 Oct 2025 14:15:08 +0000 Subject: [PATCH 28/32] media: rkisp1: Use %pe format specifier Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20251013-ptr_err-v1-28-2c5efbd82952@chromium.org> References: <20251013-ptr_err-v1-0-2c5efbd82952@chromium.org> In-Reply-To: <20251013-ptr_err-v1-0-2c5efbd82952@chromium.org> To: Linus Walleij , Dmitry Torokhov , Mauro Carvalho Chehab , Hans Verkuil , Sakari Ailus , =?utf-8?q?Krzysztof_Ha=C5=82asa?= , Tomi Valkeinen , Leon Luo , Kieran Bingham , Jacopo Mondi , Kieran Bingham , Laurent Pinchart , =?utf-8?q?Niklas_S=C3=B6derlund?= , Julien Massot , Jacopo Mondi , Daniel Scally , Dave Stevenson , Benjamin Mugnier , Sylvain Petinot , Yong Zhi , Bingbu Cao , Tianshu Qiu , Tiffany Lin , Andrew-CT Chen , Yunfei Dong , Matthias Brugger , AngeloGioacchino Del Regno , Rui Miguel Silva , Laurent Pinchart , Martin Kepplinger , Purism Kernel Team , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Dafna Hirschfeld , Heiko Stuebner , Sylwester Nawrocki , Krzysztof Kozlowski , Alim Akhtar , Yemike Abhilash Chandra , Greg Kroah-Hartman Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, imx@lists.linux.dev, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-staging@lists.linux.dev, Ricardo Ribalda X-Mailer: b4 0.14.2 The %pe format specifier is designed to print error pointers. It prints a symbolic error name (eg. -EINVAL) and it makes the code simpler by omitting PTR_ERR(). This patch fixes this cocci report: ./platform/rockchip/rkisp1/rkisp1-isp.c:940:3-10: WARNING: Consider using %pe to print PTR_ERR() ./platform/rockchip/rkisp1/rkisp1-csi.c:372:3-10: WARNING: Consider using %pe to print PTR_ERR() Signed-off-by: Ricardo Ribalda --- drivers/media/platform/rockchip/rkisp1/rkisp1-csi.c | 4 ++-- drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-csi.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-csi.c index 841e58c20f7fcb484643138627413425a049d1fa..ddc6182f3e4bdacdd1962c86f6259334b16aa505 100644 --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-csi.c +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-csi.c @@ -368,8 +368,8 @@ static int rkisp1_csi_s_stream(struct v4l2_subdev *sd, int enable) source_pad = media_entity_remote_source_pad_unique(&sd->entity); if (IS_ERR(source_pad)) { - dev_dbg(rkisp1->dev, "Failed to get source for CSI: %ld\n", - PTR_ERR(source_pad)); + dev_dbg(rkisp1->dev, "Failed to get source for CSI: %pe\n", + source_pad); return -EPIPE; } diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c index 8c29a1c9309a846152d212dcb50b7bf991d4f422..147d33eb6ee0d975b257c5df2997b811ba3a62e1 100644 --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c @@ -936,8 +936,8 @@ static int rkisp1_isp_s_stream(struct v4l2_subdev *sd, int enable) sink_pad = &isp->pads[RKISP1_ISP_PAD_SINK_VIDEO]; source_pad = media_pad_remote_pad_unique(sink_pad); if (IS_ERR(source_pad)) { - dev_dbg(rkisp1->dev, "Failed to get source for ISP: %ld\n", - PTR_ERR(source_pad)); + dev_dbg(rkisp1->dev, "Failed to get source for ISP: %pe\n", + source_pad); return -EPIPE; } -- 2.51.0.760.g7b8bcc2412-goog