From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from flow-a4-smtp.messagingengine.com (flow-a4-smtp.messagingengine.com [103.168.172.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 52CF818A921; Thu, 16 Oct 2025 22:15:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.139 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760652938; cv=none; b=DuDMQAriwg6P2XH3xpriy9Z9IC0NeS2WFwavlEB7PStuXza/9Oojzjyr3fVyJETAsg23+S6+iPhwkgsx4K7lrOwH9rLsW51ZI0j3tnPkbEIu3v4dk94Qn2Lydd5482Z7ySg1LFEEVWCxpGrxTgJn3myBqFPzgJ1LLpc7zNHyOlI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760652938; c=relaxed/simple; bh=iLsGMz+lQC5s46WAZOiKnbc49kyx8W/cCQalytEP0d4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=C2NWA5ZVZmZz6FK3+ZFvFe3jEPzn4/nG5O79RVi3GV11Vi8dz14A4WuNBO5Wa6qDrbXts2nIyy+Yvpjr51lsuHR8uSKDb76ntPz7/hFcMGkIemkbX2HEpvGxdFyT5h+mvPIFnGF50UMmHZEa59kW8XkSQOXHpplFP3BQbw/ytHw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=jannau.net; spf=pass smtp.mailfrom=jannau.net; dkim=pass (2048-bit key) header.d=jannau.net header.i=@jannau.net header.b=NjE4FnF6; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=iVkCqK+h; arc=none smtp.client-ip=103.168.172.139 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=jannau.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=jannau.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=jannau.net header.i=@jannau.net header.b="NjE4FnF6"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="iVkCqK+h" Received: from phl-compute-04.internal (phl-compute-04.internal [10.202.2.44]) by mailflow.phl.internal (Postfix) with ESMTP id 8715A13806A9; Thu, 16 Oct 2025 18:15:36 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-04.internal (MEProxy); Thu, 16 Oct 2025 18:15:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jannau.net; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm1; t=1760652936; x=1760660136; bh=vzGgZImo0E BsLEHlMR5wSNL1BxVaGZmB0ngBJ00VQ1k=; b=NjE4FnF6Z+Hv6BZwdj5D3rMGXY kWOPybw+UtFAjB9c+eY7rb2ymabUocvJVuGzPJrtzsODKO4/HSLcTuiGXvyUuQjS ktcTx5bCIwNyzBcXJsGwkxJsoGyET/iATGKYpLfRT1wCs/3CR++i8KafKSzJz3ua Wp2s5Rww3P5DN0G2cbv7QM2lGcno5Jm4tDmiTPWwqE1LdWsUcF40UH3DnHCjwMMV K5N4+kgBBgDTYI+7wM3ykOUKvGq8cNIqiLWH11ieN72wz8p6tIzgyLAvQweH2fTs u9AuS7cx+Pmw+t5ds3l9vK7n0xBvwpBf5F6mCu4WRneYHvzutFzPT1kVcDZA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1760652936; x=1760660136; bh=vzGgZImo0EBsLEHlMR5wSNL1BxVaGZmB0ng BJ00VQ1k=; b=iVkCqK+haRPM1XGAf9do5aP3G/azCfSHzaj9S/42bCPv7p8sjjf WS7FueNNN9173kz4jxwbeQxtxZwl7De+/wQxC6m8ah9Aat6sw6WHkL0YWcQ/Uydk lK02Cjpk/vc+jBI7upCVTsNmgHiADk7Xnu64LbRQ0ARY627QsiHpw6IobiQ/4Uk/ PU0Z3g7y8AP8zZDLgY4HzZC8JJuNgWnxK72YcpnoW8OIPWQyud+yEhaHyjeYbl6d Xm2VxMUUhcaNwsgjh2dA2eMEInMDhl2mfhTY62vyepdV+5ylSPN70J1JPCaI84IO lzPADqq0+HHWwYpvUI0eQaQGefi2BRocMaQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggdduvdejgeeiucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhepfffhvfevuffkfhggtggujgesthdtredttddtjeenucfhrhhomheplfgrnhhnvgcu ifhruhhnrghuuceojhesjhgrnhhnrghurdhnvghtqeenucggtffrrghtthgvrhhnpefgvd ffveelgedujeeffeehheekheelheefgfejffeftedugeethfeuudefheefteenucevlhhu shhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehjsehjrghnnhgruh drnhgvthdpnhgspghrtghpthhtohepvdefpdhmohguvgepshhmthhpohhuthdprhgtphht thhopehjtggrlhhlihhgvghrohhsleelsehgmhgrihhlrdgtohhmpdhrtghpthhtohepsh hvvghnsehkvghrnhgvlhdrohhrghdprhgtphhtthhopegrlhihshhsrgesrhhoshgvnhii figvihhgrdhiohdprhgtphhtthhopehnvggrlhesghhomhhprgdruggvvhdprhgtphhtth hopehlvggvsehkvghrnhgvlhdrohhrghdprhgtphhtthhopehrohgshheskhgvrhhnvghl rdhorhhgpdhrtghpthhtohepkhhriihkodgutheskhgvrhhnvghlrdhorhhgpdhrtghpth htoheptghonhhorhdoughtsehkvghrnhgvlhdrohhrghdprhgtphhtthhopegrlhgvgigr nhgurhgvrdgsvghllhhonhhisegsohhothhlihhnrdgtohhm X-ME-Proxy: Feedback-ID: i47b949f6:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 16 Oct 2025 18:15:34 -0400 (EDT) Date: Fri, 17 Oct 2025 00:15:33 +0200 From: Janne Grunau To: James Calligeros Cc: Sven Peter , Alyssa Rosenzweig , Neal Gompa , Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alexandre Belloni , Jean Delvare , Guenter Roeck , Dmitry Torokhov , Jonathan Corbet , asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-input@vger.kernel.org, linux-doc@vger.kernel.org, Mark Kettenis , Hector Martin Subject: Re: [PATCH v3 00/13] mfd: macsmc: add rtc, hwmon and hid subdevices Message-ID: <20251016221533.GD897177@robin.jannau.net> References: <20251007-macsmc-subdevs-v3-0-d7d3bfd7ae02@gmail.com> Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20251007-macsmc-subdevs-v3-0-d7d3bfd7ae02@gmail.com> On Tue, Oct 07, 2025 at 09:16:41PM +1000, James Calligeros wrote: > Hi all, > > This series adds support for the remaining SMC subdevices. These are the > RTC, hwmon, and HID devices. They are being submitted together as the RTC > and hwmon drivers both require changes to the SMC DT schema. > > The RTC driver is responsible for getting and setting the system clock, > and requires an NVMEM cell. This series replaces Sven's original RTC driver > submission [1]. > > The hwmon function is an interesting one. While each Apple Silicon device > exposes pretty similar sets of sensors, these all seem to be paired to > different SMC keys in the firmware interface. This is true even when the > sensors are on the SoC. For example, an M1 MacBook Pro will use different > keys to access the LITTLE core temperature sensors to an M1 Mac mini. This > necessitates describing which keys correspond to which sensors for each > device individually, and populating the hwmon structs at runtime. We do > this with a node in the device tree. This series includes only the keys > for sensors which we know to be common to all devices. The SMC is also > responsible for monitoring and controlling fan speeds on systems with fans, > which we expose via the hwmon driver. The split of the hwmon dts changes looks weird to me. It's not a lot of changes so squashing everything together into a single commit might be ok. If you want to split the commits splitting them by SoC (t8103, t8112, t600x, ...) and adding common sensor defines as needed might work better. > The SMC also handles the hardware power button and lid switch. Power > button presses and lid opening/closing are emitted as HID events, so we > add an input subdevice to handle them. The cover letter doesn't mention a merge strategy for this series. I don't think there are any dependencies between different parts. That means the dt-bindings and driver additions can be merged through their subsystem trees. The single line patches wiring the devices up to the macsmc mfd driver should be merged together through mfd tree as they (trivially) conflict. The dts changes will be merged through the apple soc tree. Janne