Re: [PATCH 1/3] dt-bindings: mfd: twl: enable power button also for twl603x

[Andreas Kemnade <andreas@kemnade.info>]

On Tue, 21 Oct 2025 19:18:25 +0200
Krzysztof Kozlowski <krzk@kernel.org> wrote:

> On 21/10/2025 18:36, Andreas Kemnade wrote:
> > On Tue, 21 Oct 2025 11:58:49 +0200
> > Krzysztof Kozlowski <krzk@kernel.org> wrote:
> >   
> >> On 21/10/2025 10:45, Andreas Kemnade wrote:  
> >>> On Tue, 21 Oct 2025 09:10:28 +0200
> >>> Krzysztof Kozlowski <krzk@kernel.org> wrote:
> >>>     
> >>>> On 20/10/2025 14:31, akemnade@kernel.org wrote:    
> >>>>> From: Andreas Kemnade <andreas@kemnade.info>
> >>>>>
> >>>>> TWL603x has also a power button, so add the corresponding subnode.      
> >>>>
> >>>> No, we don't add subnodes just because there is a power button. This
> >>>> needs broader explanation, see also my further comment.
> >>>>    
> >>> Hmm, what is the general pattern to follow if a mfd device has some
> >>> functionality which depends on some optional external components?    
> >>
> >> Please describe it better - how these nodes depend on external
> >> component? The power button logic/IC is in this device always. It is not
> >> optional.
> >>  
> > The power button logic is always there, yes, but it depends on an optional
> > actual mechanical button connected to a pad of this device, which is
> > not always there. The logic will not work if I just put my finger on the PMIC,
> > but it will work if there is a mechanical button which I can press connected to
> > the PMIC.  
> 
> 
> Hm... how do you represent this logic now? By adding status=disabled to
> the pwrbutton node?
> 
Yes, or by simply not adding tho pwrbutton node at all. Well, if we break
the legacy pattern here, we can probably add a property for this.


Regards,
Andreas