* [PATCH 1/1] HID: intel-thc-hid: Remove redundant pm_runtime_mark_last_busy() calls
@ 2025-10-27 12:01 Sakari Ailus
2025-10-28 0:42 ` Xu, Even
2025-10-30 10:27 ` Jiri Kosina
0 siblings, 2 replies; 3+ messages in thread
From: Sakari Ailus @ 2025-10-27 12:01 UTC (permalink / raw)
To: linux-input
Cc: Even Xu, Xinpeng Sun, Jiri Kosina, Benjamin Tissoires,
Srinivas Pandruvada, Mark Pearson, Philipp Stanner, Wentao Guan,
Abhishek Tamboli
pm_runtime_put_autosuspend(), pm_runtime_put_sync_autosuspend(),
pm_runtime_autosuspend() and pm_request_autosuspend() now include a call
to pm_runtime_mark_last_busy(). Remove the now-reduntant explicit call to
pm_runtime_mark_last_busy().
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
drivers/hid/intel-thc-hid/intel-quicki2c/pci-quicki2c.c | 2 --
drivers/hid/intel-thc-hid/intel-quicki2c/quicki2c-hid.c | 1 -
drivers/hid/intel-thc-hid/intel-quickspi/pci-quickspi.c | 2 --
drivers/hid/intel-thc-hid/intel-quickspi/quickspi-hid.c | 1 -
4 files changed, 6 deletions(-)
diff --git a/drivers/hid/intel-thc-hid/intel-quicki2c/pci-quicki2c.c b/drivers/hid/intel-thc-hid/intel-quicki2c/pci-quicki2c.c
index 0156ab391778..cfda66ee4895 100644
--- a/drivers/hid/intel-thc-hid/intel-quicki2c/pci-quicki2c.c
+++ b/drivers/hid/intel-thc-hid/intel-quicki2c/pci-quicki2c.c
@@ -344,7 +344,6 @@ static irqreturn_t quicki2c_irq_thread_handler(int irq, void *dev_id)
if (try_recover(qcdev))
qcdev->state = QUICKI2C_DISABLED;
- pm_runtime_mark_last_busy(qcdev->dev);
pm_runtime_put_autosuspend(qcdev->dev);
return IRQ_HANDLED;
@@ -735,7 +734,6 @@ static int quicki2c_probe(struct pci_dev *pdev, const struct pci_device_id *id)
/* Enable runtime power management */
pm_runtime_use_autosuspend(qcdev->dev);
pm_runtime_set_autosuspend_delay(qcdev->dev, DEFAULT_AUTO_SUSPEND_DELAY_MS);
- pm_runtime_mark_last_busy(qcdev->dev);
pm_runtime_put_noidle(qcdev->dev);
pm_runtime_put_autosuspend(qcdev->dev);
diff --git a/drivers/hid/intel-thc-hid/intel-quicki2c/quicki2c-hid.c b/drivers/hid/intel-thc-hid/intel-quicki2c/quicki2c-hid.c
index 5c3ec95bb3fd..834a537b6780 100644
--- a/drivers/hid/intel-thc-hid/intel-quicki2c/quicki2c-hid.c
+++ b/drivers/hid/intel-thc-hid/intel-quicki2c/quicki2c-hid.c
@@ -72,7 +72,6 @@ static int quicki2c_hid_raw_request(struct hid_device *hid,
break;
}
- pm_runtime_mark_last_busy(qcdev->dev);
pm_runtime_put_autosuspend(qcdev->dev);
return ret;
diff --git a/drivers/hid/intel-thc-hid/intel-quickspi/pci-quickspi.c b/drivers/hid/intel-thc-hid/intel-quickspi/pci-quickspi.c
index 14cabd5dc6dd..ad6bd59963b2 100644
--- a/drivers/hid/intel-thc-hid/intel-quickspi/pci-quickspi.c
+++ b/drivers/hid/intel-thc-hid/intel-quickspi/pci-quickspi.c
@@ -339,7 +339,6 @@ static irqreturn_t quickspi_irq_thread_handler(int irq, void *dev_id)
if (try_recover(qsdev))
qsdev->state = QUICKSPI_DISABLED;
- pm_runtime_mark_last_busy(qsdev->dev);
pm_runtime_put_autosuspend(qsdev->dev);
return IRQ_HANDLED;
@@ -674,7 +673,6 @@ static int quickspi_probe(struct pci_dev *pdev,
/* Enable runtime power management */
pm_runtime_use_autosuspend(qsdev->dev);
pm_runtime_set_autosuspend_delay(qsdev->dev, DEFAULT_AUTO_SUSPEND_DELAY_MS);
- pm_runtime_mark_last_busy(qsdev->dev);
pm_runtime_put_noidle(qsdev->dev);
pm_runtime_put_autosuspend(qsdev->dev);
diff --git a/drivers/hid/intel-thc-hid/intel-quickspi/quickspi-hid.c b/drivers/hid/intel-thc-hid/intel-quickspi/quickspi-hid.c
index ad52e402c28a..82c72bfa2795 100644
--- a/drivers/hid/intel-thc-hid/intel-quickspi/quickspi-hid.c
+++ b/drivers/hid/intel-thc-hid/intel-quickspi/quickspi-hid.c
@@ -71,7 +71,6 @@ static int quickspi_hid_raw_request(struct hid_device *hid,
break;
}
- pm_runtime_mark_last_busy(qsdev->dev);
pm_runtime_put_autosuspend(qsdev->dev);
return ret;
--
2.47.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH 1/1] HID: intel-thc-hid: Remove redundant pm_runtime_mark_last_busy() calls
2025-10-27 12:01 [PATCH 1/1] HID: intel-thc-hid: Remove redundant pm_runtime_mark_last_busy() calls Sakari Ailus
@ 2025-10-28 0:42 ` Xu, Even
2025-10-30 10:27 ` Jiri Kosina
1 sibling, 0 replies; 3+ messages in thread
From: Xu, Even @ 2025-10-28 0:42 UTC (permalink / raw)
To: Sakari Ailus, linux-input@vger.kernel.org
Cc: Sun, Xinpeng, Jiri Kosina, Benjamin Tissoires,
Srinivas Pandruvada, Mark Pearson, Philipp Stanner, Wentao Guan,
Abhishek Tamboli
> -----Original Message-----
> From: Sakari Ailus <sakari.ailus@linux.intel.com>
> Sent: Monday, October 27, 2025 8:01 PM
> To: linux-input@vger.kernel.org
> Cc: Xu, Even <even.xu@intel.com>; Sun, Xinpeng <xinpeng.sun@intel.com>; Jiri
> Kosina <jikos@kernel.org>; Benjamin Tissoires <bentiss@kernel.org>; Srinivas
> Pandruvada <srinivas.pandruvada@linux.intel.com>; Mark Pearson <mpearson-
> lenovo@squebb.ca>; Philipp Stanner <phasta@kernel.org>; Wentao Guan
> <guanwentao@uniontech.com>; Abhishek Tamboli
> <abhishektamboli9@gmail.com>
> Subject: [PATCH 1/1] HID: intel-thc-hid: Remove redundant
> pm_runtime_mark_last_busy() calls
>
> pm_runtime_put_autosuspend(), pm_runtime_put_sync_autosuspend(),
> pm_runtime_autosuspend() and pm_request_autosuspend() now include a call to
> pm_runtime_mark_last_busy(). Remove the now-reduntant explicit call to
> pm_runtime_mark_last_busy().
>
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Thanks for the patch!
Reviewed-by: Even Xu <even.xu@intel.com>
Best Regards,
Even Xu
> ---
> drivers/hid/intel-thc-hid/intel-quicki2c/pci-quicki2c.c | 2 -- drivers/hid/intel-
> thc-hid/intel-quicki2c/quicki2c-hid.c | 1 - drivers/hid/intel-thc-hid/intel-
> quickspi/pci-quickspi.c | 2 -- drivers/hid/intel-thc-hid/intel-quickspi/quickspi-
> hid.c | 1 -
> 4 files changed, 6 deletions(-)
>
> diff --git a/drivers/hid/intel-thc-hid/intel-quicki2c/pci-quicki2c.c
> b/drivers/hid/intel-thc-hid/intel-quicki2c/pci-quicki2c.c
> index 0156ab391778..cfda66ee4895 100644
> --- a/drivers/hid/intel-thc-hid/intel-quicki2c/pci-quicki2c.c
> +++ b/drivers/hid/intel-thc-hid/intel-quicki2c/pci-quicki2c.c
> @@ -344,7 +344,6 @@ static irqreturn_t quicki2c_irq_thread_handler(int irq,
> void *dev_id)
> if (try_recover(qcdev))
> qcdev->state = QUICKI2C_DISABLED;
>
> - pm_runtime_mark_last_busy(qcdev->dev);
> pm_runtime_put_autosuspend(qcdev->dev);
>
> return IRQ_HANDLED;
> @@ -735,7 +734,6 @@ static int quicki2c_probe(struct pci_dev *pdev, const
> struct pci_device_id *id)
> /* Enable runtime power management */
> pm_runtime_use_autosuspend(qcdev->dev);
> pm_runtime_set_autosuspend_delay(qcdev->dev,
> DEFAULT_AUTO_SUSPEND_DELAY_MS);
> - pm_runtime_mark_last_busy(qcdev->dev);
> pm_runtime_put_noidle(qcdev->dev);
> pm_runtime_put_autosuspend(qcdev->dev);
>
> diff --git a/drivers/hid/intel-thc-hid/intel-quicki2c/quicki2c-hid.c
> b/drivers/hid/intel-thc-hid/intel-quicki2c/quicki2c-hid.c
> index 5c3ec95bb3fd..834a537b6780 100644
> --- a/drivers/hid/intel-thc-hid/intel-quicki2c/quicki2c-hid.c
> +++ b/drivers/hid/intel-thc-hid/intel-quicki2c/quicki2c-hid.c
> @@ -72,7 +72,6 @@ static int quicki2c_hid_raw_request(struct hid_device *hid,
> break;
> }
>
> - pm_runtime_mark_last_busy(qcdev->dev);
> pm_runtime_put_autosuspend(qcdev->dev);
>
> return ret;
> diff --git a/drivers/hid/intel-thc-hid/intel-quickspi/pci-quickspi.c
> b/drivers/hid/intel-thc-hid/intel-quickspi/pci-quickspi.c
> index 14cabd5dc6dd..ad6bd59963b2 100644
> --- a/drivers/hid/intel-thc-hid/intel-quickspi/pci-quickspi.c
> +++ b/drivers/hid/intel-thc-hid/intel-quickspi/pci-quickspi.c
> @@ -339,7 +339,6 @@ static irqreturn_t quickspi_irq_thread_handler(int irq,
> void *dev_id)
> if (try_recover(qsdev))
> qsdev->state = QUICKSPI_DISABLED;
>
> - pm_runtime_mark_last_busy(qsdev->dev);
> pm_runtime_put_autosuspend(qsdev->dev);
>
> return IRQ_HANDLED;
> @@ -674,7 +673,6 @@ static int quickspi_probe(struct pci_dev *pdev,
> /* Enable runtime power management */
> pm_runtime_use_autosuspend(qsdev->dev);
> pm_runtime_set_autosuspend_delay(qsdev->dev,
> DEFAULT_AUTO_SUSPEND_DELAY_MS);
> - pm_runtime_mark_last_busy(qsdev->dev);
> pm_runtime_put_noidle(qsdev->dev);
> pm_runtime_put_autosuspend(qsdev->dev);
>
> diff --git a/drivers/hid/intel-thc-hid/intel-quickspi/quickspi-hid.c
> b/drivers/hid/intel-thc-hid/intel-quickspi/quickspi-hid.c
> index ad52e402c28a..82c72bfa2795 100644
> --- a/drivers/hid/intel-thc-hid/intel-quickspi/quickspi-hid.c
> +++ b/drivers/hid/intel-thc-hid/intel-quickspi/quickspi-hid.c
> @@ -71,7 +71,6 @@ static int quickspi_hid_raw_request(struct hid_device *hid,
> break;
> }
>
> - pm_runtime_mark_last_busy(qsdev->dev);
> pm_runtime_put_autosuspend(qsdev->dev);
>
> return ret;
> --
> 2.47.3
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] HID: intel-thc-hid: Remove redundant pm_runtime_mark_last_busy() calls
2025-10-27 12:01 [PATCH 1/1] HID: intel-thc-hid: Remove redundant pm_runtime_mark_last_busy() calls Sakari Ailus
2025-10-28 0:42 ` Xu, Even
@ 2025-10-30 10:27 ` Jiri Kosina
1 sibling, 0 replies; 3+ messages in thread
From: Jiri Kosina @ 2025-10-30 10:27 UTC (permalink / raw)
To: Sakari Ailus
Cc: linux-input, Even Xu, Xinpeng Sun, Benjamin Tissoires,
Srinivas Pandruvada, Mark Pearson, Philipp Stanner, Wentao Guan,
Abhishek Tamboli
On Mon, 27 Oct 2025, Sakari Ailus wrote:
> pm_runtime_put_autosuspend(), pm_runtime_put_sync_autosuspend(),
> pm_runtime_autosuspend() and pm_request_autosuspend() now include a call
> to pm_runtime_mark_last_busy(). Remove the now-reduntant explicit call to
> pm_runtime_mark_last_busy().
>
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Applied, thanks.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-10-30 10:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-27 12:01 [PATCH 1/1] HID: intel-thc-hid: Remove redundant pm_runtime_mark_last_busy() calls Sakari Ailus
2025-10-28 0:42 ` Xu, Even
2025-10-30 10:27 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).