From: Josua Mayer <josua@solid-run.com>
To: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Jessica Zhang <jessica.zhang@oss.qualcomm.com>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
Thierry Reding <thierry.reding@gmail.com>
Cc: Jon Nettleton <jon@solid-run.com>,
Mikhail Anikin <mikhail.anikin@solid-run.com>,
Yazan Shhady <yazan.shhady@solid-run.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, linux-input@vger.kernel.org,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
Josua Mayer <josua@solid-run.com>
Subject: [PATCH v2 04/11] Input: ilitek_ts_i2c: fix warning with gpio controllers that sleep
Date: Fri, 07 Nov 2025 12:46:11 +0100 [thread overview]
Message-ID: <20251107-imx8mp-hb-iiot-v2-4-d8233ded999e@solid-run.com> (raw)
In-Reply-To: <20251107-imx8mp-hb-iiot-v2-0-d8233ded999e@solid-run.com>
The ilitek touchscreen driver uses the non-sleeping gpiod_set_value
function for reset.
When the connected gpio controller needs to sleep as is common for i2c
based expanders, this causes noisy complaints in kernel log.
Reset is not time-critical, switch to the gpiod_set_value_cansleep
variant.
Signed-off-by: Josua Mayer <josua@solid-run.com>
---
drivers/input/touchscreen/ilitek_ts_i2c.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/input/touchscreen/ilitek_ts_i2c.c b/drivers/input/touchscreen/ilitek_ts_i2c.c
index 0dd632724a003..8c5a54b336816 100644
--- a/drivers/input/touchscreen/ilitek_ts_i2c.c
+++ b/drivers/input/touchscreen/ilitek_ts_i2c.c
@@ -396,9 +396,9 @@ static const struct ilitek_protocol_map ptl_func_map[] = {
static void ilitek_reset(struct ilitek_ts_data *ts, int delay)
{
if (ts->reset_gpio) {
- gpiod_set_value(ts->reset_gpio, 1);
+ gpiod_set_value_cansleep(ts->reset_gpio, 1);
mdelay(10);
- gpiod_set_value(ts->reset_gpio, 0);
+ gpiod_set_value_cansleep(ts->reset_gpio, 0);
mdelay(delay);
}
}
--
2.51.0
next prev parent reply other threads:[~2025-11-07 11:46 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-07 11:46 [PATCH v2 00/11] arm64: dts: add description for solidrun imx8mp hummingboard-iiot Josua Mayer
2025-11-07 11:46 ` [PATCH v2 01/11] dt-bindings: arm: fsl: Add various solidrun i.mx8m boards Josua Mayer
2025-11-07 11:46 ` [PATCH v2 02/11] dt-bindings: display: panel: ronbo,rb070d30: panel-common ref Josua Mayer
2025-11-07 15:53 ` Frank Li
2025-11-12 11:43 ` Josua Mayer
2025-11-07 17:48 ` Conor Dooley
2025-11-12 11:51 ` Josua Mayer
2025-11-12 18:26 ` Conor Dooley
2025-11-07 11:46 ` [PATCH v2 03/11] dt-bindings: panel: lvds: add Winstar WF70A8SYJHLNGA Josua Mayer
2025-11-07 17:47 ` Conor Dooley
2025-11-07 11:46 ` Josua Mayer [this message]
2025-11-07 15:58 ` [PATCH v2 04/11] Input: ilitek_ts_i2c: fix warning with gpio controllers that sleep Frank Li
2025-11-07 11:46 ` [PATCH v2 05/11] drm/panel: ronbo-rb070d30: " Josua Mayer
2025-11-07 11:46 ` [PATCH v2 06/11] arm64: dts: imx8mp-hummingboard-pulse/cubox-m: fix vmmc gpio polarity Josua Mayer
2025-11-07 11:46 ` [PATCH v2 07/11] arm64: dts: imx8mp-hummingboard-pulse: fix mini-hdmi dsi port reference Josua Mayer
2025-11-07 11:46 ` [PATCH v2 08/11] arm64: dts: imx8mp-sr-som: build dtbs with symbols for overlay support Josua Mayer
2025-11-07 11:46 ` [PATCH v2 09/11] arm64: dts: add description for solidrun imx8mp hummingboard-iiot Josua Mayer
2025-11-07 11:46 ` [PATCH v2 10/11] arm64: dts: add description for solidrun solidsense-n8 board Josua Mayer
2025-11-07 11:46 ` [PATCH v2 11/11] arm64: dts: add description for solidrun i.mx8mm som and evb Josua Mayer
2025-11-10 14:34 ` [PATCH v2 00/11] arm64: dts: add description for solidrun imx8mp hummingboard-iiot Rob Herring (Arm)
2025-11-12 12:00 ` Josua Mayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251107-imx8mp-hb-iiot-v2-4-d8233ded999e@solid-run.com \
--to=josua@solid-run.com \
--cc=airlied@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=jessica.zhang@oss.qualcomm.com \
--cc=jon@solid-run.com \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mikhail.anikin@solid-run.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=simona@ffwll.ch \
--cc=thierry.reding@gmail.com \
--cc=tzimmermann@suse.de \
--cc=yazan.shhady@solid-run.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).