From: Krzysztof Kozlowski <krzk@kernel.org>
To: daniel_peng@pegatron.corp-partner.google.com
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-input@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Rob Herring <robh@kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v5 1/2] dt-bindings: input: i2c-hid: Introduce FocalTech FT8112
Date: Mon, 17 Nov 2025 07:30:23 +0100 [thread overview]
Message-ID: <20251117-beautiful-pink-macaque-9fd441@kuoka> (raw)
In-Reply-To: <20251117110148.v5.1.I894dde5015f4acad94cb5bada61e5811c5142395@changeid>
On Mon, Nov 17, 2025 at 11:02:10AM +0800, daniel_peng@pegatron.corp-partner.google.com wrote:
> From: Daniel Peng <Daniel_Peng@pegatron.corp-partner.google.com>
>
> Create new binding file for the FocalTech FT8112 due to new touchscreen chip.
> Confirm its compatible, reg for the device via vendor, and set the interrupt
> and reset gpio to map for Skywalker platform.
> FocalTech FT8112 also uses vcc33/vccio power supply.
>
> Signed-off-by: Daniel Peng <Daniel_Peng@pegatron.corp-partner.google.com>
> > > From: Daniel Peng <Daniel_Peng@pegatron.corp-partner.google.com>
> > >
> > > The FocalTech FT8112 touch screen chip same as Ilitek ili2901 controller
> >
> > So keep the device in that binding under enum. No need to create
> > document for every device, even if they were different but here it is
> > pretty obvious - same chip.
> >
> > Best regards,
> > Krzysztof
>
> Re-describe the commit message to make more clear why to create new document
> for FocalTech FT8112 device.
> Sorry for the confusion.
No clue what's this, but try yourself - apply the patch and check the
results if it looks correct.
There are extensive guides how to send patches to Linux kernel,
including comprehensive guide on Linaro blog.
Best regards,
Krzysztof
prev parent reply other threads:[~2025-11-17 6:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-17 3:02 [PATCH v5 1/2] dt-bindings: input: i2c-hid: Introduce FocalTech FT8112 daniel_peng
2025-11-17 3:02 ` [PATCH v5 2/2] HID: i2c-hid: Add " daniel_peng
2025-11-17 6:30 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251117-beautiful-pink-macaque-9fd441@kuoka \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=daniel_peng@pegatron.corp-partner.google.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox