From: Josua Mayer <josua@solid-run.com>
To: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Jessica Zhang <jessica.zhang@oss.qualcomm.com>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
Thierry Reding <thierry.reding@gmail.com>
Cc: Jon Nettleton <jon@solid-run.com>,
Mikhail Anikin <mikhail.anikin@solid-run.com>,
Yazan Shhady <yazan.shhady@solid-run.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, linux-input@vger.kernel.org,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
Josua Mayer <josua@solid-run.com>
Subject: [PATCH v3 05/11] drm/panel: ronbo-rb070d30: fix warning with gpio controllers that sleep
Date: Mon, 17 Nov 2025 13:28:47 +0100 [thread overview]
Message-ID: <20251117-imx8mp-hb-iiot-v3-5-bf1a4cf5fa8e@solid-run.com> (raw)
In-Reply-To: <20251117-imx8mp-hb-iiot-v3-0-bf1a4cf5fa8e@solid-run.com>
The ronbo-rb070d30 controles the various gpios for reset, standby,
vertical and horizontal flip using the non-sleeping gpiod_set_value()
function.
Switch to using gpiod_set_value_cansleep() when controlling reset_gpio to
support GPIO providers that may sleep, such as I2C GPIO expanders.
This fixes noisy complaints in kernel log for gpio providers that do
sleep.
Signed-off-by: Josua Mayer <josua@solid-run.com>
---
drivers/gpu/drm/panel/panel-ronbo-rb070d30.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-ronbo-rb070d30.c b/drivers/gpu/drm/panel/panel-ronbo-rb070d30.c
index ad35d0fb0a167..c3fbc459c7e0d 100644
--- a/drivers/gpu/drm/panel/panel-ronbo-rb070d30.c
+++ b/drivers/gpu/drm/panel/panel-ronbo-rb070d30.c
@@ -54,9 +54,9 @@ static int rb070d30_panel_prepare(struct drm_panel *panel)
}
msleep(20);
- gpiod_set_value(ctx->gpios.power, 1);
+ gpiod_set_value_cansleep(ctx->gpios.power, 1);
msleep(20);
- gpiod_set_value(ctx->gpios.reset, 1);
+ gpiod_set_value_cansleep(ctx->gpios.reset, 1);
msleep(20);
return 0;
}
@@ -65,8 +65,8 @@ static int rb070d30_panel_unprepare(struct drm_panel *panel)
{
struct rb070d30_panel *ctx = panel_to_rb070d30_panel(panel);
- gpiod_set_value(ctx->gpios.reset, 0);
- gpiod_set_value(ctx->gpios.power, 0);
+ gpiod_set_value_cansleep(ctx->gpios.reset, 0);
+ gpiod_set_value_cansleep(ctx->gpios.power, 0);
regulator_disable(ctx->supply);
return 0;
--
2.51.0
next prev parent reply other threads:[~2025-11-17 12:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-17 12:28 [PATCH v3 00/11] arm64: dts: add description for solidrun imx8mp hummingboard-iiot Josua Mayer
2025-11-17 12:28 ` [PATCH v3 01/11] dt-bindings: arm: fsl: Add various solidrun i.mx8m boards Josua Mayer
2025-11-17 12:28 ` [PATCH v3 02/11] dt-bindings: display: panel: ronbo,rb070d30: panel-common ref Josua Mayer
2025-11-17 19:24 ` Conor Dooley
2025-11-17 12:28 ` [PATCH v3 03/11] dt-bindings: panel: lvds: add Winstar WF70A8SYJHLNGA Josua Mayer
2025-11-17 12:28 ` [PATCH v3 04/11] Input: ilitek_ts_i2c: fix warning with gpio controllers that sleep Josua Mayer
2025-11-18 19:22 ` Dmitry Torokhov
2025-11-17 12:28 ` Josua Mayer [this message]
2025-11-18 8:44 ` [PATCH v3 05/11] drm/panel: ronbo-rb070d30: " Neil Armstrong
2025-11-17 12:28 ` [PATCH v3 06/11] arm64: dts: imx8mp-hummingboard-pulse/cubox-m: fix vmmc gpio polarity Josua Mayer
2025-11-17 12:28 ` [PATCH v3 07/11] arm64: dts: imx8mp-hummingboard-pulse: fix mini-hdmi dsi port reference Josua Mayer
2025-11-17 12:28 ` [PATCH v3 08/11] arm64: dts: imx8mp-sr-som: build dtbs with symbols for overlay support Josua Mayer
2025-11-17 12:28 ` [PATCH v3 09/11] arm64: dts: add description for solidrun imx8mp hummingboard-iiot Josua Mayer
2025-11-17 12:28 ` [PATCH v3 10/11] arm64: dts: add description for solidrun solidsense-n8 board Josua Mayer
2025-11-17 12:28 ` [PATCH v3 11/11] arm64: dts: add description for solidrun i.mx8mm som and evb Josua Mayer
2025-11-19 16:49 ` (subset) [PATCH v3 00/11] arm64: dts: add description for solidrun imx8mp hummingboard-iiot Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251117-imx8mp-hb-iiot-v3-5-bf1a4cf5fa8e@solid-run.com \
--to=josua@solid-run.com \
--cc=airlied@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=jessica.zhang@oss.qualcomm.com \
--cc=jon@solid-run.com \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mikhail.anikin@solid-run.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=simona@ffwll.ch \
--cc=thierry.reding@gmail.com \
--cc=tzimmermann@suse.de \
--cc=yazan.shhady@solid-run.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).