From: Benjamin Tissoires <bentiss@kernel.org>
To: Jiri Kosina <jikos@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
Benjamin Tissoires <bentiss@kernel.org>,
Colin Ian King <colin.i.king@gmail.com>,
Benjamin Tissoires <bentiss@kernel.org>
Subject: [PATCH 10/10] HID: bpf: fix typo in HID usage table
Date: Tue, 18 Nov 2025 18:16:31 +0100 [thread overview]
Message-ID: <20251118-wip-sync-udev-hid-bpf-v1-10-0f8105c54835@kernel.org> (raw)
In-Reply-To: <20251118-wip-sync-udev-hid-bpf-v1-0-0f8105c54835@kernel.org>
We could go to the USB consortium, but it's probably
easier that way.
And update HID usage table json generated file from
https://usb.org/sites/default/files/hut1_6.pdf updated: 01/30/2025
Reported-by: Colin Ian King <colin.i.king@gmail.com>
Link: https://gitlab.freedesktop.org/libevdev/udev-hid-bpf/-/merge_requests/191
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@gmail.com>
Signed-off-by: Benjamin Tissoires <bentiss@kernel.org>
---
drivers/hid/bpf/progs/hid_report_helpers.h | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/hid/bpf/progs/hid_report_helpers.h b/drivers/hid/bpf/progs/hid_report_helpers.h
index 9b2a48e4a311b39ca20e7d9819beef8fb70315a6..9944ff54d31d27d664be554afed2ce3710b48c75 100644
--- a/drivers/hid/bpf/progs/hid_report_helpers.h
+++ b/drivers/hid/bpf/progs/hid_report_helpers.h
@@ -143,8 +143,11 @@
* report with Report ID 0xac of the given size in bytes.
* The size is inclusive of the 1 byte Report ID prefix.
*
- * HID-BPF requires that at least one report has
- * the same size as the original report from the device.
+ * The kernel discards any HID reports that are larger
+ * than the largest report in a HID report descriptor.
+ * Thus at least one report must have (at least)
+ * the same size as the largest original report from
+ * the device.
* The easy way to ensure that is to add this
* macro as the last element of your CollectionApplication
* other reports can be of any size less than this.
@@ -295,6 +298,7 @@
#define Usage_GD_SystemSpeakerMute Usage_i8(0xa7)
#define Usage_GD_SystemHibernate Usage_i8(0xa8)
#define Usage_GD_SystemMicrophoneMute Usage_i8(0xa9)
+#define Usage_GD_SystemAccessibilityBinding Usage_i8(0xaa)
#define Usage_GD_SystemDisplayInvert Usage_i8(0xb0)
#define Usage_GD_SystemDisplayInternal Usage_i8(0xb1)
#define Usage_GD_SystemDisplayExternal Usage_i8(0xb2)
@@ -2669,7 +2673,7 @@
#define Usage_BS_iDeviceName Usage_i8(0x88)
#define Usage_BS_iDeviceChemistry Usage_i8(0x89)
#define Usage_BS_ManufacturerData Usage_i8(0x8a)
-#define Usage_BS_Rechargable Usage_i8(0x8b)
+#define Usage_BS_Rechargeable Usage_i8(0x8b)
#define Usage_BS_WarningCapacityLimit Usage_i8(0x8c)
#define Usage_BS_CapacityGranularity1 Usage_i8(0x8d)
#define Usage_BS_CapacityGranularity2 Usage_i8(0x8e)
--
2.51.1
next prev parent reply other threads:[~2025-11-18 17:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-18 17:16 [PATCH 00/10] HID: bpf: sync up with current udev-hid-bpf programs Benjamin Tissoires
2025-11-18 17:16 ` [PATCH 01/10] HID: bpf: Add support for the Inspiroy 2M Benjamin Tissoires
2025-11-18 17:16 ` [PATCH 02/10] HID: bpf: add support for Huion Kamvas 13 (Gen 3) (model GS1333) Benjamin Tissoires
2025-11-18 17:16 ` [PATCH 03/10] HID: bpf: support for Huion Kamvas 16 Gen 3 Benjamin Tissoires
2025-11-18 17:16 ` [PATCH 04/10] HID: bpf: Add fixup for Logitech SpaceNavigator variants Benjamin Tissoires
2025-11-18 17:16 ` [PATCH 05/10] HID: bpf: Add support for the Waltop Batteryless Tablet Benjamin Tissoires
2025-11-18 17:16 ` [PATCH 06/10] HID: bpf: Add support for the XP-Pen Deco 01 V3 Benjamin Tissoires
2025-11-18 17:16 ` [PATCH 07/10] HID: bpf: Add support for XP-Pen Deco02 Benjamin Tissoires
2025-11-18 17:16 ` [PATCH 08/10] HID: bpf: add heuristics to the Huion Inspiroy 2S eraser button Benjamin Tissoires
2025-11-18 17:16 ` [PATCH 09/10] HID: bpf: add the Huion Kamvas 27 Pro Benjamin Tissoires
2025-11-18 17:16 ` Benjamin Tissoires [this message]
2025-11-20 15:46 ` [PATCH 00/10] HID: bpf: sync up with current udev-hid-bpf programs Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251118-wip-sync-udev-hid-bpf-v1-10-0f8105c54835@kernel.org \
--to=bentiss@kernel.org \
--cc=colin.i.king@gmail.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).