From: Even Xu <even.xu@intel.com>
To: tim@linux4.de
Cc: bentiss@kernel.org, even.xu@intel.com, jikos@kernel.org,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
xinpeng.sun@intel.com
Subject: RE: [PATCH] hid: intel-thc-hid: Select SGL_ALLOC
Date: Mon, 22 Dec 2025 10:55:35 +0800 [thread overview]
Message-ID: <20251222025535.1879559-1-even.xu@intel.com> (raw)
In-Reply-To: <20251128075426.628500-1-tim@linux4.de>
From: "Xu, Even" <even.xu@intel.com>
> From: Tim Zimmermann <tim@linux4.de>
> Cc: tim@linux4.de, Even Xu <even.xu@intel.com>,
> Xinpeng Sun <xinpeng.sun@intel.com>,
> Jiri Kosina <jikos@kernel.org>,
> Benjamin Tissoires <bentiss@kernel.org>,
> linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
> Subject: [PATCH] hid: intel-thc-hid: Select SGL_ALLOC
> Date: Fri, 28 Nov 2025 08:54:22 +0100 [thread overview]
> Message-ID: <20251128075426.628500-1-tim@linux4.de> (raw)
>
> intel-thc-dma.c uses sgl_alloc() resulting in a build failure if CONFIG_SGL_ALLOC is not enabled
>
> Signed-off-by: Tim Zimmermann <tim@linux4.de>
> ---
> drivers/hid/intel-thc-hid/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hid/intel-thc-hid/Kconfig b/drivers/hid/intel-thc-hid/Kconfig
> index 0351d1137607..9d74e53b8c62 100644
> --- a/drivers/hid/intel-thc-hid/Kconfig
> +++ b/drivers/hid/intel-thc-hid/Kconfig
> @@ -7,6 +7,7 @@ menu "Intel THC HID Support"
> config INTEL_THC_HID
> tristate "Intel Touch Host Controller"
> depends on ACPI
> + select SGL_ALLOC
> help
> THC (Touch Host Controller) is the name of the IP block in PCH that
> interfaces with Touch Devices (ex: touchscreen, touchpad etc.). It
Thanks for the patch!
Reviewed-by: Even Xu <even.xu@intel.com>
> --
> 2.51.0
prev parent reply other threads:[~2025-12-22 2:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-28 7:54 [PATCH] hid: intel-thc-hid: Select SGL_ALLOC Tim Zimmermann
2025-12-22 2:55 ` Even Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251222025535.1879559-1-even.xu@intel.com \
--to=even.xu@intel.com \
--cc=bentiss@kernel.org \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tim@linux4.de \
--cc=xinpeng.sun@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).