From: Yajat Kumar <yajatapps3@gmail.com>
To: Hans de Goede <hansg@kernel.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-input@vger.kernel.org (open list:GOODIX TOUCHSCREEN),
linux-kernel@vger.kernel.org (open list)
Cc: Yajat Kumar <yajatapps3@gmail.com>
Subject: [PATCH] Input: goodix - fix inverted Y coordinate on SUPI S10
Date: Tue, 30 Dec 2025 17:16:39 -0500 [thread overview]
Message-ID: <20251230221639.582406-1-yajatapps3@gmail.com> (raw)
The touchscreen on the SUPI S10 reports inverted Y coordinates, causing
touch input to be mirrored vertically relative to the display.
Add a DMI-based quirk to invert the Y coordinate on this device so that
touch input matches the display orientation.
Tested on SUPI S10 tablet with Goodix touchscreen controller.
Signed-off-by: Yajat Kumar <yajatapps3@gmail.com>
---
drivers/input/touchscreen/goodix.c | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)
diff --git a/drivers/input/touchscreen/goodix.c b/drivers/input/touchscreen/goodix.c
index f8798d11ec03..d675a85a9312 100644
--- a/drivers/input/touchscreen/goodix.c
+++ b/drivers/input/touchscreen/goodix.c
@@ -160,6 +160,22 @@ static const struct dmi_system_id inverted_x_screen[] = {
{}
};
+/*
+ * Those tablets have their y coordinate inverted
+ */
+static const struct dmi_system_id inverted_y_screen[] = {
+#if defined(CONFIG_DMI) && defined(CONFIG_X86)
+ {
+ .ident = "SUPI S10",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "SUPI"),
+ DMI_MATCH(DMI_PRODUCT_NAME, "S10")
+ },
+ },
+#endif
+ {}
+};
+
/**
* goodix_i2c_read - read data from a register of the i2c slave device.
*
@@ -1212,6 +1228,12 @@ static int goodix_configure_dev(struct goodix_ts_data *ts)
"Applying 'inverted x screen' quirk\n");
}
+ if (dmi_check_system(inverted_y_screen)) {
+ ts->prop.invert_y = true;
+ dev_dbg(&ts->client->dev,
+ "Applying 'inverted y screen' quirk\n");
+ }
+
error = input_mt_init_slots(ts->input_dev, ts->max_touch_num,
INPUT_MT_DIRECT | INPUT_MT_DROP_UNUSED);
if (error) {
--
2.51.0
next reply other threads:[~2025-12-30 22:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-30 22:16 Yajat Kumar [this message]
2026-01-11 21:30 ` [PATCH] Input: goodix - fix inverted Y coordinate on SUPI S10 Hans de Goede
2026-01-18 23:41 ` YAJAT APPS
2026-01-29 18:40 ` Hans de Goede
2026-02-17 5:07 ` [PATCH] touchscreen-dmi quirk for " Yajat Kumar
2026-02-17 13:24 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251230221639.582406-1-yajatapps3@gmail.com \
--to=yajatapps3@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=hansg@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox