From: Antheas Kapenekakis <lkml@antheas.dev>
To: platform-driver-x86@vger.kernel.org, linux-input@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, "Jiri Kosina" <jikos@kernel.org>,
"Benjamin Tissoires" <bentiss@kernel.org>,
"Corentin Chary" <corentin.chary@gmail.com>,
"Luke D . Jones" <luke@ljones.dev>,
"Hans de Goede" <hansg@kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Denis Benato" <denis.benato@linux.dev>,
"Antheas Kapenekakis" <lkml@antheas.dev>,
"Denis Benato" <benato.denis96@gmail.com>
Subject: [PATCH v11 11/11] HID: asus: add support for the asus-wmi brightness handler
Date: Fri, 16 Jan 2026 14:31:50 +0100 [thread overview]
Message-ID: <20260116133150.5606-12-lkml@antheas.dev> (raw)
In-Reply-To: <20260116133150.5606-1-lkml@antheas.dev>
If the asus-wmi brightness handler is available, send the
keyboard brightness events to it instead of passing them
to userspace. If it is not, fall back to sending them to it.
Reviewed-by: Luke D. Jones <luke@ljones.dev>
Tested-by: Luke D. Jones <luke@ljones.dev>
Reviewed-by: Denis Benato <benato.denis96@gmail.com>
Acked-by: Benjamin Tissoires <bentiss@kernel.org>
Signed-off-by: Antheas Kapenekakis <lkml@antheas.dev>
---
drivers/hid/hid-asus.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c
index 19fc43f27ff3..50410b1c81ab 100644
--- a/drivers/hid/hid-asus.c
+++ b/drivers/hid/hid-asus.c
@@ -324,6 +324,17 @@ static int asus_event(struct hid_device *hdev, struct hid_field *field,
usage->hid & HID_USAGE);
}
+ if (usage->type == EV_KEY && value) {
+ switch (usage->code) {
+ case KEY_KBDILLUMUP:
+ return !asus_hid_event(ASUS_EV_BRTUP);
+ case KEY_KBDILLUMDOWN:
+ return !asus_hid_event(ASUS_EV_BRTDOWN);
+ case KEY_KBDILLUMTOGGLE:
+ return !asus_hid_event(ASUS_EV_BRTTOGGLE);
+ }
+ }
+
return 0;
}
--
2.52.0
prev parent reply other threads:[~2026-01-16 13:32 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-16 13:31 [PATCH v11 00/11] HID: asus: Fix ASUS ROG Laptop's Keyboard backlight handling Antheas Kapenekakis
2026-01-16 13:31 ` [PATCH v11 01/11] HID: asus: simplify RGB init sequence Antheas Kapenekakis
2026-01-16 13:31 ` [PATCH v11 02/11] HID: asus: initialize additional endpoints only for legacy devices Antheas Kapenekakis
2026-01-16 20:44 ` Denis Benato
2026-01-16 23:10 ` Antheas Kapenekakis
2026-01-17 13:51 ` Denis Benato
2026-01-17 15:07 ` Antheas Kapenekakis
2026-01-17 15:13 ` Denis Benato
2026-01-17 16:10 ` Antheas Kapenekakis
2026-01-17 16:12 ` Denis Benato
2026-01-17 16:16 ` Antheas Kapenekakis
2026-01-17 17:05 ` Denis Benato
2026-01-17 19:17 ` Antheas Kapenekakis
2026-01-20 13:56 ` Ilpo Järvinen
2026-01-20 17:41 ` Antheas Kapenekakis
2026-01-20 21:03 ` Denis Benato
2026-01-20 21:15 ` Antheas Kapenekakis
2026-01-16 13:31 ` [PATCH v11 03/11] HID: asus: use same report_id in response Antheas Kapenekakis
2026-01-16 13:31 ` [PATCH v11 04/11] HID: asus: fortify keyboard handshake Antheas Kapenekakis
2026-01-16 13:31 ` [PATCH v11 05/11] HID: asus: move vendor initialization to probe Antheas Kapenekakis
2026-01-16 21:08 ` Denis Benato
2026-01-16 13:31 ` [PATCH v11 06/11] HID: asus: early return for ROG devices Antheas Kapenekakis
2026-01-16 21:13 ` Denis Benato
2026-01-16 13:31 ` [PATCH v11 07/11] platform/x86: asus-wmi: Add support for multiple kbd led handlers Antheas Kapenekakis
2026-01-17 13:16 ` Denis Benato
2026-01-17 13:49 ` Antheas Kapenekakis
2026-01-17 13:52 ` Antheas Kapenekakis
2026-01-17 13:56 ` Denis Benato
2026-01-17 14:11 ` Antheas Kapenekakis
2026-01-17 14:48 ` Denis Benato
2026-01-19 9:53 ` Ilpo Järvinen
2026-01-19 11:34 ` Antheas Kapenekakis
2026-01-16 13:31 ` [PATCH v11 08/11] HID: asus: listen to the asus-wmi brightness device instead of creating one Antheas Kapenekakis
2026-01-16 13:31 ` [PATCH v11 09/11] platform/x86: asus-wmi: remove unused keyboard backlight quirk Antheas Kapenekakis
2026-01-16 13:31 ` [PATCH v11 10/11] platform/x86: asus-wmi: add keyboard brightness event handler Antheas Kapenekakis
2026-01-17 13:45 ` Denis Benato
2026-01-16 13:31 ` Antheas Kapenekakis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260116133150.5606-12-lkml@antheas.dev \
--to=lkml@antheas.dev \
--cc=benato.denis96@gmail.com \
--cc=bentiss@kernel.org \
--cc=corentin.chary@gmail.com \
--cc=denis.benato@linux.dev \
--cc=hansg@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luke@ljones.dev \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox