public inbox for linux-input@vger.kernel.org
 help / color / mirror / Atom feed
From: Antheas Kapenekakis <lkml@antheas.dev>
To: platform-driver-x86@vger.kernel.org, linux-input@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, "Jiri Kosina" <jikos@kernel.org>,
	"Benjamin Tissoires" <bentiss@kernel.org>,
	"Corentin Chary" <corentin.chary@gmail.com>,
	"Luke D . Jones" <luke@ljones.dev>,
	"Hans de Goede" <hansg@kernel.org>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	"Denis Benato" <denis.benato@linux.dev>,
	"Antheas Kapenekakis" <lkml@antheas.dev>,
	"Denis Benato" <benato.denis96@gmail.com>
Subject: [PATCH v12 03/11] HID: asus: use same report_id in response
Date: Thu, 22 Jan 2026 08:50:36 +0100	[thread overview]
Message-ID: <20260122075044.5070-4-lkml@antheas.dev> (raw)
In-Reply-To: <20260122075044.5070-1-lkml@antheas.dev>

Currently, asus_kbd_get_functions prods the device using feature
report report_id, but then is hardcoded to check the response through
FEATURE_KBD_REPORT_ID. This only works if report_id is that value
(currently true). So, use report_id in the response as well to
maintain functionality if that value changes in the future.

Reviewed-by: Denis Benato <benato.denis96@gmail.com>
Acked-by: Benjamin Tissoires <bentiss@kernel.org>
Signed-off-by: Antheas Kapenekakis <lkml@antheas.dev>
---
 drivers/hid/hid-asus.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c
index 92904b5a700c..2ff2170dc30a 100644
--- a/drivers/hid/hid-asus.c
+++ b/drivers/hid/hid-asus.c
@@ -424,7 +424,7 @@ static int asus_kbd_get_functions(struct hid_device *hdev,
 	if (!readbuf)
 		return -ENOMEM;
 
-	ret = hid_hw_raw_request(hdev, FEATURE_KBD_REPORT_ID, readbuf,
+	ret = hid_hw_raw_request(hdev, report_id, readbuf,
 				 FEATURE_KBD_REPORT_SIZE, HID_FEATURE_REPORT,
 				 HID_REQ_GET_REPORT);
 	if (ret < 0) {
-- 
2.52.0



  parent reply	other threads:[~2026-01-22  7:51 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-22  7:50 [PATCH v12 00/11] HID: asus: Fix ASUS ROG Laptop's Keyboard backlight handling Antheas Kapenekakis
2026-01-22  7:50 ` [PATCH v12 01/11] HID: asus: simplify RGB init sequence Antheas Kapenekakis
2026-01-22  7:50 ` [PATCH v12 02/11] HID: asus: initialize additional endpoints only for certain devices Antheas Kapenekakis
2026-01-23  0:18   ` Denis Benato
2026-01-22  7:50 ` Antheas Kapenekakis [this message]
2026-01-22  7:50 ` [PATCH v12 04/11] HID: asus: fortify keyboard handshake Antheas Kapenekakis
2026-01-22  7:50 ` [PATCH v12 05/11] HID: asus: move vendor initialization to probe Antheas Kapenekakis
2026-01-22  7:50 ` [PATCH v12 06/11] HID: asus: early return for ROG devices Antheas Kapenekakis
2026-01-22  7:50 ` [PATCH v12 07/11] platform/x86: asus-wmi: Add support for multiple kbd led handlers Antheas Kapenekakis
2026-01-23  0:20   ` Denis Benato
2026-01-22  7:50 ` [PATCH v12 08/11] HID: asus: listen to the asus-wmi brightness device instead of creating one Antheas Kapenekakis
2026-01-22  7:50 ` [PATCH v12 09/11] platform/x86: asus-wmi: remove unused keyboard backlight quirk Antheas Kapenekakis
2026-01-22  7:50 ` [PATCH v12 10/11] platform/x86: asus-wmi: add keyboard brightness event handler Antheas Kapenekakis
2026-01-22  7:50 ` [PATCH v12 11/11] HID: asus: add support for the asus-wmi brightness handler Antheas Kapenekakis
2026-01-26 14:30 ` [PATCH v12 00/11] HID: asus: Fix ASUS ROG Laptop's Keyboard backlight handling Ilpo Järvinen
2026-02-03 19:06 ` Jiri Kosina
2026-02-03 19:36   ` Antheas Kapenekakis
2026-02-03 19:44     ` Jiri Kosina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260122075044.5070-4-lkml@antheas.dev \
    --to=lkml@antheas.dev \
    --cc=benato.denis96@gmail.com \
    --cc=bentiss@kernel.org \
    --cc=corentin.chary@gmail.com \
    --cc=denis.benato@linux.dev \
    --cc=hansg@kernel.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=jikos@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luke@ljones.dev \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox