* [hid:for-6.20/pm_ptr 7/12] drivers/hid/hid-picolcd_core.c:651:33: error: 'picolcd_suspend' undeclared here (not in a function); did you mean 'picolcd_reset'?
@ 2026-01-26 2:04 kernel test robot
2026-01-28 17:43 ` Bastien Nocera
0 siblings, 1 reply; 5+ messages in thread
From: kernel test robot @ 2026-01-26 2:04 UTC (permalink / raw)
To: Bastien Nocera; +Cc: oe-kbuild-all, linux-input, Jiri Kosina
tree: https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git for-6.20/pm_ptr
head: d68a5fd939f460a7db76d127005af51cb13c69fa
commit: 318f7b0f1bea13d3aa0506fe6f40399f11c4ae52 [7/12] HID: picolcd_core: Use pm_ptr instead of #ifdef CONFIG_PM
config: i386-randconfig-2006-20250804 (https://download.01.org/0day-ci/archive/20260126/202601260353.Dk5ekiee-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260126/202601260353.Dk5ekiee-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202601260353.Dk5ekiee-lkp@intel.com/
All errors (new ones prefixed by >>):
In file included from include/linux/kernel.h:36,
from include/linux/random.h:7,
from include/linux/nodemask.h:94,
from include/linux/numa.h:6,
from include/linux/cpumask.h:15,
from include/linux/smp.h:13,
from include/linux/lockdep.h:14,
from include/linux/spinlock.h:63,
from include/linux/mmzone.h:8,
from include/linux/gfp.h:7,
from include/linux/slab.h:16,
from include/linux/hid.h:19,
from drivers/hid/hid-picolcd_core.c:10:
>> drivers/hid/hid-picolcd_core.c:651:33: error: 'picolcd_suspend' undeclared here (not in a function); did you mean 'picolcd_reset'?
651 | .suspend = pm_ptr(picolcd_suspend),
| ^~~~~~~~~~~~~~~
include/linux/util_macros.h:136:44: note: in definition of macro 'PTR_IF'
136 | #define PTR_IF(cond, ptr) ((cond) ? (ptr) : NULL)
| ^~~
drivers/hid/hid-picolcd_core.c:651:26: note: in expansion of macro 'pm_ptr'
651 | .suspend = pm_ptr(picolcd_suspend),
| ^~~~~~
>> drivers/hid/hid-picolcd_core.c:652:33: error: 'picolcd_resume' undeclared here (not in a function); did you mean 'picolcd_remove'?
652 | .resume = pm_ptr(picolcd_resume),
| ^~~~~~~~~~~~~~
include/linux/util_macros.h:136:44: note: in definition of macro 'PTR_IF'
136 | #define PTR_IF(cond, ptr) ((cond) ? (ptr) : NULL)
| ^~~
drivers/hid/hid-picolcd_core.c:652:26: note: in expansion of macro 'pm_ptr'
652 | .resume = pm_ptr(picolcd_resume),
| ^~~~~~
>> drivers/hid/hid-picolcd_core.c:653:33: error: 'picolcd_reset_resume' undeclared here (not in a function); did you mean 'picolcd_reset'?
653 | .reset_resume = pm_ptr(picolcd_reset_resume),
| ^~~~~~~~~~~~~~~~~~~~
include/linux/util_macros.h:136:44: note: in definition of macro 'PTR_IF'
136 | #define PTR_IF(cond, ptr) ((cond) ? (ptr) : NULL)
| ^~~
drivers/hid/hid-picolcd_core.c:653:26: note: in expansion of macro 'pm_ptr'
653 | .reset_resume = pm_ptr(picolcd_reset_resume),
| ^~~~~~
vim +651 drivers/hid/hid-picolcd_core.c
644
645 static struct hid_driver picolcd_driver = {
646 .name = "hid-picolcd",
647 .id_table = picolcd_devices,
648 .probe = picolcd_probe,
649 .remove = picolcd_remove,
650 .raw_event = picolcd_raw_event,
> 651 .suspend = pm_ptr(picolcd_suspend),
> 652 .resume = pm_ptr(picolcd_resume),
> 653 .reset_resume = pm_ptr(picolcd_reset_resume),
654 };
655 module_hid_driver(picolcd_driver);
656
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [hid:for-6.20/pm_ptr 7/12] drivers/hid/hid-picolcd_core.c:651:33: error: 'picolcd_suspend' undeclared here (not in a function); did you mean 'picolcd_reset'?
2026-01-26 2:04 [hid:for-6.20/pm_ptr 7/12] drivers/hid/hid-picolcd_core.c:651:33: error: 'picolcd_suspend' undeclared here (not in a function); did you mean 'picolcd_reset'? kernel test robot
@ 2026-01-28 17:43 ` Bastien Nocera
2026-01-28 17:46 ` Jiri Kosina
0 siblings, 1 reply; 5+ messages in thread
From: Bastien Nocera @ 2026-01-28 17:43 UTC (permalink / raw)
To: kernel test robot; +Cc: oe-kbuild-all, linux-input, Jiri Kosina
The wrong version of the patch got scheduled in that branch.
The branch has v1 of the patch:
https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git/commit/?h=for-6.20/pm_ptr&id=318f7b0f1bea13d3aa0506fe6f40399f11c4ae52
This is what v2 looks like:
https://patchwork.kernel.org/project/linux-input/patch/20260113092546.265734-8-hadess@hadess.net/
which should fix the problem.
Note that my v2 patchset also dropped
"HID: surface: Use pm_ptr_sleep instead of #ifdef CONFIG_PM_SLEEP"
which is still in that branch.
Do you need anything else from me?
On Mon, 2026-01-26 at 03:04 +0100, kernel test robot wrote:
> tree:
> https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git for-
> 6.20/pm_ptr
> head: d68a5fd939f460a7db76d127005af51cb13c69fa
> commit: 318f7b0f1bea13d3aa0506fe6f40399f11c4ae52 [7/12] HID:
> picolcd_core: Use pm_ptr instead of #ifdef CONFIG_PM
> config: i386-randconfig-2006-20250804
> (https://download.01.org/0day-ci/archive/20260126/202601260353.Dk5eki
> ee-lkp@intel.com/config)
> compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
> reproduce (this is a W=1 build):
> (https://download.01.org/0day-ci/archive/20260126/202601260353.Dk5eki
> ee-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new
> version of
> the same patch/commit), kindly add following tags
> > Reported-by: kernel test robot <lkp@intel.com>
> > Closes:
> > https://lore.kernel.org/oe-kbuild-all/202601260353.Dk5ekiee-lkp@intel.com/
>
> All errors (new ones prefixed by >>):
>
> In file included from include/linux/kernel.h:36,
> from include/linux/random.h:7,
> from include/linux/nodemask.h:94,
> from include/linux/numa.h:6,
> from include/linux/cpumask.h:15,
> from include/linux/smp.h:13,
> from include/linux/lockdep.h:14,
> from include/linux/spinlock.h:63,
> from include/linux/mmzone.h:8,
> from include/linux/gfp.h:7,
> from include/linux/slab.h:16,
> from include/linux/hid.h:19,
> from drivers/hid/hid-picolcd_core.c:10:
> > > drivers/hid/hid-picolcd_core.c:651:33: error: 'picolcd_suspend'
> > > undeclared here (not in a function); did you mean
> > > 'picolcd_reset'?
> 651 | .suspend = pm_ptr(picolcd_suspend),
> | ^~~~~~~~~~~~~~~
> include/linux/util_macros.h:136:44: note: in definition of macro
> 'PTR_IF'
> 136 | #define PTR_IF(cond, ptr) ((cond) ? (ptr) : NULL)
> | ^~~
> drivers/hid/hid-picolcd_core.c:651:26: note: in expansion of macro
> 'pm_ptr'
> 651 | .suspend = pm_ptr(picolcd_suspend),
> | ^~~~~~
> > > drivers/hid/hid-picolcd_core.c:652:33: error: 'picolcd_resume'
> > > undeclared here (not in a function); did you mean
> > > 'picolcd_remove'?
> 652 | .resume = pm_ptr(picolcd_resume),
> | ^~~~~~~~~~~~~~
> include/linux/util_macros.h:136:44: note: in definition of macro
> 'PTR_IF'
> 136 | #define PTR_IF(cond, ptr) ((cond) ? (ptr) : NULL)
> | ^~~
> drivers/hid/hid-picolcd_core.c:652:26: note: in expansion of macro
> 'pm_ptr'
> 652 | .resume = pm_ptr(picolcd_resume),
> | ^~~~~~
> > > drivers/hid/hid-picolcd_core.c:653:33: error:
> > > 'picolcd_reset_resume' undeclared here (not in a function); did
> > > you mean 'picolcd_reset'?
> 653 | .reset_resume = pm_ptr(picolcd_reset_resume),
> | ^~~~~~~~~~~~~~~~~~~~
> include/linux/util_macros.h:136:44: note: in definition of macro
> 'PTR_IF'
> 136 | #define PTR_IF(cond, ptr) ((cond) ? (ptr) : NULL)
> | ^~~
> drivers/hid/hid-picolcd_core.c:653:26: note: in expansion of macro
> 'pm_ptr'
> 653 | .reset_resume = pm_ptr(picolcd_reset_resume),
> | ^~~~~~
>
>
> vim +651 drivers/hid/hid-picolcd_core.c
>
> 644
> 645 static struct hid_driver picolcd_driver = {
> 646 .name = "hid-picolcd",
> 647 .id_table = picolcd_devices,
> 648 .probe = picolcd_probe,
> 649 .remove = picolcd_remove,
> 650 .raw_event = picolcd_raw_event,
> > 651 .suspend = pm_ptr(picolcd_suspend),
> > 652 .resume = pm_ptr(picolcd_resume),
> > 653 .reset_resume = pm_ptr(picolcd_reset_resume),
> 654 };
> 655 module_hid_driver(picolcd_driver);
> 656
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [hid:for-6.20/pm_ptr 7/12] drivers/hid/hid-picolcd_core.c:651:33: error: 'picolcd_suspend' undeclared here (not in a function); did you mean 'picolcd_reset'?
2026-01-28 17:43 ` Bastien Nocera
@ 2026-01-28 17:46 ` Jiri Kosina
2026-01-28 17:48 ` Bastien Nocera
2026-01-28 18:17 ` Jiri Kosina
0 siblings, 2 replies; 5+ messages in thread
From: Jiri Kosina @ 2026-01-28 17:46 UTC (permalink / raw)
To: Bastien Nocera; +Cc: kernel test robot, oe-kbuild-all, linux-input
On Wed, 28 Jan 2026, Bastien Nocera wrote:
> The wrong version of the patch got scheduled in that branch.
>
> The branch has v1 of the patch:
> https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git/commit/?h=for-6.20/pm_ptr&id=318f7b0f1bea13d3aa0506fe6f40399f11c4ae52
>
> This is what v2 looks like:
> https://patchwork.kernel.org/project/linux-input/patch/20260113092546.265734-8-hadess@hadess.net/
> which should fix the problem.
>
> Note that my v2 patchset also dropped
> "HID: surface: Use pm_ptr_sleep instead of #ifdef CONFIG_PM_SLEEP"
> which is still in that branch.
Hm, something went wrong with my b4 workflow then, sorry for the noise.
I'll take a look and ensure that the correct version gets queued.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [hid:for-6.20/pm_ptr 7/12] drivers/hid/hid-picolcd_core.c:651:33: error: 'picolcd_suspend' undeclared here (not in a function); did you mean 'picolcd_reset'?
2026-01-28 17:46 ` Jiri Kosina
@ 2026-01-28 17:48 ` Bastien Nocera
2026-01-28 18:17 ` Jiri Kosina
1 sibling, 0 replies; 5+ messages in thread
From: Bastien Nocera @ 2026-01-28 17:48 UTC (permalink / raw)
To: Jiri Kosina; +Cc: kernel test robot, oe-kbuild-all, linux-input
On Wed, 2026-01-28 at 18:46 +0100, Jiri Kosina wrote:
> On Wed, 28 Jan 2026, Bastien Nocera wrote:
>
> > The wrong version of the patch got scheduled in that branch.
> >
> > The branch has v1 of the patch:
> > https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git/commit/?h=for-6.20/pm_ptr&id=318f7b0f1bea13d3aa0506fe6f40399f11c4ae52
> >
> > This is what v2 looks like:
> > https://patchwork.kernel.org/project/linux-input/patch/20260113092546.265734-8-hadess@hadess.net/
> > which should fix the problem.
> >
> > Note that my v2 patchset also dropped
> > "HID: surface: Use pm_ptr_sleep instead of #ifdef CONFIG_PM_SLEEP"
> > which is still in that branch.
>
> Hm, something went wrong with my b4 workflow then, sorry for the
> noise.
>
> I'll take a look and ensure that the correct version gets queued.
No problems.
I was a little bit worried as I spent quite some time making sure to
test for those problems in patchsets that I sent for hid and for the
Bluetooth subsystem.
I'm glad it's something as simple as the wrong patch being used rather
than my testing being lacking.
Cheers
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [hid:for-6.20/pm_ptr 7/12] drivers/hid/hid-picolcd_core.c:651:33: error: 'picolcd_suspend' undeclared here (not in a function); did you mean 'picolcd_reset'?
2026-01-28 17:46 ` Jiri Kosina
2026-01-28 17:48 ` Bastien Nocera
@ 2026-01-28 18:17 ` Jiri Kosina
1 sibling, 0 replies; 5+ messages in thread
From: Jiri Kosina @ 2026-01-28 18:17 UTC (permalink / raw)
To: Bastien Nocera; +Cc: kernel test robot, oe-kbuild-all, linux-input
On Wed, 28 Jan 2026, Jiri Kosina wrote:
> > The branch has v1 of the patch:
> > https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git/commit/?h=for-6.20/pm_ptr&id=318f7b0f1bea13d3aa0506fe6f40399f11c4ae52
> >
> > This is what v2 looks like:
> > https://patchwork.kernel.org/project/linux-input/patch/20260113092546.265734-8-hadess@hadess.net/
> > which should fix the problem.
> >
> > Note that my v2 patchset also dropped
> > "HID: surface: Use pm_ptr_sleep instead of #ifdef CONFIG_PM_SLEEP"
> > which is still in that branch.
>
> Hm, something went wrong with my b4 workflow then, sorry for the noise.
>
> I'll take a look and ensure that the correct version gets queued.
Now in hid.git#for-6.20/pm_ptr-v3. Sorry for the noise again,
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-01-28 18:17 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-26 2:04 [hid:for-6.20/pm_ptr 7/12] drivers/hid/hid-picolcd_core.c:651:33: error: 'picolcd_suspend' undeclared here (not in a function); did you mean 'picolcd_reset'? kernel test robot
2026-01-28 17:43 ` Bastien Nocera
2026-01-28 17:46 ` Jiri Kosina
2026-01-28 17:48 ` Bastien Nocera
2026-01-28 18:17 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox