From: Vishnu Sankar <vishnuocv@gmail.com>
To: mpearson-lenovo@squebb.ca, dmitry.torokhov@gmail.com,
hmh@hmh.eng.br, hansg@kernel.org, corbet@lwn.net,
derekjohn.clark@gmail.com, ilpo.jarvinen@linux.intel.com
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
ibm-acpi-devel@lists.sourceforge.net, linux-doc@vger.kernel.org,
platform-driver-x86@vger.kernel.org, vsankar@lenovo.com,
Vishnu Sankar <vishnuocv@gmail.com>
Subject: [PATCH v6 0/3] TrackPoint doubletap enablement and user control
Date: Tue, 27 Jan 2026 19:39:04 +0900 [thread overview]
Message-ID: <20260127103907.20269-1-vishnuocv@gmail.com> (raw)
This patch series adds support for TrackPoint doubletap with a clear and
simple separation of responsibilities between drivers:
1. Firmware enablement (trackpoint.c):
Automatically enables doubletap on capable hardware during device
detection.
2. User control (thinkpad_acpi.c):
Provides a sysfs interface to enable or disable delivery of doubletap
events to userspace.
The approach follows the KISS principle:
- The TrackPoint driver enables hardware functionality by default.
- The thinkpad_acpi driver controls whether ACPI doubletap events are
delivered, using existing hotkey filtering infrastructure.
- No cross-driver APIs or dual filtering paths are introduced.
Changes in v6:
- Documentation: fix formatting of the doubletap_enable sysfs attribute
description (separate "Values" list)
Changes in v5:
- Rename sysfs attribute from doubletap_filter to doubletap_enable to
reflect actual behavior.
- Fix inverted logic so events are delivered only when doubletap is
enabled.
- Suppress ACPI hotkey delivery instead of injecting or filtering input
events.
- Register the sysfs attribute via hotkey_attributes[] instead of
device_create_file().
- Drop unnecessary helper wrappers and debug logging.
- Update Documentation to reflect the new naming and semantics.
Changes in v4:
- Complete redesign based on reviewer feedback.
- trackpoint.c: Simplified to only enable doubletap by default.
- trackpoint.c: Removed all sysfs attributes and global variables.
- trackpoint.c: Uses firmware ID detection with deny list.
- thinkpad_acpi.c: Added sysfs interface for kernel-level event control.
- thinkpad_acpi.c: No cross-driver dependencies.
- Documentation: Updated to reflect simplified sysfs approach.
Changes in v3:
- No changes.
Changes in v2:
- Improved commit messages.
- Removed unnecessary comments and debug messages.
- Switched to strstarts() usage.
- Simplified firmware capability detection logic.
This version addresses the remaining review feedback by correcting the
naming and logic inversion, aligning sysfs semantics with behavior, and
fully integrating with existing thinkpad_acpi hotkey handling.
Vishnu Sankar (3):
input: trackpoint - Enable doubletap by default on capable devices
platform/x86: thinkpad_acpi: Add sysfs control for TrackPoint
double-tap
Documentation: thinkpad-acpi - Document doubletap_enable attribute
.../admin-guide/laptops/thinkpad-acpi.rst | 21 +++++++++
drivers/input/mouse/trackpoint.c | 47 +++++++++++++++++++
drivers/input/mouse/trackpoint.h | 5 ++
drivers/platform/x86/lenovo/thinkpad_acpi.c | 42 ++++++++++++++---
4 files changed, 108 insertions(+), 7 deletions(-)
--
2.51.0
next reply other threads:[~2026-01-27 10:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-27 10:39 Vishnu Sankar [this message]
2026-01-27 10:39 ` [PATCH v6 1/3] input: trackpoint - Enable doubletap by default on capable devices Vishnu Sankar
2026-02-01 8:09 ` Dmitry Torokhov
2026-02-02 3:56 ` Vishnu Sankar
2026-01-27 10:39 ` [PATCH v6 2/3] platform/x86: thinkpad_acpi: Add sysfs control for TrackPoint double-tap Vishnu Sankar
2026-01-27 10:39 ` [PATCH v6 3/3] Documentation: thinkpad-acpi - Document doubletap_enable attribute Vishnu Sankar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260127103907.20269-1-vishnuocv@gmail.com \
--to=vishnuocv@gmail.com \
--cc=corbet@lwn.net \
--cc=derekjohn.clark@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=hansg@kernel.org \
--cc=hmh@hmh.eng.br \
--cc=ibm-acpi-devel@lists.sourceforge.net \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpearson-lenovo@squebb.ca \
--cc=platform-driver-x86@vger.kernel.org \
--cc=vsankar@lenovo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox