From: Bonzupii <bluefox9516@gmail.com>
To: dmitry.torokhov@gmail.com
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Micah Ostrow <bluefox9516@gmail.com>
Subject: [PATCH] Input: apbps2 - fix comment style and typos
Date: Tue, 27 Jan 2026 12:17:35 -0600 [thread overview]
Message-ID: <20260127181735.57132-1-bluefox9516@gmail.com> (raw)
From: Micah Ostrow <bluefox9516@gmail.com>
Capitalize comment starts to match kernel coding style.
Fix spelling: "reciever" -> "receiver"
Fix grammar: "it's" (contraction of "it is") -> "its" (possessive)
Remove uncertainty from "Clear error bits?" comment.
Compile tested only.
Signed-off-by: Micah Ostrow <bluefox9516@gmail.com>
---
drivers/input/serio/apbps2.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/input/serio/apbps2.c b/drivers/input/serio/apbps2.c
index b815337be2f4..a5fbb27088be 100644
--- a/drivers/input/serio/apbps2.c
+++ b/drivers/input/serio/apbps2.c
@@ -67,7 +67,7 @@ static irqreturn_t apbps2_isr(int irq, void *dev_id)
rxflags = (status & APBPS2_STATUS_PE) ? SERIO_PARITY : 0;
rxflags |= (status & APBPS2_STATUS_FE) ? SERIO_FRAME : 0;
- /* clear error bits? */
+ /* Clear error bits */
if (rxflags)
iowrite32be(0, &priv->regs->status);
@@ -82,9 +82,9 @@ static irqreturn_t apbps2_isr(int irq, void *dev_id)
static int apbps2_write(struct serio *io, unsigned char val)
{
struct apbps2_priv *priv = io->port_data;
- unsigned int tleft = 10000; /* timeout in 100ms */
+ unsigned int tleft = 10000; /* Timeout in 100ms */
- /* delay until PS/2 controller has room for more chars */
+ /* Delay until PS/2 controller has room for more chars */
while ((ioread32be(&priv->regs->status) & APBPS2_STATUS_TF) && tleft--)
udelay(10);
@@ -104,7 +104,7 @@ static int apbps2_open(struct serio *io)
struct apbps2_priv *priv = io->port_data;
int limit;
- /* clear error flags */
+ /* Clear error flags */
iowrite32be(0, &priv->regs->status);
/* Clear old data if available (unlikely) */
@@ -112,7 +112,7 @@ static int apbps2_open(struct serio *io)
while ((ioread32be(&priv->regs->status) & APBPS2_STATUS_DR) && --limit)
ioread32be(&priv->regs->data);
- /* Enable reciever and it's interrupt */
+ /* Enable receiver and its interrupt */
iowrite32be(APBPS2_CTRL_RE | APBPS2_CTRL_RI, &priv->regs->ctrl);
return 0;
@@ -122,7 +122,7 @@ static void apbps2_close(struct serio *io)
{
struct apbps2_priv *priv = io->port_data;
- /* stop interrupts at PS/2 HW level */
+ /* Stop interrupts at PS/2 HW level */
iowrite32be(0, &priv->regs->ctrl);
}
@@ -139,7 +139,7 @@ static int apbps2_of_probe(struct platform_device *ofdev)
return -ENOMEM;
}
- /* Find Device Address */
+ /* Find device address */
priv->regs = devm_platform_get_and_ioremap_resource(ofdev, 0, NULL);
if (IS_ERR(priv->regs))
return PTR_ERR(priv->regs);
--
2.52.0
reply other threads:[~2026-01-27 18:18 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260127181735.57132-1-bluefox9516@gmail.com \
--to=bluefox9516@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox