From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 98FD4748F; Tue, 3 Feb 2026 15:01:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770130897; cv=none; b=KR6V2j1XhpnAdWFTtfZd3oPbd3wmTAqQ0dYmv45nfM4PoGdSHMDuLhWuViBeA6iMybrlufH6iE7F9adwli5pniHPhUk31K+K0ziRDrMZ83jpV4vfgl7Zjogz78OjXtFpkde3bIkms+CDvP5WyupEHoB+wuDicyiBs7bg4I65wy4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770130897; c=relaxed/simple; bh=h+vW6w1gwRQ5jHQUB+Rc8ayw0OzI1szLyss3LSeszPA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JFgoOEdTy9NepfXl7EiN6q4eM9OzYgIZMPg62ZwF6r0XqAj5H18vB2frsWHKZFuC4+pNKatAIaY+EKWvZ5IvlLG+eZ71fbTTsE/TpsgBlWCOOfqyNPsvJKcKp4kDUjN+at6Up1brGa59RcAtel8OD9h1mMTpTaMB3kUWxFo8N8Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=KXz8bHsa; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="KXz8bHsa" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 03FFDC116D0; Tue, 3 Feb 2026 15:01:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1770130897; bh=h+vW6w1gwRQ5jHQUB+Rc8ayw0OzI1szLyss3LSeszPA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KXz8bHsa2DI2tJ64eOL9R8FUkkoXBfp06fMh5bbx00RuGCo/mrQCNj0RUTunwNY/o 8h+FL+WHNsxoKaPp7A4vq1W0pvB3YODMK7L8o0JjTg1Y8XY4ixvkyhY/8ELkV1L0AM kfF/wmdLnjz5PRGtZD4OxBtrv0wBPOpMBOr8kTadS8OvRy+Yv5cy/iBKhw3rd1wBHF 56sTPs5NuI5mbMKiJsc3pP0cRWkmf+c5wQ8mhaAbHurAHlHd6pDs6h0SHtFNy5mY26 Ruvr80krV4/+P5DquCCJprGFNiGTpQ7SoccRdNqDCEqnPxd1G68qU1fs6viVAYdDDN xbA6lU64XQrRg== Date: Tue, 3 Feb 2026 09:01:36 -0600 From: Rob Herring To: Svyatoslav Ryhel Cc: David Lechner , Jonathan Cameron , Nuno =?iso-8859-1?Q?S=E1?= , Andy Shevchenko , Krzysztof Kozlowski , Conor Dooley , Dmitry Torokhov , Lee Jones , Pavel Machek , Liam Girdwood , Mark Brown , Alexandre Belloni , Dixit Parmar , Tony Lindgren , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-leds@vger.kernel.org, linux-rtc@vger.kernel.org Subject: Re: [PATCH v1 07/10] dt-bindings: input: cpcap-pwrbutton: convert to schema Message-ID: <20260203150136.GA2294714-robh@kernel.org> References: <20260125134302.45958-1-clamor95@gmail.com> <20260125134302.45958-8-clamor95@gmail.com> <8bd89524-dfc3-43b0-b0f2-cdb1cd51e1ac@baylibre.com> Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Sun, Feb 01, 2026 at 09:07:07AM +0200, Svyatoslav Ryhel wrote: > сб, 31 січ. 2026 р. о 22:02 David Lechner пише: > > > > On 1/25/26 7:42 AM, Svyatoslav Ryhel wrote: > > > Convert power button devicetree bindings for the Motorola CPCAP MFD from > > > TXT to YAML format. This patch does not change any functionality; the > > > bindings remain the same. > > > > > > Signed-off-by: Svyatoslav Ryhel > > > --- > > > .../bindings/input/cpcap-pwrbutton.txt | 20 ------------ > > > .../input/motorola,cpcap-pwrbutton.yaml | 32 +++++++++++++++++++ > > > 2 files changed, 32 insertions(+), 20 deletions(-) > > > delete mode 100644 Documentation/devicetree/bindings/input/cpcap-pwrbutton.txt > > > create mode 100644 Documentation/devicetree/bindings/input/motorola,cpcap-pwrbutton.yaml > > > > > > diff --git a/Documentation/devicetree/bindings/input/cpcap-pwrbutton.txt b/Documentation/devicetree/bindings/input/cpcap-pwrbutton.txt > > > deleted file mode 100644 > > > index 0dd0076daf71..000000000000 > > > --- a/Documentation/devicetree/bindings/input/cpcap-pwrbutton.txt > > > +++ /dev/null > > > @@ -1,20 +0,0 @@ > > > -Motorola CPCAP on key > > > - > > > -This module is part of the CPCAP. For more details about the whole > > > -chip see Documentation/devicetree/bindings/mfd/motorola-cpcap.txt. > > > - > > > -This module provides a simple power button event via an Interrupt. > > > - > > > -Required properties: > > > -- compatible: should be one of the following > > > - - "motorola,cpcap-pwrbutton" > > > -- interrupts: irq specifier for CPCAP's ON IRQ > > > - > > > -Example: > > > - > > > -&cpcap { > > > - cpcap_pwrbutton: pwrbutton { > > > - compatible = "motorola,cpcap-pwrbutton"; > > > - interrupts = <23 IRQ_TYPE_NONE>; > > > - }; > > > -}; > > > diff --git a/Documentation/devicetree/bindings/input/motorola,cpcap-pwrbutton.yaml b/Documentation/devicetree/bindings/input/motorola,cpcap-pwrbutton.yaml > > > new file mode 100644 > > > index 000000000000..643f6b2b1f13 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/input/motorola,cpcap-pwrbutton.yaml > > > @@ -0,0 +1,32 @@ > > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/input/motorola,cpcap-pwrbutton.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: Motorola CPCAP PMIC power key > > > + > > > +maintainers: > > > + - Svyatoslav Ryhel > > > + > > > +description: > > > + This module is part of the Motorola CPCAP MFD device. For more details > > > + see Documentation/devicetree/bindings/mfd/motorola,cpcap.yaml. The > > > + power key is represented as a sub-node of the PMIC node on the device > > > + tree. > > > + > > > +properties: > > > + compatible: > > > + const: motorola,cpcap-pwrbutton > > > + > > > + interrupts: > > > + minItems: 1 > > > > Should this be maxItems: 1? > > > > > + description: CPCAP's ON interrupt > > > > Or I suppose: > > > > items: > > - description: ... > > > > Both options are perfectly fine for me, and I lean towards using > "items: desc" but I would like to hear what schema maintainers would > say, which layout is preferred in this case. Either is fine. 'description' is fine if you have something specific about the interrupt to say. Saying what the interrupt is for is specific. So 'description' is good in this case. Rob