From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Svyatoslav Ryhel <clamor95@gmail.com>
Cc: "Lee Jones" <lee@kernel.org>, "Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"Pavel Machek" <pavel@kernel.org>,
"Arnd Bergmann" <arnd@arndb.de>,
"Sebastian Reichel" <sre@kernel.org>,
"Michał Mirosław" <mirq-linux@rere.qmqm.pl>,
"Ion Agorria" <ion@agorria.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-input@vger.kernel.org, linux-leds@vger.kernel.org,
linux-pm@vger.kernel.org
Subject: Re: [PATCH v1 2/9] misc: Support Asus Transformer's EC access device
Date: Tue, 3 Feb 2026 17:58:42 +0100 [thread overview]
Message-ID: <2026020347-mushy-lunar-d12d@gregkh> (raw)
In-Reply-To: <CAPVz0n0TMOCYnMiVUZ7xx-1SqrXuaVCOY-o4-x9L=f-xSMDj8g@mail.gmail.com>
On Tue, Feb 03, 2026 at 06:50:01PM +0200, Svyatoslav Ryhel wrote:
> > debugfs allows you to do much much more than simple stuff like
> > BIN_ATTR_RW(). Go wild there, but don't put debugging stuff in sysfs,
> > that is NOT what it is there for at all, but rather, that is exactly
> > what debugfs is for.
> >
>
> I am removing said stuff from sysfs, that is not what I am asking.
> Debugs does not allow to upload register values in a form of binary
> block. It allows only dumping via debugfs_create_blob or
> debugfs_create_regset32 but not writing. If you know examples of
> reading and writing register sets as binary data, please point me to
> it.
You can easily write your own given that debugfs allows you to use what
ever file operations you want to use for a file. Why not just use that?
> I am asking if it is possible only to preserve dockram_read/write
> functions in the code, without exposing it to sysfs.
Why would you want to do that?
confused,
greg k-h
next prev parent reply other threads:[~2026-02-03 16:58 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-01 10:43 [PATCH v1 0/9] mfd: Add support for Asus Transformer embedded controller Svyatoslav Ryhel
2026-02-01 10:43 ` [PATCH v1 1/9] dt-bindings: misc: document ASUS Transformers EC Dockram Svyatoslav Ryhel
2026-02-01 10:43 ` [PATCH v1 2/9] misc: Support Asus Transformer's EC access device Svyatoslav Ryhel
2026-02-03 11:41 ` Greg Kroah-Hartman
2026-02-03 11:54 ` Svyatoslav Ryhel
2026-02-03 12:00 ` Greg Kroah-Hartman
2026-02-03 12:01 ` Svyatoslav Ryhel
2026-02-03 16:28 ` Svyatoslav Ryhel
2026-02-03 16:45 ` Greg Kroah-Hartman
2026-02-03 16:50 ` Svyatoslav Ryhel
2026-02-03 16:58 ` Greg Kroah-Hartman [this message]
2026-02-04 12:40 ` Svyatoslav Ryhel
2026-02-01 10:43 ` [PATCH v1 3/9] dt-bindings: mfd: document ASUS Transformer EC Svyatoslav Ryhel
2026-02-01 10:43 ` [PATCH v1 4/9] mfd: Add driver for Asus Transformer embedded controller Svyatoslav Ryhel
2026-02-01 17:51 ` kernel test robot
2026-02-01 19:06 ` kernel test robot
2026-02-01 10:43 ` [PATCH v1 5/9] input: serio: Add driver for Asus Transformer dock keyboard and touchpad Svyatoslav Ryhel
2026-02-01 10:43 ` [PATCH v1 6/9] input: keyboard: Add driver for Asus Transformer dock multimedia keys Svyatoslav Ryhel
2026-02-03 11:00 ` Dmitry Torokhov
2026-02-03 11:18 ` Svyatoslav Ryhel
2026-02-01 10:43 ` [PATCH v1 7/9] leds: Add driver for Asus Transformer LEDs Svyatoslav Ryhel
2026-02-01 10:43 ` [PATCH v1 8/9] power: supply: Add driver for Asus Transformer battery Svyatoslav Ryhel
2026-02-01 10:43 ` [PATCH v1 9/9] power: supply: Add charger driver for Asus Transformers Svyatoslav Ryhel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026020347-mushy-lunar-d12d@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=clamor95@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=ion@agorria.com \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mirq-linux@rere.qmqm.pl \
--cc=pavel@kernel.org \
--cc=robh@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox