From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3DF2833F8B7; Tue, 10 Feb 2026 09:25:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770715556; cv=none; b=jsI35NbRVW0AtYYQAIzkyO3lpbpKMaX4bfhlZ+5k/Xyf6Sac/NBIsY/i25zLs0z/dFLHfE8pRfo//fObsvlY6bvazddzbmLVleNMoxykbvybXtAU9HmjA4Jy0Cn8nXorXeEDbpocRZ/3O3F487HUivUfnwq8xFvZfDTIfHGA/uc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770715556; c=relaxed/simple; bh=nTpbF/LC8upmEXEac7kpyDh1IWGjV1DXuBQN7lJPICI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pBU3mPZqReYdAldQAoiRWrrO0al2RpKf+WHfeebMyysPDksMq+/Q/xvW56EdoTqHxneP273TGAPuyPsjxd8drfyDeVuujGT170iXRuVy6SDY2sSHS8oDxEwdO6Z0u5mW4TiRvTQOVtC3NAkSHXfnRWW3y4630bXNzicIQOyxvNw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=aAYyTY28; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="aAYyTY28" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 601AFC19423; Tue, 10 Feb 2026 09:25:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1770715555; bh=nTpbF/LC8upmEXEac7kpyDh1IWGjV1DXuBQN7lJPICI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aAYyTY287oX9lNxxZj7fmMhQJctEfjLm6b56+GD8mKgm/BlDrmN1p3OSwEX0kYl3u HCfBy1Hoe0OQYA+O9Qkzpiv2K3BYlC8q3Z9fzTt9tbGNcJmem4ERsR8+dzQ7p6nE6+ 8KWfi8XquljzZY6grvengKwF1M8nZ14RoecfaftGZ7YlUKvVaYGMAy9X9g/uuN53UE yUUeLZghn1yeAhMXneC6pgFZX8TBJg3tGDhz/XBpeWQH50gmiZPuU45mn5KiOTwFTx abQz9r4Wht3i/fKbUVv/qY0b6rYu+n9mO5hOuYvY/VfD5ynhHICARwUsq2R6XmCklr yqcYQEjUDFFLw== Date: Tue, 10 Feb 2026 10:25:53 +0100 From: Krzysztof Kozlowski To: Svyatoslav Ryhel Cc: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Dmitry Torokhov , Pavel Machek , Arnd Bergmann , Greg Kroah-Hartman , Sebastian Reichel , =?utf-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , Ion Agorria , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-leds@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH v2 1/9] dt-bindings: misc: document ASUS Transformers EC DockRAM Message-ID: <20260210-hidden-swinging-galago-fdcfa3@quoll> References: <20260209104407.116426-1-clamor95@gmail.com> <20260209104407.116426-2-clamor95@gmail.com> Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260209104407.116426-2-clamor95@gmail.com> On Mon, Feb 09, 2026 at 12:43:59PM +0200, Svyatoslav Ryhel wrote: > Documenting an I2C device used in conjunction with the EC on ASUS > Transformers. The main function of DockRAM (the name used by downstream > ASUS sources) is to provide power-related functions, such as battery and > charger communication. The device is exposed as an individual entity > because multiple embedded controllers can utilize the same DockRAM > instance. > > Signed-off-by: Svyatoslav Ryhel > --- > .../bindings/misc/asus,dockram.yaml | 40 +++++++++++++++++++ > 1 file changed, 40 insertions(+) > create mode 100644 Documentation/devicetree/bindings/misc/asus,dockram.yaml > > diff --git a/Documentation/devicetree/bindings/misc/asus,dockram.yaml b/Documentation/devicetree/bindings/misc/asus,dockram.yaml > new file mode 100644 > index 000000000000..0cfde619ba01 > --- /dev/null > +++ b/Documentation/devicetree/bindings/misc/asus,dockram.yaml Not a misc device. Find appropriate place, e.g. for EC or docking or laptop devices or power-related. > @@ -0,0 +1,40 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/misc/asus,dockram.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Asus Transformer EC DockRAM > + > +maintainers: > + - Svyatoslav Ryhel > + > +description: > + Dedicated i2c device used to provide power related functions of the > + embedded controller used in ASUS Transformer device family. > + > +properties: > + compatible: > + const: asus,dockram Way too generic compatible. You are not documenting here all ASUS laptops/devices dockram. For example this implies dockram is also on ASUS Vivobook... or on any other asus device. > + > + reg: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + Device looks weirdly empty. Probably you have it only to instantiate I2C handle, so what you really wanted is i2c-parent. This is not a real device. Best regards, Krzysztof