From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 15D9930DEB5 for ; Sat, 14 Feb 2026 18:10:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771092627; cv=none; b=jwXicOL6ZkrqxGwKQmjsOWaz1y2N2yTpg99BMpia/sjXMk5XaE4bn/R6nnDB2FG4e+RipWNwLbGGKnS3A430MOcddb5lzQH5Wq8BUB6WuKlp2get55qXLjIhUg6AfCzDGr3zCo/hA7tjj1ec0kh1IcNjRhbYcG2pGOZn14JlZZ4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771092627; c=relaxed/simple; bh=1zyGJRBOExbwh0n6XroLNhl7HcDrA1Tx4oZHLECJ4Gw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=VQkZX9fgdLx6EAcUwY8r9QAGadFK/5EqJiUXsij655fvB/6IhMQ/dcKxuzKAaJA55Nqp7C5aU3Bu7XPD2x8uQ5H2sdl8owzg7+Lt5OkxDf1gbmo0BKQ6Ak6aAAs43/6jVrAmGpwKiuSXUkaz/lvCCrdlL0UZ6Orf6IsMdTgP3AU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=In20Bmyc; arc=none smtp.client-ip=209.85.218.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="In20Bmyc" Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-b7cf4a975d2so267462066b.2 for ; Sat, 14 Feb 2026 10:10:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771092621; x=1771697421; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=oKQDTPge46urLSsyv6IEJibXgHmGsc0P4EsjJztIlek=; b=In20BmycSSZrtQToRewhBOMvetZRbShH4kgA22hczOuXNPHbck+OCNJeNNHvRYLwv7 yUPkjJuAMVJTtvh5UtHbZOKv6PIheudhMPaR1Hnw83p8+Vtf/chUf7KHOX4DqQEmgbOs L7NlvJ4+s46x5JEwm6X/dUqXTq3j3Hf8HZy0/VtxhMEm0Ifw7FaxELrjxJ3ElRvTVlc6 EQvgzCAzj7NLrJWL5JmijkxDEsvGf2t7SyRwPgH/iMqWvftBgQvS2sfiPiI6ubvSlfYo cQdRp0SmdtruDhHHqcNw7w1Ob43fLHFGpcAwGcs+ETxE9Y9064mlAI7e95JGtCeFm21l siFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771092621; x=1771697421; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=oKQDTPge46urLSsyv6IEJibXgHmGsc0P4EsjJztIlek=; b=iaSX6ryR+fDhMC5MO1S1RfKqNhi+oghqnmFHqKvnVFJiI0fCjir4sTM7SWEEffkJNe de5HWfekg5O350VpIJSysFpDAHDVGlAXjE182Ktk9yv+nWflyGqnidLLdmR8UbI7FfQG t57QM7OHYuSYhhsWMX4Vj3Z0uaJZNWH5m1v9eqyaBD1Udbi4rZc+FC65NQJ2lMNsw4IJ aK4eyAEr3vJhCD/gpbZCQyUzYjKC65nn+oAtWqsXLWFey1F3fOtt2cefdbrLghhSyoaK LcPX1mdIaYyM8Kj+qu5k/EDP/gZTxNKMGts+nbagadYhzJZ2Jqi0eB3VhdyIWR/hX06I bQUQ== X-Forwarded-Encrypted: i=1; AJvYcCUprB9Bibgne2H5ZVxuTe/+7eiJOzlnz4BL6mk4lJ7AXVIcHqh0e1z/dRMaB6+07q5n4SsMeBxNfc6pgg==@vger.kernel.org X-Gm-Message-State: AOJu0Yz1zPiYFyLkZSKAzNCt0Nf0qfvU9CfUDUKcD2384tASfJXxLCCm yokvSLMxPsSWXSbEVG+PNNwHm+6oqPXwr7qx01fua+BbxgoX1NyPESRT X-Gm-Gg: AZuq6aLVRdP6mAj2Wz0VmkF0nHTJ3Tt2Z7hAwbzbuUU/udbsXheKKTVxLUvoN0F7OEJ NUYWMo/RR4ZiD9AdKSOPQYG8CoICJ+p4FHc1vMue2znx+6SLw9S5/5k2q7VI6gy7iQXOoYPBi0Y qxLx2wdfWgSpbW3t5WLW1aZHSUlPymymI0qLrLpBUUoWdaPcwrCdzXGLhCwQAX9hc7fk3v9kZoh ejGVBccWJrWFyBwz5Pw/pNz6+Zo5FW5JfJ7yBDl3o9XYywanmNH8KwbzvfmLPZYZSEO6YHD30OV dGc3WgZFu1VZZBVldCquOPthRVzSi5VV+WqI6JFYvWEfOBa7EjXavwViXy5AirB1e/yYSv5mp7b EqGCj3GYKbRtQxcw5ngUFSUltBz+1OTdqpTIQU6ZAVDgQ0PKyNGZ4Vmz2/6WJ1VYOJL6TQLCM5j m6yIrDTSLiLybR X-Received: by 2002:a17:907:9727:b0:b87:1d30:7e6 with SMTP id a640c23a62f3a-b8fb4175842mr307347266b.11.1771092621203; Sat, 14 Feb 2026 10:10:21 -0800 (PST) Received: from xeon ([188.163.112.48]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8fc735e506sm88122066b.11.2026.02.14.10.10.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Feb 2026 10:10:20 -0800 (PST) From: Svyatoslav Ryhel To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Dmitry Torokhov , Lee Jones , Pavel Machek , Sebastian Reichel , Svyatoslav Ryhel , Ion Agorria , =?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-leds@vger.kernel.org, linux-pm@vger.kernel.org Subject: [PATCH v3 4/7] input: keyboard: Add driver for ASUS Transformer dock multimedia keys Date: Sat, 14 Feb 2026 20:09:56 +0200 Message-ID: <20260214180959.30714-5-clamor95@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260214180959.30714-1-clamor95@gmail.com> References: <20260214180959.30714-1-clamor95@gmail.com> Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Michał Mirosław Add support for multimedia top button row of ASUS Transformer's Mobile Dock keyboard. Driver is made that function keys (F1-F12) are used by default which suits average Linux use better and with pressing ScreenLock + AltGr function keys layout is switched to multimedia keys. Since this only modifies codes sent by asus-ec-keys it doesn't affect normal keyboards at all. Co-developed-by: Ion Agorria Signed-off-by: Ion Agorria Signed-off-by: Michał Mirosław Signed-off-by: Svyatoslav Ryhel --- drivers/input/keyboard/Kconfig | 10 + drivers/input/keyboard/Makefile | 1 + .../input/keyboard/asus-transformer-ec-keys.c | 272 ++++++++++++++++++ 3 files changed, 283 insertions(+) create mode 100644 drivers/input/keyboard/asus-transformer-ec-keys.c diff --git a/drivers/input/keyboard/Kconfig b/drivers/input/keyboard/Kconfig index 2ff4fef322c2..4e577e5cf216 100644 --- a/drivers/input/keyboard/Kconfig +++ b/drivers/input/keyboard/Kconfig @@ -89,6 +89,16 @@ config KEYBOARD_APPLESPI To compile this driver as a module, choose M here: the module will be called applespi. +config KEYBOARD_ASUS_TRANSFORMER_EC + tristate "Asus Transformer's Mobile Dock multimedia keys" + depends on MFD_ASUS_TRANSFORMER_EC + help + Say Y here if you want to use multimedia keys present on Asus + Transformer's Mobile Dock. + + To compile this driver as a module, choose M here: the + module will be called asus-transformer-ec-keys. + config KEYBOARD_ATARI tristate "Atari keyboard" depends on ATARI diff --git a/drivers/input/keyboard/Makefile b/drivers/input/keyboard/Makefile index 2d906e14f3e2..575edb0e8eb4 100644 --- a/drivers/input/keyboard/Makefile +++ b/drivers/input/keyboard/Makefile @@ -11,6 +11,7 @@ obj-$(CONFIG_KEYBOARD_ADP5585) += adp5585-keys.o obj-$(CONFIG_KEYBOARD_ADP5588) += adp5588-keys.o obj-$(CONFIG_KEYBOARD_AMIGA) += amikbd.o obj-$(CONFIG_KEYBOARD_APPLESPI) += applespi.o +obj-$(CONFIG_KEYBOARD_ASUS_TRANSFORMER_EC) += asus-transformer-ec-keys.o obj-$(CONFIG_KEYBOARD_ATARI) += atakbd.o obj-$(CONFIG_KEYBOARD_ATKBD) += atkbd.o obj-$(CONFIG_KEYBOARD_BCM) += bcm-keypad.o diff --git a/drivers/input/keyboard/asus-transformer-ec-keys.c b/drivers/input/keyboard/asus-transformer-ec-keys.c new file mode 100644 index 000000000000..4cdebce58988 --- /dev/null +++ b/drivers/input/keyboard/asus-transformer-ec-keys.c @@ -0,0 +1,272 @@ +// SPDX-License-Identifier: GPL-2.0-or-later + +#include +#include +#include +#include +#include +#include +#include +#include + +#define ASUSEC_EXT_KEY_CODES 0x20 + +struct asus_ec_keys_data { + struct notifier_block nb; + struct asusec_info *ec; + struct input_dev *xidev; + bool special_key_pressed; + bool special_key_mode; + unsigned short keymap[ASUSEC_EXT_KEY_CODES * 2]; +}; + +static void asus_ec_input_event(struct input_handle *handle, + unsigned int event_type, + unsigned int event_code, int value) +{ + struct asus_ec_keys_data *priv = handle->handler->private; + + /* Store special key state */ + if (event_type == EV_KEY && event_code == KEY_RIGHTALT) + priv->special_key_pressed = !!value; +} + +static int asus_ec_input_connect(struct input_handler *handler, struct input_dev *dev, + const struct input_device_id *id) +{ + struct input_handle *handle; + int error; + + handle = kzalloc(sizeof(*handle), GFP_KERNEL); + if (!handle) + return -ENOMEM; + + handle->dev = dev; + handle->handler = handler; + handle->name = "asusec-media-handler"; + + error = input_register_handle(handle); + if (error) + goto err_free_handle; + + error = input_open_device(handle); + if (error) + goto err_unregister_handle; + + return 0; + + err_unregister_handle: + input_unregister_handle(handle); + err_free_handle: + kfree(handle); + + return error; +} + +static void asus_ec_input_disconnect(struct input_handle *handle) +{ + input_close_device(handle); + input_unregister_handle(handle); + kfree(handle); +} + +static const struct input_device_id asus_ec_input_ids[] = { + { + .flags = INPUT_DEVICE_ID_MATCH_EVBIT, + .evbit = { BIT_MASK(EV_KEY) }, + }, + { } +}; + +static struct input_handler asus_ec_input_handler = { + .name = "asusec-media-handler", + .event = asus_ec_input_event, + .connect = asus_ec_input_connect, + .disconnect = asus_ec_input_disconnect, + .id_table = asus_ec_input_ids, +}; + +static const unsigned short asus_ec_dock_ext_keys[] = { + /* Function keys [0x00 - 0x19] */ + [0x01] = KEY_DELETE, + [0x02] = KEY_F1, + [0x03] = KEY_F2, + [0x04] = KEY_F3, + [0x05] = KEY_F4, + [0x06] = KEY_F5, + [0x07] = KEY_F6, + [0x08] = KEY_F7, + [0x10] = KEY_F8, + [0x11] = KEY_F9, + [0x12] = KEY_F10, + [0x13] = KEY_F11, + [0x14] = KEY_F12, + [0x15] = KEY_MUTE, + [0x16] = KEY_VOLUMEDOWN, + [0x17] = KEY_VOLUMEUP, + /* Multimedia keys [0x20 - 0x39] */ + [0x21] = KEY_SCREENLOCK, + [0x22] = KEY_WLAN, + [0x23] = KEY_BLUETOOTH, + [0x24] = KEY_TOUCHPAD_TOGGLE, + [0x25] = KEY_BRIGHTNESSDOWN, + [0x26] = KEY_BRIGHTNESSUP, + [0x27] = KEY_BRIGHTNESS_AUTO, + [0x28] = KEY_PRINT, + [0x30] = KEY_WWW, + [0x31] = KEY_CONFIG, + [0x32] = KEY_PREVIOUSSONG, + [0x33] = KEY_PLAYPAUSE, + [0x34] = KEY_NEXTSONG, + [0x35] = KEY_MUTE, + [0x36] = KEY_VOLUMEDOWN, + [0x37] = KEY_VOLUMEUP, +}; + +static void asus_ec_keys_report_key(struct input_dev *dev, unsigned int code, + unsigned int key, bool value) +{ + input_event(dev, EV_MSC, MSC_SCAN, code); + input_report_key(dev, key, value); + input_sync(dev); +} + +static int asus_ec_keys_process_key(struct input_dev *dev, u8 code) +{ + struct asus_ec_keys_data *priv = dev_get_drvdata(dev->dev.parent); + unsigned int key = 0; + + if (code == 0) + return NOTIFY_DONE; + + /* Flip special key mode state when pressing key 1 with special key pressed */ + if (priv->special_key_pressed && code == 1) { + priv->special_key_mode = !priv->special_key_mode; + return NOTIFY_DONE; + } + + /* + * Relocate code to second "page" if pressed state XOR's mode state + * This way special key will invert the current mode + */ + if (priv->special_key_mode ^ priv->special_key_pressed) + code += ASUSEC_EXT_KEY_CODES; + + if (code < dev->keycodemax) { + unsigned short *map = dev->keycode; + + key = map[code]; + } + + if (!key) + key = KEY_UNKNOWN; + + asus_ec_keys_report_key(dev, code, key, 1); + asus_ec_keys_report_key(dev, code, key, 0); + + return NOTIFY_OK; +} + +static int asus_ec_keys_notify(struct notifier_block *nb, + unsigned long action, void *data_) +{ + struct asus_ec_keys_data *priv = container_of(nb, struct asus_ec_keys_data, nb); + u8 *data = data_; + + if (action & ASUSEC_SMI_MASK) + return NOTIFY_DONE; + + if (action & ASUSEC_SCI_MASK) + return asus_ec_keys_process_key(priv->xidev, data[2]); + + return NOTIFY_DONE; +} + +static void asus_ec_keys_setup_keymap(struct asus_ec_keys_data *priv) +{ + struct input_dev *dev = priv->xidev; + unsigned int i; + + BUILD_BUG_ON(ARRAY_SIZE(priv->keymap) < ARRAY_SIZE(asus_ec_dock_ext_keys)); + + dev->keycode = priv->keymap; + dev->keycodesize = sizeof(*priv->keymap); + dev->keycodemax = ARRAY_SIZE(priv->keymap); + + input_set_capability(dev, EV_MSC, MSC_SCAN); + input_set_capability(dev, EV_KEY, KEY_UNKNOWN); + + for (i = 0; i < ARRAY_SIZE(asus_ec_dock_ext_keys); i++) { + unsigned int code = asus_ec_dock_ext_keys[i]; + + if (!code) + continue; + + __set_bit(code, dev->keybit); + priv->keymap[i] = code; + } +} + +static void asus_ec_input_handler_deregister(void *priv) +{ + input_unregister_handler(&asus_ec_input_handler); +} + +static int asus_ec_keys_probe(struct platform_device *pdev) +{ + struct asusec_info *ec = cell_to_ec(pdev); + struct i2c_client *parent = to_i2c_client(pdev->dev.parent); + struct asus_ec_keys_data *priv; + int ret; + + priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL); + if (!priv) + return -ENOMEM; + + platform_set_drvdata(pdev, priv); + priv->ec = ec; + + priv->xidev = devm_input_allocate_device(&pdev->dev); + if (!priv->xidev) + return -ENOMEM; + + priv->xidev->name = devm_kasprintf(&pdev->dev, GFP_KERNEL, + "%s Keyboard Ext", ec->model); + priv->xidev->phys = devm_kasprintf(&pdev->dev, GFP_KERNEL, + "i2c-%u-%04x", + i2c_adapter_id(parent->adapter), + parent->addr); + asus_ec_keys_setup_keymap(priv); + + ret = input_register_device(priv->xidev); + if (ret < 0) { + dev_err(&pdev->dev, "failed to register extension keys: %d\n", + ret); + return ret; + } + + asus_ec_input_handler.private = priv; + + ret = input_register_handler(&asus_ec_input_handler); + if (ret) + return ret; + + ret = devm_add_action_or_reset(&pdev->dev, asus_ec_input_handler_deregister, + priv); + if (ret) + return ret; + + priv->nb.notifier_call = asus_ec_keys_notify; + + return devm_asus_ec_register_notifier(pdev, &priv->nb); +} + +static struct platform_driver asus_ec_keys_driver = { + .driver.name = "asus-transformer-ec-keys", + .probe = asus_ec_keys_probe, +}; +module_platform_driver(asus_ec_keys_driver); + +MODULE_AUTHOR("Michał Mirosław "); +MODULE_DESCRIPTION("ASUS Transformer's multimedia keys driver"); +MODULE_LICENSE("GPL"); -- 2.51.0