From: Yauhen Kharuzhy <jekhor@gmail.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>, linux-input@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Hans de Goede <hansg@kernel.org>
Subject: [PATCH v2 5/5] input: drv260x: Handle calibration timeout
Date: Sun, 15 Feb 2026 16:14:35 +0200 [thread overview]
Message-ID: <20260215141435.727872-6-jekhor@gmail.com> (raw)
In-Reply-To: <20260215141435.727872-1-jekhor@gmail.com>
If something goes wrong during calibration (for instance, if the 'enable'
GPIO was not properly defined), the GO bit may not be cleared after some
time, causing the driver to get stuck.
To prevent this, add a timeout check to the waiting loop and return an
error if it times out.
Signed-off-by: Yauhen Kharuzhy <jekhor@gmail.com>
---
drivers/input/misc/drv260x.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/drivers/input/misc/drv260x.c b/drivers/input/misc/drv260x.c
index 71fbdabc6589..7ab891210fad 100644
--- a/drivers/input/misc/drv260x.c
+++ b/drivers/input/misc/drv260x.c
@@ -166,6 +166,12 @@
#define DRV260X_AUTOCAL_TIME_500MS (2 << 4)
#define DRV260X_AUTOCAL_TIME_1000MS (3 << 4)
+/*
+ * Timeout for waiting for the GO status bit, in seconds. Should be reasonably
+ * large to wait for a auto-calibration cycle completion.
+ */
+#define DRV260X_GO_TIMEOUT_S 5
+
/**
* struct drv260x_data -
* @input_dev: Pointer to the input device
@@ -309,6 +315,7 @@ static int drv260x_init(struct drv260x_data *haptics)
{
int error;
unsigned int cal_buf;
+ unsigned long timeout;
error = regmap_write(haptics->regmap,
DRV260X_RATED_VOLT, haptics->rated_voltage);
@@ -398,6 +405,7 @@ static int drv260x_init(struct drv260x_data *haptics)
return error;
}
+ timeout = jiffies + DRV260X_GO_TIMEOUT_S * HZ;
do {
usleep_range(15000, 15500);
error = regmap_read(haptics->regmap, DRV260X_GO, &cal_buf);
@@ -407,6 +415,11 @@ static int drv260x_init(struct drv260x_data *haptics)
error);
return error;
}
+ if (time_after(jiffies, timeout)) {
+ dev_err(&haptics->client->dev,
+ "Calibration timeout. The device cannot be used.\n");
+ return -ETIMEDOUT;
+ }
} while (cal_buf == DRV260X_GO_BIT);
return 0;
--
2.51.0
next prev parent reply other threads:[~2026-02-15 14:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-15 14:14 [PATCH v2 0/5] DRV260x: Support ACPI-enumerated devices Yauhen Kharuzhy
2026-02-15 14:14 ` [PATCH v2 1/5] input: drv260x: Add I2C IDs for all device variants Yauhen Kharuzhy
2026-02-15 14:14 ` [PATCH v2 2/5] input: drv260x: Sort all #include alphabetically Yauhen Kharuzhy
2026-02-15 14:14 ` [PATCH v2 3/5] input: drv260x: Add support for ACPI-enumerated devices Yauhen Kharuzhy
2026-02-15 14:14 ` [PATCH v2 4/5] input: drv260x: Fix unbalanced regulator_disable() call Yauhen Kharuzhy
2026-02-19 2:43 ` Dmitry Torokhov
2026-02-19 10:11 ` Yauhen Kharuzhy
2026-02-24 22:45 ` Dmitry Torokhov
2026-02-15 14:14 ` Yauhen Kharuzhy [this message]
2026-02-19 2:44 ` [PATCH v2 0/5] DRV260x: Support ACPI-enumerated devices Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260215141435.727872-6-jekhor@gmail.com \
--to=jekhor@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=hansg@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox