Re: [PATCH v3 1/7] dt-bindings: embedded-controller: document ASUS Transformer EC

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 4354 bytes --]

On Sat, Feb 14, 2026 at 08:09:53PM +0200, Svyatoslav Ryhel wrote:
> Document embedded controller used in ASUS Transformer device series.
> 
> Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
> ---
>  .../asus,transformer-ec.yaml                  | 98 +++++++++++++++++++
>  1 file changed, 98 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/embedded-controller/asus,transformer-ec.yaml
> 
> diff --git a/Documentation/devicetree/bindings/embedded-controller/asus,transformer-ec.yaml b/Documentation/devicetree/bindings/embedded-controller/asus,transformer-ec.yaml
> new file mode 100644
> index 000000000000..670c4c2d339d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/embedded-controller/asus,transformer-ec.yaml
> @@ -0,0 +1,98 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/embedded-controller/asus,transformer-ec.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: ASUS Transformer's Embedded Controller
> +
> +description:
> +  Several Nuvoton based Embedded Controllers attached to an I2C bus,
> +  running a custom ASUS firmware, specific to the ASUS Transformer
> +  device series.
> +
> +maintainers:
> +  - Svyatoslav Ryhel <clamor95@gmail.com>
> +
> +allOf:
> +  - $ref: /schemas/power/supply/power-supply.yaml
> +
> +properties:
> +  compatible:
> +    oneOf:
> +      - enum:
> +          - asus,p1801-t-ec-pad
> +          - asus,sl101-ec-dock
> +          - asus,tf600t-ec-pad
> +          - asus,tf701t-ec-pad
> +
> +      - items:
> +          - enum:
> +              - asus,tf101-ec-dock
> +              - asus,tf101g-ec-dock
> +              - asus,tf201-ec-dock
> +              - asus,tf300t-ec-dock
> +              - asus,tf300tg-ec-dock
> +              - asus,tf300tl-ec-dock
> +              - asus,tf700t-ec-dock
> +          - const: asus,transformer-ec-dock
> +
> +      - items:
> +          - enum:
> +              - asus,tf201-ec-pad
> +              - asus,tf300t-ec-pad
> +              - asus,tf300tg-ec-pad
> +              - asus,tf300tl-ec-pad
> +              - asus,tf700t-ec-pad
> +          - const: asus,transformer-ec-pad

Can you explain somewhere here what the "dock" and "pad" devices are and
how they differ? For example, I am currently wondering why tf700t has both
"dock" and "pad".
Also, why are some of the compatibles permitted standalone? That should
be mentioned in your commit message too. Also, other than the sl101, the
standalone ones seem to have the same match data in the mfd driver. Why
are fallbacks not made use of there?

Since this transformer series seems to have multiple programming models
for "ec-pad" devices, it calls into question your use of the generic
fallback compatibles is appropriate and makes it seem like you should be
using device compatibles as a fallback.

The rest looks okay other than the filename, which doesn't match any of
the compatibles that you've got here.

Cheers,
Conor.

> +
> +  reg:
> +    description:
> +      The ASUS Transformer EC has a main I2C address and an associated
> +      DockRAM device, which provides power-related functions for the
> +      embedded controller. Both addresses are required for operation.
> +    minItems: 2
> +
> +  reg-names:
> +    items:
> +      - const: ec
> +      - const: dockram
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  request-gpios:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - reg-names
> +  - interrupts
> +  - request-gpios
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +
> +    i2c {
> +      #address-cells = <1>;
> +      #size-cells = <0>;
> +
> +      embedded-controller@19 {
> +        compatible = "asus,tf201-ec-dock", "asus,transformer-ec-dock";
> +        reg = <0x19>, <0x1b>;
> +        reg-names = "ec", "dockram";
> +
> +        interrupt-parent = <&gpio>;
> +        interrupts = <151 IRQ_TYPE_LEVEL_LOW>;
> +
> +        request-gpios = <&gpio 134 GPIO_ACTIVE_LOW>;
> +
> +        monitored-battery = <&dock_battery>;
> +      };
> +    };
> +...
> -- 
> 2.51.0
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]