From: "Günther Noack" <gnoack@google.com>
To: Jiri Kosina <jikos@kernel.org>, Benjamin Tissoires <bentiss@kernel.org>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
"Günther Noack" <gnoack@google.com>
Subject: [PATCH v2 2/4] HID: apple: avoid memory leak in apple_report_fixup()
Date: Thu, 19 Feb 2026 16:43:36 +0100 [thread overview]
Message-ID: <20260219154338.786625-3-gnoack@google.com> (raw)
In-Reply-To: <20260219154338.786625-1-gnoack@google.com>
The apple_report_fixup() function was returning a
newly kmemdup()-allocated buffer, but never freeing it.
The caller of report_fixup() does not take ownership of the returned
pointer, but it *is* permitted to return a sub-portion of the input
rdesc, whose lifetime is managed by the caller.
Assisted-by: Gemini-CLI:Google Gemini 3
Signed-off-by: Günther Noack <gnoack@google.com>
---
drivers/hid/hid-apple.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/hid/hid-apple.c b/drivers/hid/hid-apple.c
index 233e367cce1d..894adc23367b 100644
--- a/drivers/hid/hid-apple.c
+++ b/drivers/hid/hid-apple.c
@@ -686,9 +686,7 @@ static const __u8 *apple_report_fixup(struct hid_device *hdev, __u8 *rdesc,
hid_info(hdev,
"fixing up Magic Keyboard battery report descriptor\n");
*rsize = *rsize - 1;
- rdesc = kmemdup(rdesc + 1, *rsize, GFP_KERNEL);
- if (!rdesc)
- return NULL;
+ rdesc = rdesc + 1;
rdesc[0] = 0x05;
rdesc[1] = 0x01;
--
2.53.0.371.g1d285c8824-goog
next prev parent reply other threads:[~2026-02-19 15:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-19 15:43 [PATCH v2 0/4] HID: Fix some memory leaks in drivers/hid Günther Noack
2026-02-19 15:43 ` [PATCH v2 1/4] HID: Document memory allocation properties of report_fixup() Günther Noack
2026-02-19 15:43 ` Günther Noack [this message]
2026-02-19 15:43 ` [PATCH v2 3/4] HID: magicmouse: avoid memory leak in magicmouse_report_fixup() Günther Noack
2026-02-19 15:43 ` [PATCH v2 4/4] HID: asus: avoid memory leak in asus_report_fixup() Günther Noack
2026-02-19 18:17 ` [PATCH v2 0/4] HID: Fix some memory leaks in drivers/hid Benjamin Tissoires
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260219154338.786625-3-gnoack@google.com \
--to=gnoack@google.com \
--cc=bentiss@kernel.org \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox