From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f180.google.com (mail-dy1-f180.google.com [74.125.82.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C45F52550D5 for ; Tue, 24 Feb 2026 01:32:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771896751; cv=none; b=g6lGJXWlEt1TYi3NrDgjfwBtRThx/baDc813swwra7/sOEd99ZT07NPEXoVWGLbZToYcq08DCEka2/rehPosOfdzOkFp8iPd4uCebmS7BKrx53dk1IL+79rBZTDC4+yty0bDu/9XLVp25azNuxycMSlUjnUDN/pSk9UU2KJbDds= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771896751; c=relaxed/simple; bh=hUo1MvYccpbWMaWLjJzMWrm+A+W/DdILFntNUVeXgaY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JMHTQHUNfHDYH4ThEBsWhb/CSXbIT6dl9Srg3e8c2S0yHbKRGmQP63Y+0cVFfuErykrkUjsJvyBkU97uXWhHHQpe+rqWTQeHGXmQ+5/n3298CRqujUGCbN2D5CvfKivhAMjJIa0zLVB3UOC7D9acvSBXtAHX1C7JGmQbRh3sQNY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=d8UnYf+g; arc=none smtp.client-ip=74.125.82.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="d8UnYf+g" Received: by mail-dy1-f180.google.com with SMTP id 5a478bee46e88-2b4520f6b32so6101578eec.0 for ; Mon, 23 Feb 2026 17:32:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771896749; x=1772501549; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=yFj2OTG3aeriS2nQMueP/Sb6Nx66D9fuh6qoYGYRpGo=; b=d8UnYf+gk0hMIczhCOELyg7sTflNdW7BIdBSON78kI5jIzgeyJWlecBztQyZBqyen5 nFKMbRZTGskMnFh8R1N3ibPaK014yS+TTGC0BN0RB/SlPwUjVr/ZXLP3+jpto6i4R8f9 qtJvQk96LkxLzetYnK98ysqoCfm/BiaVl/lZKL2qnJ63v06UyWxuA0QNUhrAzwuxBL1J wEe1HCHEEPGhOw98dtEt1NnvA7qnC1g+mFmQU8PhSoO6Cv/gAJnGtaowkAF4Pe0snuWb WmDF0eANy/NfuD0E/0Xkh9MJVHw9TeYEh6xBgxfCeilYYir7bhwXHm1CGKXopCnKIpe5 npIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771896749; x=1772501549; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=yFj2OTG3aeriS2nQMueP/Sb6Nx66D9fuh6qoYGYRpGo=; b=GCHFOoiR3iPf3JMkBrSHTxVScHtop9vD4z6Sx+3U7QOK9oX8N+cqi3T/nBKW7KQY/O Z/VjYFDmHfXmkW6xN4mvDYdETwGn3D2g8ynNVlIxW7zruck2RDyH8QY5AaEz6M5EUM+E /ySTmG6BnHg2AQHRgUzlJZP0OoTQqqh0KmJXx7OIaWnZNCx1hZsa0hSZYJ5f99xhdxkY f8FDyQK5g0kksA0qT7XT51hzhoo7p433CwrPhNouEr4Mg+EqK3SMFHjWFD7bd88eJrNF 9pl/5+ZQBuFUvXv6OUMZ+eyF5u34jjCgR9hVeiqqdnOG+eLdvbQ+PujjO6CYVZ14L5eK OrCw== X-Forwarded-Encrypted: i=1; AJvYcCUkLF9deikPpF1JvfvT6C8BOvZMOc9Y8nVUblXF3oMxLEOE0yrYCCuAYHBn444PoWGCahrEA7vgYtQaJw==@vger.kernel.org X-Gm-Message-State: AOJu0Yy0Og0RQ3W0wKQ3OgDkvHiDyX1dgmo3TsGSIZZjB7ufqfreGFcU KpkQtxsAWTwRxO60sklq+8qkIkDNsLfUeP8lkzJztYVxBbKVgAjMYDvb X-Gm-Gg: ATEYQzyiT+0XAlj50sf4eJP4hH6QvzldqDaP6wXiZ9iu3GXk99mc5uz38GrOx+ApXum xbmqYdAihYXPnbG0261BVh1EpDRJ7J5MmeXEBnFh2Wr4PahuNZXQeqV3102YvTVlyf7QC5P0QSn k1uM3H1LtKofEkq3bkKsaDdMD7yZD2ZLQXt7B09iXQhNHTKZtMcJKXJQK9JixhUZUtIs0wHxtyt n3Utl2kkGBdGPB1Xtb7024h2IyR3BlnyMFTtAaJdz1GKktnBETTOopxMMN1VoXyjbFdc6WtJkw7 fVGZSkMRkJldxYmLOzwPWY6ctMO9CY4Bdnx/0sEEJr3LHOcG0RshPR93ban+8Im3tYhvTYXXLdU OPFTB5AFDKjy2K/EDskKwr7E5z1/uuVMhpqazds7Cm66AcUvEmrk1yu0asyLe5NlWehbfrUOcr1 JpRTx/6KlXFD0GKiYrfn1c4kAk5IE7FXqI/RyIY0q3iGdbwxKl6ncs1tuyC8EznrFNL7wlKCguK Ls= X-Received: by 2002:a05:7301:3e07:b0:2a4:3593:466d with SMTP id 5a478bee46e88-2bd7baea76emr2780020eec.9.1771896748880; Mon, 23 Feb 2026 17:32:28 -0800 (PST) Received: from lappy (108-228-232-20.lightspeed.sndgca.sbcglobal.net. [108.228.232.20]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2bd7daa027fsm6485015eec.9.2026.02.23.17.32.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Feb 2026 17:32:28 -0800 (PST) From: "Derek J. Clark" To: Jiri Kosina , Benjamin Tissoires Cc: Richard Hughes , Mario Limonciello , Zhixin Zhang , Mia Shao , Mark Pearson , "Pierre-Loup A . Griffais" , "Derek J . Clark" , linux-input@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 09/16] HID: Include firmware version in the uevent Date: Tue, 24 Feb 2026 01:32:10 +0000 Message-ID: <20260224013217.1363996-10-derekjohn.clark@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260224013217.1363996-1-derekjohn.clark@gmail.com> References: <20260224013217.1363996-1-derekjohn.clark@gmail.com> Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Mario Limonciello Userspace software fwupd probes some HID devices when the daemon starts up to determine the current firmware version in order to be able to offer updated firmware if the manufacturer has made it available. In order to do this fwupd will detach the existing kernel driver if one is present, send a HID command and then reattach the kernel driver. This can be problematic if the user is using the HID device at the time that fwupd probes the hardware and can cause a few frames of input to be dropped. In some cases HID drivers already have a command to look up the firmware version, and so if that is exported to userspace fwupd can discover it and avoid needing to detach the kernel driver until it's time to update the device. Introduce a new member in the struct hid_device for the version and export a new uevent variable HID_FIRMWARE_VERSION that will display the version that HID drivers obtained. Reviewed-by: Mark Pearson Cc: Richard Hughes Signed-off-by: Mario Limonciello --- drivers/hid/hid-core.c | 5 +++++ include/linux/hid.h | 1 + 2 files changed, 6 insertions(+) diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c index a5b3a8ca2fcbc..524f2b9ed5121 100644 --- a/drivers/hid/hid-core.c +++ b/drivers/hid/hid-core.c @@ -2887,6 +2887,11 @@ static int hid_uevent(const struct device *dev, struct kobj_uevent_env *env) if (add_uevent_var(env, "MODALIAS=hid:b%04Xg%04Xv%08Xp%08X", hdev->bus, hdev->group, hdev->vendor, hdev->product)) return -ENOMEM; + if (hdev->firmware_version) { + if (add_uevent_var(env, "HID_FIRMWARE_VERSION=0x%04llX", + hdev->firmware_version)) + return -ENOMEM; + } return 0; } diff --git a/include/linux/hid.h b/include/linux/hid.h index dce862cafbbd3..ce728c8d5bdc4 100644 --- a/include/linux/hid.h +++ b/include/linux/hid.h @@ -698,6 +698,7 @@ struct hid_device { char name[128]; /* Device name */ char phys[64]; /* Device physical location */ char uniq[64]; /* Device unique identifier (serial #) */ + u64 firmware_version; /* Firmware version */ void *driver_data; -- 2.52.0