From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f180.google.com (mail-dy1-f180.google.com [74.125.82.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E4BAF28466F for ; Tue, 24 Feb 2026 01:32:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771896756; cv=none; b=TWYheHQx1n5fZAtfW7GmUbQXKBQPvt3d8znp5ME+tdVJBAqxhvVxRJQPOGxK1i6URZJGe7bPz48YyDg6kwlwhZ18xFHM7FXDaw8Q65VXdK/mQ2//NEFOlxOCtkPknFoeataxgmfjSwvUUBdXLfV7v5lgtl3bWBfmuTLROne1iHI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771896756; c=relaxed/simple; bh=MJEBoLXx6kZaotyArkUmXw4t11kA39rfjHgA906xTGo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=uL/wRs2mIXwNLlm2xXgMS0FQ9ypHTwB/IwDk2Uw11bLQJSx7Q7qHTKr/SNquoNtjXddP2GhNvLSGpPgXywAJOnGR0l3e8V2CDEIORUadOtUgsiLL4d0haC1d87MlNKnrRfjnjeHUPlLt6EmatJf3Gr2fKNInADpFlUjbb+M3n6s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TMPVpN8l; arc=none smtp.client-ip=74.125.82.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TMPVpN8l" Received: by mail-dy1-f180.google.com with SMTP id 5a478bee46e88-2ba94dbf739so5433122eec.1 for ; Mon, 23 Feb 2026 17:32:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771896752; x=1772501552; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=EQzl3yVDAN1730LcqI2ceRttYFMRQfPPEDz6M2H8l6E=; b=TMPVpN8lcCA97sOYW2SiFDRtxiyHz8xlOz8TKE/XBnJhU3QERUhXGwPQCIONmbxo6u 2G4Wqj4Lj18qB8Mbm81WkZeEi8OMVQAgK6l4P24i6t1KDin8I9ji9isMUnDSY4hP4C32 GxQf2hJnKT9VFqoxOz0cMpwbJAIzdLURGNnZpOucdztcZbvl4eqqfbzoeK6aeJp2XPtN hT45HRYKidGI8rFCHGjjFpOQTnLdAAnHC6QXjghP+LdY6+C58a3AZxeo0V9KKefhcXUv M7uvZvHyk6z3Rk5N2H06XbpGoNhAvI9YQhw373yMbo52HLqw/aj9ZIbtGaqEYJYICkVX 0OqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771896752; x=1772501552; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=EQzl3yVDAN1730LcqI2ceRttYFMRQfPPEDz6M2H8l6E=; b=g/2zgKbx/Zxb7nr82TtTYP+lGn6L9+vDQbud2zSw0TXVCGpnn7AbdR7N12RQniYCbJ 0mEqTuDXBsHzbF1sOD6xTh9eP15CKWQM0379w3cFK/C7zTeXD/xkoIJS1mO8hfFOsSDF yZA2LdRd//oRxaJldcVtoeZZEz1OfcgRr/LS0ztqEqMtf91k18NSJXDKp1Z6nSK9u1eK 5GR0U0qRd9onzx1tXW7V/mquUm3udeW4tyXGvtoEPzC3s3iq+pFKvj5h47KJQbMLPhcX riSXMvIUIYxN6YoCvT8usqxt2DBBfewCGMoOyrUT15+avO8gc//+7D1IV2HMFmSUX0nr 1pIA== X-Forwarded-Encrypted: i=1; AJvYcCULamFMJwMNVQyZsDXeWQlgeCrrftfG2e/Sbr/VpeNSda+jhZaWHSI7L46QPgjv72hUfvwc3xjWHQOeyQ==@vger.kernel.org X-Gm-Message-State: AOJu0YwctjEdXC6IRq5XozzH+2YgQ2x07j+fzTzUYHqvsrztArsm8zBj CqgPyOKldjEb0BwTywIVRYR6lk0ZQ+GlwNmK++0yYrgznIgn+lSsVlfw X-Gm-Gg: ATEYQzwuy7Bv2I2GouHBY27VKjbc1UZgWOUWDozvF/UnPCj3JKiA38rWHiw6D1BLday DabNDzAhliWj7YQQd8LQpOjkdU8+lMvmuxpMjvjujztCB1SRsABYuoZt2h2eCEAwsqmsKxDLKQA GSAecklWl/3MUM97iI09n+zJLD6TAk/pgBu6e5yzd98ZH5DPE+si3iMnE1nrDyHh8P8WXJETx1+ sHZATRYwwGxIRIRqVFIxkt4icuv85dh6wA1l+aij4Lhefc3ezAiPHWNukfc5g+yU1nQvliqqRtJ 78OiDMn+Qk9pZzmfEdqADxVUhkRZn8FEd05DeVLp7umGiBtbSOUpID7ZmhU5cNVNEUN2gVcDBfJ N3HlZ1EI/60aL8WFxXC0ZkKNuALsTZhTwlBke+VcXP1erPVShTfRCjYff5nXopqbp54Wi83zl57 nEch5uMqujpWNI7qfgQ4lZy3CKRHZrOtYZ0DbCOxvBBk7JrLKaMv26DTqhL+i9URHKzXlwS7wTh c4= X-Received: by 2002:a05:693c:2c0a:b0:2ab:8ef5:df2 with SMTP id 5a478bee46e88-2bd7bd59af3mr4703596eec.35.1771896752005; Mon, 23 Feb 2026 17:32:32 -0800 (PST) Received: from lappy (108-228-232-20.lightspeed.sndgca.sbcglobal.net. [108.228.232.20]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2bd7daa027fsm6485015eec.9.2026.02.23.17.32.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Feb 2026 17:32:31 -0800 (PST) From: "Derek J. Clark" To: Jiri Kosina , Benjamin Tissoires Cc: Richard Hughes , Mario Limonciello , Zhixin Zhang , Mia Shao , Mark Pearson , "Pierre-Loup A . Griffais" , "Derek J . Clark" , linux-input@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 13/16] HID: hid-lenovo-go-s: Add Touchpad Mode Attributes Date: Tue, 24 Feb 2026 01:32:14 +0000 Message-ID: <20260224013217.1363996-14-derekjohn.clark@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260224013217.1363996-1-derekjohn.clark@gmail.com> References: <20260224013217.1363996-1-derekjohn.clark@gmail.com> Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Adds attributes for managing the touchpad operating modes. Reviewed-by: Mark Pearson Signed-off-by: Derek J. Clark --- drivers/hid/hid-lenovo-go-s.c | 142 ++++++++++++++++++++++++++++++++++ 1 file changed, 142 insertions(+) diff --git a/drivers/hid/hid-lenovo-go-s.c b/drivers/hid/hid-lenovo-go-s.c index 423b64cd02902..02d4e6548285e 100644 --- a/drivers/hid/hid-lenovo-go-s.c +++ b/drivers/hid/hid-lenovo-go-s.c @@ -47,6 +47,8 @@ struct hid_gos_cfg { u8 os_mode; u8 rgb_en; u8 tp_en; + u8 tp_linux_mode; + u8 tp_windows_mode; } drvdata; struct gos_cfg_attr { @@ -145,6 +147,22 @@ static const char *const dpad_mode_text[] = { [DIR4] = "4-way", }; +enum touchpad_mode_index { + TP_REL, + TP_ABS, +}; + +static const char *const touchpad_mode_text[] = { + [TP_REL] = "relative", + [TP_ABS] = "absolute", +}; + +enum touchpad_config_index { + CFG_WINDOWS_MODE = 0x03, + CFG_LINUX_MODE, + +}; + static int hid_gos_version_event(u8 *data) { struct version_report *ver_rep = (struct version_report *)data; @@ -204,6 +222,25 @@ static int hid_gos_gamepad_cfg_event(struct command_report *cmd_rep) return ret; } +static int hid_gos_touchpad_event(struct command_report *cmd_rep) +{ + int ret = 0; + + switch (cmd_rep->sub_cmd) { + case CFG_LINUX_MODE: + drvdata.tp_linux_mode = cmd_rep->data[0]; + break; + case CFG_WINDOWS_MODE: + drvdata.tp_windows_mode = cmd_rep->data[0]; + break; + default: + ret = -EINVAL; + break; + } + + return ret; +} + static int hid_gos_set_event_return(struct command_report *cmd_rep) { if (cmd_rep->data[0] != 0) @@ -251,7 +288,11 @@ static int hid_gos_raw_event(struct hid_device *hdev, struct hid_report *report, case GET_GAMEPAD_CFG: ret = hid_gos_gamepad_cfg_event(cmd_rep); break; + case GET_TP_PARAM: + ret = hid_gos_touchpad_event(cmd_rep); + break; case SET_GAMEPAD_CFG: + case SET_TP_PARAM: ret = hid_gos_set_event_return(cmd_rep); break; default: @@ -533,6 +574,95 @@ static ssize_t gamepad_property_options(struct device *dev, return count; } +static ssize_t touchpad_property_store(struct device *dev, + struct device_attribute *attr, + const char *buf, size_t count, + enum touchpad_config_index index) +{ + size_t size = 1; + u8 val = 0; + int ret; + + switch (index) { + case CFG_WINDOWS_MODE: + ret = sysfs_match_string(touchpad_mode_text, buf); + if (ret < 0) + return ret; + val = ret; + break; + case CFG_LINUX_MODE: + ret = sysfs_match_string(touchpad_mode_text, buf); + if (ret < 0) + return ret; + val = ret; + break; + default: + return -EINVAL; + } + if (!val) + size = 0; + + ret = mcu_property_out(drvdata.hdev, SET_TP_PARAM, index, &val, size); + if (ret < 0) + return ret; + + return count; +} + +static ssize_t touchpad_property_show(struct device *dev, + struct device_attribute *attr, char *buf, + enum touchpad_config_index index) +{ + int ret = 0; + u8 i; + + ret = mcu_property_out(drvdata.hdev, GET_TP_PARAM, index, 0, 0); + if (ret < 0) + return ret; + + switch (index) { + case CFG_WINDOWS_MODE: + i = drvdata.tp_windows_mode; + break; + case CFG_LINUX_MODE: + i = drvdata.tp_linux_mode; + break; + default: + return -EINVAL; + } + + if (i >= ARRAY_SIZE(touchpad_mode_text)) + return -EINVAL; + + return sysfs_emit(buf, "%s\n", touchpad_mode_text[i]); +} + +static ssize_t touchpad_property_options(struct device *dev, + struct device_attribute *attr, + char *buf, + enum touchpad_config_index index) +{ + size_t count = 0; + unsigned int i; + + switch (index) { + case CFG_WINDOWS_MODE: + case CFG_LINUX_MODE: + for (i = 0; i < ARRAY_SIZE(touchpad_mode_text); i++) { + count += sysfs_emit_at(buf, count, "%s ", + touchpad_mode_text[i]); + } + break; + default: + return count; + } + + if (count) + buf[count - 1] = '\n'; + + return count; +} + static ssize_t mcu_id_show(struct device *dev, struct device_attribute *attr, char *buf) { @@ -662,9 +792,21 @@ struct gos_cfg_attr touchpad_enabled = { FEATURE_TOUCHPAD_ENABLE }; LEGOS_DEVICE_ATTR_RW(touchpad_enabled, "enabled", index, gamepad); static DEVICE_ATTR_RO_NAMED(touchpad_enabled_index, "enabled_index"); +struct gos_cfg_attr touchpad_linux_mode = { CFG_LINUX_MODE }; +LEGOS_DEVICE_ATTR_RW(touchpad_linux_mode, "linux_mode", index, touchpad); +static DEVICE_ATTR_RO_NAMED(touchpad_linux_mode_index, "linux_mode_index"); + +struct gos_cfg_attr touchpad_windows_mode = { CFG_WINDOWS_MODE }; +LEGOS_DEVICE_ATTR_RW(touchpad_windows_mode, "windows_mode", index, touchpad); +static DEVICE_ATTR_RO_NAMED(touchpad_windows_mode_index, "windows_mode_index"); + static struct attribute *legos_touchpad_attrs[] = { &dev_attr_touchpad_enabled.attr, &dev_attr_touchpad_enabled_index.attr, + &dev_attr_touchpad_linux_mode.attr, + &dev_attr_touchpad_linux_mode_index.attr, + &dev_attr_touchpad_windows_mode.attr, + &dev_attr_touchpad_windows_mode_index.attr, NULL, }; -- 2.52.0