[PATCH] HID: intel-thc-hid: Set HID_PHYS with PCI BDF

[PATCH] HID: intel-thc-hid: Set HID_PHYS with PCI BDF

[Daniel Schaefer]

Currently HID_PHYS is empty, which means userspace tools (e.g. fwupd)
that depend on it for distinguishing the devices, are unable to do so.
Other drivers like i2c-hid, usbhid, surface-hid, all populate it.

With this change it's set to, for example: HID_PHYS=0000:00:10.0

Each function has just a single HID device, as far as I can tell, so
there is no need to add a suffix.

Tested with fwupd 2.1.1, can avoid https://github.com/fwupd/fwupd/pull/9995

Cc: Even Xu <even.xu@intel.com>
Cc: Xinpeng Sun <xinpeng.sun@intel.com>
Cc: Jiri Kosina <jikos@kernel.org>
Cc: Benjamin Tissoires <bentiss@kernel.org>
Cc: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Daniel Schaefer <git@danielschaefer.me>
---
 drivers/hid/intel-thc-hid/intel-quicki2c/quicki2c-hid.c | 1 +
 drivers/hid/intel-thc-hid/intel-quickspi/quickspi-hid.c | 1 +
 2 files changed, 2 insertions(+)

diff --git a/drivers/hid/intel-thc-hid/intel-quicki2c/quicki2c-hid.c b/drivers/hid/intel-thc-hid/intel-quicki2c/quicki2c-hid.c
index f9fcb398673b..8075992e8732 100644
--- a/drivers/hid/intel-thc-hid/intel-quicki2c/quicki2c-hid.c
+++ b/drivers/hid/intel-thc-hid/intel-quicki2c/quicki2c-hid.c
@@ -127,6 +127,7 @@ int quicki2c_hid_probe(struct quicki2c_device *qcdev)
 	hid->product = le16_to_cpu(qcdev->dev_desc.product_id);
 	snprintf(hid->name, sizeof(hid->name), "%s %04X:%04X", "quicki2c-hid",
 		 hid->vendor, hid->product);
+	strscpy(hid->phys, dev_name(qcdev->dev), sizeof(hid->phys));
 
 	ret = hid_add_device(hid);
 	if (ret) {
diff --git a/drivers/hid/intel-thc-hid/intel-quickspi/quickspi-hid.c b/drivers/hid/intel-thc-hid/intel-quickspi/quickspi-hid.c
index 82c72bfa2795..91d5807b4a83 100644
--- a/drivers/hid/intel-thc-hid/intel-quickspi/quickspi-hid.c
+++ b/drivers/hid/intel-thc-hid/intel-quickspi/quickspi-hid.c
@@ -118,6 +118,7 @@ int quickspi_hid_probe(struct quickspi_device *qsdev)
 	hid->product = le16_to_cpu(qsdev->dev_desc.product_id);
 	snprintf(hid->name, sizeof(hid->name), "%s %04X:%04X", "quickspi-hid",
 		 hid->vendor, hid->product);
+	strscpy(hid->phys, dev_name(qsdev->dev), sizeof(hid->phys));
 
 	ret = hid_add_device(hid);
 	if (ret) {
-- 
2.52.0

RE: [PATCH] HID: intel-thc-hid: Set HID_PHYS with PCI BDF

[Xu, Even]

> -----Original Message-----
> From: Daniel Schaefer <git@danielschaefer.me>
> Sent: Friday, March 13, 2026 9:39 PM
> To: linux-input@vger.kernel.org
> Cc: Daniel Schaefer <git@danielschaefer.me>; Xu, Even <even.xu@intel.com>;
> Sun, Xinpeng <xinpeng.sun@intel.com>; Jiri Kosina <jikos@kernel.org>; Benjamin
> Tissoires <bentiss@kernel.org>; Sakari Ailus <sakari.ailus@linux.intel.com>
> Subject: [PATCH] HID: intel-thc-hid: Set HID_PHYS with PCI BDF
> 
> Currently HID_PHYS is empty, which means userspace tools (e.g. fwupd) that
> depend on it for distinguishing the devices, are unable to do so.
> Other drivers like i2c-hid, usbhid, surface-hid, all populate it.
> 
> With this change it's set to, for example: HID_PHYS=0000:00:10.0
> 
> Each function has just a single HID device, as far as I can tell, so there is no need
> to add a suffix.
> 
> Tested with fwupd 2.1.1, can avoid https://github.com/fwupd/fwupd/pull/9995
> 
> Cc: Even Xu <even.xu@intel.com>
> Cc: Xinpeng Sun <xinpeng.sun@intel.com>
> Cc: Jiri Kosina <jikos@kernel.org>
> Cc: Benjamin Tissoires <bentiss@kernel.org>
> Cc: Sakari Ailus <sakari.ailus@linux.intel.com>
> Signed-off-by: Daniel Schaefer <git@danielschaefer.me>
> ---
>  drivers/hid/intel-thc-hid/intel-quicki2c/quicki2c-hid.c | 1 +  drivers/hid/intel-thc-
> hid/intel-quickspi/quickspi-hid.c | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/drivers/hid/intel-thc-hid/intel-quicki2c/quicki2c-hid.c
> b/drivers/hid/intel-thc-hid/intel-quicki2c/quicki2c-hid.c
> index f9fcb398673b..8075992e8732 100644
> --- a/drivers/hid/intel-thc-hid/intel-quicki2c/quicki2c-hid.c
> +++ b/drivers/hid/intel-thc-hid/intel-quicki2c/quicki2c-hid.c
> @@ -127,6 +127,7 @@ int quicki2c_hid_probe(struct quicki2c_device *qcdev)
>  	hid->product = le16_to_cpu(qcdev->dev_desc.product_id);
>  	snprintf(hid->name, sizeof(hid->name), "%s %04X:%04X", "quicki2c-hid",
>  		 hid->vendor, hid->product);
> +	strscpy(hid->phys, dev_name(qcdev->dev), sizeof(hid->phys));
> 
>  	ret = hid_add_device(hid);
>  	if (ret) {
> diff --git a/drivers/hid/intel-thc-hid/intel-quickspi/quickspi-hid.c
> b/drivers/hid/intel-thc-hid/intel-quickspi/quickspi-hid.c
> index 82c72bfa2795..91d5807b4a83 100644
> --- a/drivers/hid/intel-thc-hid/intel-quickspi/quickspi-hid.c
> +++ b/drivers/hid/intel-thc-hid/intel-quickspi/quickspi-hid.c
> @@ -118,6 +118,7 @@ int quickspi_hid_probe(struct quickspi_device *qsdev)
>  	hid->product = le16_to_cpu(qsdev->dev_desc.product_id);
>  	snprintf(hid->name, sizeof(hid->name), "%s %04X:%04X", "quickspi-hid",
>  		 hid->vendor, hid->product);
> +	strscpy(hid->phys, dev_name(qsdev->dev), sizeof(hid->phys));

Thanks for the patch!

Reviewed-by: Even Xu <even.xu@intel.com>

> 
>  	ret = hid_add_device(hid);
>  	if (ret) {
> --
> 2.52.0

Re: [PATCH] HID: intel-thc-hid: Set HID_PHYS with PCI BDF

[Jiri Kosina]

On Fri, 13 Mar 2026, Daniel Schaefer wrote:

> Currently HID_PHYS is empty, which means userspace tools (e.g. fwupd)
> that depend on it for distinguishing the devices, are unable to do so.
> Other drivers like i2c-hid, usbhid, surface-hid, all populate it.
> 
> With this change it's set to, for example: HID_PHYS=0000:00:10.0
> 
> Each function has just a single HID device, as far as I can tell, so
> there is no need to add a suffix.
> 
> Tested with fwupd 2.1.1, can avoid https://github.com/fwupd/fwupd/pull/9995
> 
> Cc: Even Xu <even.xu@intel.com>
> Cc: Xinpeng Sun <xinpeng.sun@intel.com>
> Cc: Jiri Kosina <jikos@kernel.org>
> Cc: Benjamin Tissoires <bentiss@kernel.org>
> Cc: Sakari Ailus <sakari.ailus@linux.intel.com>
> Signed-off-by: Daniel Schaefer <git@danielschaefer.me>

Applied to hid.git#for-7.0/upstream-fixes, thanks.

-- 
Jiri Kosina
SUSE Labs