From: Daniel Schaefer <dhs@frame.work>
To: linux-input@vger.kernel.org
Cc: Daniel Schaefer <dhs@frame.work>,
Charles Wang <charles.goodix@gmail.com>,
Jiri Kosina <jikos@kernel.org>,
Benjamin Tissoires <bentiss@kernel.org>
Subject: [PATCH 2/4] HID: goodix-spi: Use version_id for device version
Date: Sat, 14 Mar 2026 01:56:57 +0800 [thread overview]
Message-ID: <20260313175659.268094-3-dhs@frame.work> (raw)
In-Reply-To: <20260313175659.268094-1-dhs@frame.work>
Use version_id instead of bcd_version for hid->version. The HID
descriptor contains two version fields:
- bcd_version: HID specification version (e.g., 0x0100 for HID 1.0)
- version_id: Device-specific version number
The current code incorrectly uses bcd_version, which reports the HID
spec version rather than the actual device/firmware version.
Cc: Charles Wang <charles.goodix@gmail.com>
Cc: Jiri Kosina <jikos@kernel.org>
Cc: Benjamin Tissoires <bentiss@kernel.org>
Cc: linux-input@vger.kernel.org
Signed-off-by: Daniel Schaefer <dhs@frame.work>
---
drivers/hid/hid-goodix-spi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/hid-goodix-spi.c b/drivers/hid/hid-goodix-spi.c
index 80c0288a3a38..cbe95e0f6ce4 100644
--- a/drivers/hid/hid-goodix-spi.c
+++ b/drivers/hid/hid-goodix-spi.c
@@ -653,7 +653,7 @@ static int goodix_hid_init(struct goodix_ts_data *ts)
hid->bus = BUS_SPI;
hid->dev.parent = &ts->spi->dev;
- hid->version = le16_to_cpu(ts->hid_desc.bcd_version);
+ hid->version = le16_to_cpu(ts->hid_desc.version_id);
hid->vendor = le16_to_cpu(ts->hid_desc.vendor_id);
hid->product = le16_to_cpu(ts->hid_desc.product_id);
snprintf(hid->name, sizeof(hid->name), "%s %04X:%04X", "hid-gdix",
--
2.52.0
next prev parent reply other threads:[~2026-03-13 17:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-13 17:56 [PATCH 0/4] HID: Use wVersionID for device version Daniel Schaefer
2026-03-13 17:56 ` [PATCH 1/4] HID: i2c-hid: " Daniel Schaefer
2026-03-13 17:56 ` Daniel Schaefer [this message]
2026-03-13 17:56 ` [PATCH 3/4] HID: surface: Use device version instead of HID spec version Daniel Schaefer
2026-03-13 17:56 ` [PATCH 4/4] HID: core: Export device version via HID_FIRMWARE_VERSION uevent Daniel Schaefer
2026-03-13 17:59 ` Mario Limonciello
2026-03-13 18:20 ` Daniel Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260313175659.268094-3-dhs@frame.work \
--to=dhs@frame.work \
--cc=bentiss@kernel.org \
--cc=charles.goodix@gmail.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox