From: charles.embedded@gmail.com
To: Anshul Dalal <anshulusr@gmail.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Shuah Khan <shuah@kernel.org>,
Brigham Campbell <me@brighamcampbell.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Charles Dias <charlesdias.cd@outlook.com>
Subject: [PATCH 3/3] dt-bindings: input: adafruit-seesaw-gamepad: fix interrupt polarity
Date: Sat, 21 Mar 2026 17:24:46 -0300 [thread overview]
Message-ID: <20260321202446.724277-4-charles.embedded@gmail.com> (raw)
In-Reply-To: <20260321202446.724277-1-charles.embedded@gmail.com>
From: Charles Dias <charlesdias.cd@outlook.com>
The INT line is open-drain and asserts low on button GPIO changes, so
the binding should describe a falling-edge trigger rather than rising
edge. Also update the example to use IRQ_TYPE_EDGE_FALLING and add
interrupt-parent, and clarify that the driver can fall back to polling
when no IRQ is wired.
Signed-off-by: Charles Dias <charlesdias.cd@outlook.com>
---
.../bindings/input/adafruit,seesaw-gamepad.yaml | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/input/adafruit,seesaw-gamepad.yaml b/Documentation/devicetree/bindings/input/adafruit,seesaw-gamepad.yaml
index 5e86f6de6978..f0ebb326bf74 100644
--- a/Documentation/devicetree/bindings/input/adafruit,seesaw-gamepad.yaml
+++ b/Documentation/devicetree/bindings/input/adafruit,seesaw-gamepad.yaml
@@ -25,6 +25,11 @@ description: |
SE -> Select
X, A, B, Y -> Digital action buttons
+ The gamepad exposes button events through the seesaw GPIO block and joystick
+ axes through the seesaw ADC block. If the optional IRQ pin is wired, button
+ presses can be interrupt-driven while joystick axes remain polled. Without an
+ IRQ, the driver falls back to fully polled operation.
+
Datasheet: https://cdn-learn.adafruit.com/downloads/pdf/gamepad-qt.pdf
Product page: https://www.adafruit.com/product/5743
Arduino Driver: https://github.com/adafruit/Adafruit_Seesaw
@@ -39,7 +44,9 @@ properties:
interrupts:
maxItems: 1
description:
- The gamepad's IRQ pin triggers a rising edge if interrupts are enabled.
+ Optional interrupt from the gamepad's open-drain INT pin. The device
+ asserts INT low on button GPIO changes when interrupts are enabled in the
+ seesaw firmware, so the host should typically use a falling-edge trigger.
required:
- compatible
@@ -57,7 +64,8 @@ examples:
joystick@50 {
compatible = "adafruit,seesaw-gamepad";
- interrupts = <18 IRQ_TYPE_EDGE_RISING>;
+ interrupt-parent = <&gpio1>;
+ interrupts = <18 IRQ_TYPE_EDGE_FALLING>;
reg = <0x50>;
};
};
prev parent reply other threads:[~2026-03-21 20:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-21 20:24 [PATCH 0/3] Input: adafruit-seesaw: use dev_err_probe and add IRQ support charles.embedded
2026-03-21 20:24 ` [PATCH 1/3] Input: adafruit-seesaw - switch to using dev_err_probe() charles.embedded
2026-03-21 20:24 ` [PATCH 2/3] Input: adafruit-seesaw - add interrupt support charles.embedded
2026-03-23 5:12 ` Dmitry Torokhov
2026-03-24 13:59 ` Charles Dias
2026-03-21 20:24 ` charles.embedded [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260321202446.724277-4-charles.embedded@gmail.com \
--to=charles.embedded@gmail.com \
--cc=anshulusr@gmail.com \
--cc=charlesdias.cd@outlook.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=me@brighamcampbell.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox