From: Bjorn Helgaas <helgaas@kernel.org>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Bjorn Helgaas <bhelgaas@google.com>,
"open list:HID CORE LAYER" <linux-input@vger.kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Subject: Re: [PATCH 1/2] input: pc110pad: change PCI check to get rid of orphaned no_pci_devices
Date: Mon, 6 Apr 2026 12:23:24 -0500 [thread overview]
Message-ID: <20260406172324.GA170281@bhelgaas> (raw)
In-Reply-To: <cf519463-775a-4d43-be38-20742fdad407@gmail.com>
On Fri, Apr 03, 2026 at 12:17:35AM +0200, Heiner Kallweit wrote:
> As a prerequisite for removing no_pci_devices(), replace its usage here
> with an equivalent check for presence of a PCI bus.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
> drivers/input/mouse/pc110pad.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/mouse/pc110pad.c b/drivers/input/mouse/pc110pad.c
> index efa58049f..c7a6df210 100644
> --- a/drivers/input/mouse/pc110pad.c
> +++ b/drivers/input/mouse/pc110pad.c
> @@ -91,7 +91,7 @@ static int __init pc110pad_init(void)
> {
> int err;
>
> - if (!no_pci_devices())
> + if (pci_find_next_bus(NULL))
> return -ENODEV;
I'd certainly love to get rid of no_pci_devices(), although using
pci_find_next_bus() is not really much better.
I don't have much opinion about pc110pad.c change. It's essentially
still the same kludge, which has been there at least since the
beginning of git history.
Dmitry, if you want to ack this, I can take both together.
Bjorn
next prev parent reply other threads:[~2026-04-06 17:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-02 22:15 [PATCH 0/2] PCI: Remove no_pci_devices Heiner Kallweit
2026-04-02 22:17 ` [PATCH 1/2] input: pc110pad: change PCI check to get rid of orphaned no_pci_devices Heiner Kallweit
2026-04-06 17:23 ` Bjorn Helgaas [this message]
2026-04-06 19:02 ` Dmitry Torokhov
2026-04-02 22:18 ` [PATCH 2/2] PCI: Remove no_pci_devices Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260406172324.GA170281@bhelgaas \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=dmitry.torokhov@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox