public inbox for linux-input@vger.kernel.org
 help / color / mirror / Atom feed
From: Anj Duvnjak <avian@extremenerds.net>
To: linux-input@vger.kernel.org
Cc: benjamin.tissoires@redhat.com, lee@kernel.org, jikos@kernel.org,
	Anj Duvnjak <avian@extremenerds.net>,
	Oleksandr Natalenko <oleksandr@natalenko.name>
Subject: [PATCH v2] HID: core: downgrade short report warning to debug level
Date: Wed, 15 Apr 2026 09:00:17 +1000	[thread overview]
Message-ID: <20260414230017.30217-1-avian@extremenerds.net> (raw)

Commit 0a3fe972a7cb ("HID: core: Mitigate potential OOB by removing bogus
memset()") replaced the silent memset() with hid_warn_ratelimited(), which
causes dmesg flooding on devices that legitimately send short reports,
such as the APC UPS (051D:0002).

Downgrade to hid_dbg_ratelimited() to restore the previous behaviour of
only reporting under HID_DEBUG, while preserving the security fix of
removing the bogus memset() and keeping rate limiting in place.

Fixes: 0a3fe972a7cb14 ("HID: core: Mitigate potential OOB by removing bogus memset()")
Reported-by: Anj Duvnjak <avian@extremenerds.net>
Link: https://lore.kernel.org/linux-input/MW5PR84MB135613E7947113897DD9FDA4C7272@MW5PR84MB1356.NAMPRD84.PROD.OUTLOOK.COM/
Reported-by: Oleksandr Natalenko <oleksandr@natalenko.name>
Link: https://lore.kernel.org/linux-input/6256259.lOV4Wx5bFT@natalenko.name/
Signed-off-by: Anj Duvnjak <avian@extremenerds.net>
---
 drivers/hid/hid-core.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
index 833df14ef68f..f30091509517 100644
--- a/drivers/hid/hid-core.c
+++ b/drivers/hid/hid-core.c
@@ -2057,8 +2057,8 @@ int hid_report_raw_event(struct hid_device *hid, enum hid_report_type type, u8 *
 		rsize = max_buffer_size;
 
 	if (csize < rsize) {
-		hid_warn_ratelimited(hid, "Event data for report %d was too short (%d vs %d)\n",
-				     report->id, rsize, csize);
+		hid_dbg_ratelimited(hid, "Event data for report %d was too short (%d vs %d)\n",
+				    report->id, rsize, csize);
 		ret = -EINVAL;
 		goto out;
 	}
-- 
2.46.4


             reply	other threads:[~2026-04-14 23:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-14 23:00 Anj Duvnjak [this message]
2026-04-15  7:42 ` [PATCH v2] HID: core: downgrade short report warning to debug level Oleksandr Natalenko
2026-04-16 14:44 ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260414230017.30217-1-avian@extremenerds.net \
    --to=avian@extremenerds.net \
    --cc=benjamin.tissoires@redhat.com \
    --cc=jikos@kernel.org \
    --cc=lee@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=oleksandr@natalenko.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox