From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D137E39E164 for ; Sat, 9 May 2026 10:11:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778321486; cv=none; b=VMSYCgazTMp2AVJx8Jzpan5uB9T+axnEocYJllw2rB2UhZ+ZTY0/8hMfLCO0+wC/SK5HzHa++n9+dqnZQapXo8q9k87hBmycbb3DVceIpxUDoFmI8Qy75BTujTY7jhNMtTCKB6WIjimJcRx2IMsDt+RcRpjCGMEQFPJb0yPijfQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778321486; c=relaxed/simple; bh=/ypM8gwlCiAeCIMJp+GRH1JKDXxEaGiFEs725h5oIl8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Qe7CYZGKg1TrpPenwoAJaru1OWT4Kex3DWRdorSt5jMrYQcd61jST0QUXKjkT/4vZuOSb+wBGQxkD2Yoha7spDBBSY06SFll/rY0yUS4lCUrsGuBAP25J+3/4kjpiYnnbF8AC5EHlIDcgsy3ODGXGd4wcMpkY2613rJhE4svyro= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ku0O9Kab; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ku0O9Kab" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-2ba928852a5so19053765ad.1 for ; Sat, 09 May 2026 03:11:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778321484; x=1778926284; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YxEj5NvBAWz6r+Pm4CowXogfvDTiNULt7IFl/LWJs1M=; b=ku0O9KabwFNfEXhEDmk4E5umbV+EVBGQybz+RG5IRB961Bt/uhVCgb1iFurwzxqXwi 6rB8nxIzfp48jn7JCo0biv5sCJBHWHnbuCpKjzBn/0EPtEvlhXvdJQxlLLNC4s1oFx+q CvAbf8Ptv0yNSd8EggetIKklX4cZEuyh1dzc+iNvsDyOSqVe6/mtawIBCAD9PA1VBq7y MOxkPGntyzlCZB8YkHYl9Y1TC+K3WcKzxi/3OmvFGl7Wg338RbCkIQR5wbqNdGoTqBCr 05UpS/oh+ZzELhToE88oFwGuEbViqznxYZnXG0rKVznimYGljigIXNQ2wKFk9YysCEKG 2HSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778321484; x=1778926284; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=YxEj5NvBAWz6r+Pm4CowXogfvDTiNULt7IFl/LWJs1M=; b=nQDO/cqC/lj6FG24drsPIl/zdw30gP+q7GoCkMrzmbwpYGYNfr2u861bOcmRUBE2tz fTng4jcy5BUiIxmzAYvyQZ/hGLCgl7Dv+cNPRnnaRY1LwyMg5Ov4KKYdABECbgETegp7 Lf5SMPPWoau7sDJCt7xh+l1Cp5fkd5TBqerDbo6WHRpwSP2I5r3t4Fww+BGDhc7/zajR FWp0VuOMbtpAirbIdRx9gSdAM3OZvXZkr/M9jHgNCuorHEkOv61MCtnYCk/oUKoqcYPJ emet1k0HOWh3FOM+kRl+Mk+Ep3QNrNNfDcqhzeyh9hMv9gMyMFkFvCM6Psd6Y4nWtGwS gMGg== X-Forwarded-Encrypted: i=1; AFNElJ/5eQCXxZns/HxojM05s1EpGqKzRNUJVfXp5iVZFQl4xJDh02+erz85Ywn3PHV+h/oikCiq5U7Ud1tTfg==@vger.kernel.org X-Gm-Message-State: AOJu0YzLuFCb1nbrYzVu/KnsQi6odsQ+cxCVBWL3UZxW31sRLm8+MoZ2 0GGkS1AS+Bkw7iXP8rhtAQfRQpMymuaReFNwBu4ScmBLn4YoMwBr2+XR X-Gm-Gg: Acq92OHnH33TI1nPvEG+e5j6wml3Vvu5zEFs0x6wIbQJK0Ndz6kLUOvc2h7x/NSWvc0 nUDytzMc2M2qXkL9UQY0al3sLhyVoUgBJ/lVEfFv9LmUn5cj4H6boCdiVcu3iS5Iacr+ovHnASp wIOxoxWLmrpsc3bj/qSCe1WDrUzWfAmjTlKRHd0zzsGbhGX0eYFQcoB7uKr/fOqBzh7QumVE+fb fCKjsJvVoYJkfq2pvt3+mcylQ79oMaaj0nmUKvcpMPtPbZoLEOBDbiJHEl2Eq1S/yeNk6zjnxjC VPbLIp0xbbrYCU07+uCwSyQZOa/09AiSWTHcNGwJQe8JLeZMXY1ymKorIpJ9EVZhoIS4CIgZH69 HCP/f1zA7QHDow0hm4nJTrH3Dn8jMAPkl5BoKTZyWKmM6zFM/EuclqSka46MJoJbvBAjTSJ8FHH FBmJuEMcV2BzQMo0TWuoGHHEdoufX6+MxUApufZlNQ+nihC7A7 X-Received: by 2002:a17:902:d588:b0:2b9:cd2d:6f13 with SMTP id d9443c01a7336-2bc7a9a62ccmr21182805ad.10.1778321484030; Sat, 09 May 2026 03:11:24 -0700 (PDT) Received: from hu-ckantibh-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2baf1e83084sm47335365ad.61.2026.05.09.03.11.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 May 2026 03:11:23 -0700 (PDT) From: Sanjay Chitroda X-Google-Original-From: Sanjay Chitroda To: jikos@kernel.org, jic23@kernel.org, srinivas.pandruvada@linux.intel.com Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, sanjayembeddedse@gmail.com, sakari.ailus@linux.intel.com, linux-input@vger.kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 9/9] iio: humidity: hid-sensor-humidity: drop hid_sensor_remove_trigger() using devm API Date: Sat, 9 May 2026 15:40:40 +0530 Message-Id: <20260509101040.791404-10-sanjayembedded@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260509101040.791404-1-sanjayembedded@gmail.com> References: <20260509101040.791404-1-sanjayembedded@gmail.com> Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Sanjay Chitroda Use devm_hid_sensor_setup_trigger() to automatically release resources during failure, unbind or removal of driver using devres framework. This is done in a way to simplify the setup, remove goto and avoid manual resource cleanup in teardown path. Signed-off-by: Sanjay Chitroda --- changes in v3: - Update commit message based on review comment from Andy - Based on discussion using parent device of HID platform driver used with devres framework for this driver - v2 link -> https://lore.kernel.org/all/20260429175918.2541914-5-sanjayembedded@gmail.com/ --- drivers/iio/humidity/hid-sensor-humidity.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/iio/humidity/hid-sensor-humidity.c b/drivers/iio/humidity/hid-sensor-humidity.c index d310ec43a118..4d4282e4b6e4 100644 --- a/drivers/iio/humidity/hid-sensor-humidity.c +++ b/drivers/iio/humidity/hid-sensor-humidity.c @@ -234,8 +234,8 @@ static int hid_humidity_probe(struct platform_device *pdev) atomic_set(&humid_st->common_attributes.data_ready, 0); - ret = hid_sensor_setup_trigger(indio_dev, name, - &humid_st->common_attributes); + ret = devm_hid_sensor_setup_trigger(dev, indio_dev, name, + &humid_st->common_attributes); if (ret) return ret; @@ -245,7 +245,7 @@ static int hid_humidity_probe(struct platform_device *pdev) ret = sensor_hub_register_callback(hsdev, HID_USAGE_SENSOR_HUMIDITY, &humidity_callbacks); if (ret) - goto error_remove_trigger; + return ret; ret = iio_device_register(indio_dev); if (ret) @@ -255,8 +255,6 @@ static int hid_humidity_probe(struct platform_device *pdev) error_remove_callback: sensor_hub_remove_callback(hsdev, HID_USAGE_SENSOR_HUMIDITY); -error_remove_trigger: - hid_sensor_remove_trigger(&humid_st->common_attributes); return ret; } @@ -265,11 +263,9 @@ static void hid_humidity_remove(struct platform_device *pdev) { struct hid_sensor_hub_device *hsdev = dev_get_platdata(&pdev->dev); struct iio_dev *indio_dev = platform_get_drvdata(pdev); - struct hid_humidity_state *humid_st = iio_priv(indio_dev); iio_device_unregister(indio_dev); sensor_hub_remove_callback(hsdev, HID_USAGE_SENSOR_HUMIDITY); - hid_sensor_remove_trigger(&humid_st->common_attributes); } static const struct platform_device_id hid_humidity_ids[] = { -- 2.34.1