From: Sanjay Chitroda <sanjayembeddedse@gmail.com>
To: jikos@kernel.org, jic23@kernel.org, srinivas.pandruvada@linux.intel.com
Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org,
sanjayembeddedse@gmail.com, sakari.ailus@linux.intel.com,
linux-input@vger.kernel.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v4 22/36] iio: orientation: hid-sensor-rotation: use local struct device
Date: Mon, 25 May 2026 00:58:05 +0530 [thread overview]
Message-ID: <20260524192812.1196549-3-sanjayembedded@gmail.com> (raw)
In-Reply-To: <20260524192812.1196549-1-sanjayembedded@gmail.com>
From: Sanjay Chitroda <sanjayembeddedse@gmail.com>
Introduce a local struct device pointer derived from &pdev->dev.
This avoids repeated &pdev->dev usage and improves readability.
Signed-off-by: Sanjay Chitroda <sanjayembeddedse@gmail.com>
---
drivers/iio/orientation/hid-sensor-rotation.c | 22 +++++++++----------
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/iio/orientation/hid-sensor-rotation.c b/drivers/iio/orientation/hid-sensor-rotation.c
index 20563d8efaf6..332d56757679 100644
--- a/drivers/iio/orientation/hid-sensor-rotation.c
+++ b/drivers/iio/orientation/hid-sensor-rotation.c
@@ -243,6 +243,7 @@ static int dev_rot_parse_report(struct platform_device *pdev,
u32 usage_id,
struct dev_rot_state *st)
{
+ struct device *dev = &pdev->dev;
int ret;
ret = sensor_hub_input_get_attribute_info(hsdev,
@@ -253,11 +254,10 @@ static int dev_rot_parse_report(struct platform_device *pdev,
if (ret)
return ret;
- dev_dbg(&pdev->dev, "dev_rot %x:%x\n", st->quaternion.index,
+ dev_dbg(dev, "dev_rot %x:%x\n", st->quaternion.index,
st->quaternion.report_id);
- dev_dbg(&pdev->dev, "dev_rot: attrib size %d\n",
- st->quaternion.size);
+ dev_dbg(dev, "dev_rot: attrib size %d\n", st->quaternion.size);
st->scale_precision = hid_sensor_format_scale(
hsdev->usage,
@@ -270,14 +270,14 @@ static int dev_rot_parse_report(struct platform_device *pdev,
/* Function to initialize the processing for usage id */
static int hid_dev_rot_probe(struct platform_device *pdev)
{
- struct hid_sensor_hub_device *hsdev = dev_get_platdata(&pdev->dev);
+ struct device *dev = &pdev->dev;
+ struct hid_sensor_hub_device *hsdev = dev_get_platdata(dev);
int ret;
char *name;
struct iio_dev *indio_dev;
struct dev_rot_state *rot_state;
- indio_dev = devm_iio_device_alloc(&pdev->dev,
- sizeof(struct dev_rot_state));
+ indio_dev = devm_iio_device_alloc(dev, sizeof(struct dev_rot_state));
if (indio_dev == NULL)
return -ENOMEM;
@@ -307,13 +307,13 @@ static int hid_dev_rot_probe(struct platform_device *pdev)
rotation_sensitivity_addresses,
ARRAY_SIZE(rotation_sensitivity_addresses));
if (ret) {
- dev_err(&pdev->dev, "failed to setup common attributes\n");
+ dev_err(dev, "failed to setup common attributes\n");
return ret;
}
ret = dev_rot_parse_report(pdev, hsdev, hsdev->usage, rot_state);
if (ret) {
- dev_err(&pdev->dev, "failed to setup attributes\n");
+ dev_err(dev, "failed to setup attributes\n");
return ret;
}
@@ -328,13 +328,13 @@ static int hid_dev_rot_probe(struct platform_device *pdev)
ret = hid_sensor_setup_trigger(indio_dev, name,
&rot_state->common_attributes);
if (ret) {
- dev_err(&pdev->dev, "trigger setup failed\n");
+ dev_err(dev, "trigger setup failed\n");
return ret;
}
ret = iio_device_register(indio_dev);
if (ret) {
- dev_err(&pdev->dev, "device register failed\n");
+ dev_err(dev, "device register failed\n");
goto error_remove_trigger;
}
@@ -344,7 +344,7 @@ static int hid_dev_rot_probe(struct platform_device *pdev)
ret = sensor_hub_register_callback(hsdev, hsdev->usage,
&rot_state->callbacks);
if (ret) {
- dev_err(&pdev->dev, "callback reg failed\n");
+ dev_err(dev, "callback reg failed\n");
goto error_iio_unreg;
}
--
2.34.1
next prev parent reply other threads:[~2026-05-24 19:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-24 19:28 [PATCH v4 20/36] iio: magnetometer: hid-sensor-magn-3d: use local struct device Sanjay Chitroda
2026-05-24 19:28 ` [PATCH v4 21/36] iio: orientation: hid-sensor-incl-3d: " Sanjay Chitroda
2026-05-24 19:28 ` Sanjay Chitroda [this message]
2026-05-24 19:28 ` [PATCH v4 23/36] iio: position: hid-sensor-custom-intel-hinge: " Sanjay Chitroda
2026-05-24 19:28 ` [PATCH v4 24/36] iio: pressure: hid-sensor-press: " Sanjay Chitroda
2026-05-24 19:28 ` [PATCH v4 25/36] iio: hid-sensors: remove unused iio_dev argument Sanjay Chitroda
2026-05-24 19:28 ` [PATCH v4 26/36] iio: hid-sensors: introduce device managed API Sanjay Chitroda
2026-05-24 19:28 ` [PATCH v4 27/36] iio: gyro: hid-sensor-gyro-3d: drop hid_sensor_remove_trigger() using devm API Sanjay Chitroda
2026-05-24 19:28 ` [PATCH v4 28/36] iio: humidity: hid-sensor-humidity: " Sanjay Chitroda
2026-05-24 19:28 ` [PATCH v4 29/36] iio: light: hid-sensor-prox: " Sanjay Chitroda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260524192812.1196549-3-sanjayembedded@gmail.com \
--to=sanjayembeddedse@gmail.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=jikos@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=sakari.ailus@linux.intel.com \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox