Re: [PATCH 05/10] [v2] mips: select legacy gpiolib interfaces where used

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] Duplicate `select GPIOLIB` in `config MIPS_ALCHEMY`.
- [Low] Unnecessary `select GPIOLIB_LEGACY` for `config MIKROTIK_RB532`.
--

commit 0726793f1a39f1a0b2ac5d24243bcbe5e8999b93
Author: Arnd Bergmann <arnd@arndb.de>

mips: select legacy gpiolib interfaces where used

This commit updates several old mips machines that have not been converted
away from the old-style gpiolib interfaces to select CONFIG_GPIOLIB_LEGACY.
This ensures the legacy code continues to work where needed but can be
omitted otherwise.

> diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> index 4364f3dba688f..b91e62d69a5db 100644
> --- a/arch/mips/Kconfig
> +++ b/arch/mips/Kconfig
> @@ -206,6 +206,8 @@ config MIPS_ALCHEMY
>  	select CSRC_R4K
>  	select IRQ_MIPS_CPU
>  	select DMA_NONCOHERENT		# Au1000,1500,1100 aren't, rest is
> +	select GPIOLIB
> +	select GPIOLIB_LEGACY

[Severity: Low]
Is this select GPIOLIB a duplicate? It appears select GPIOLIB is already
present further down in the MIPS_ALCHEMY block.

>  	select MIPS_FIXUP_BIGPHYS_ADDR if PCI
>  	select SYS_HAS_CPU_MIPS32_R1
>  	select SYS_SUPPORTS_32BIT_KERNEL

[ ... ]

> @@ -999,6 +1003,7 @@ config MIKROTIK_RB532
>  	select SWAP_IO_SPACE
>  	select BOOT_RAW
>  	select GPIOLIB
> +	select GPIOLIB_LEGACY

[Severity: Low]
Does this select GPIOLIB_LEGACY introduce an unnecessary dependency for
MIKROTIK_RB532? A look at the code indicates that MIKROTIK_RB532 and its
associated drivers (like pata_rb532_cf and rb532_button) use the modern
descriptor-based gpiod API and do not seem to call the legacy GPIO functions.
Could this dependency be omitted so we don't compile legacy interfaces
unnecessarily?

>  	select MIPS_L1_CACHE_SHIFT_4
>  	help

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260520183815.2510387-1-arnd@kernel.org?part=5