From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB6C2233D9E; Sat, 30 May 2026 18:22:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780165334; cv=none; b=OEQaNgqbgGDF3zz7Ok1UWC/sc2f9FUTrdMdwM0trZlPKvoy0Lv5zmLTV+ji2qbEUGufETUUgQorzettxhPpaq6FxBvv6o3Ir8rvVz3e6OuwnctJdZ1sP6nxHSyBgtxBwihpf/l9F2BbsTIxQLD5MBycXn0NlErC+C6DIM+rPpJY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780165334; c=relaxed/simple; bh=s2chxEqMOvUAIzDSMlBDpnI3eYl7P65jOoMDF48TDaA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ND2ccQDU36V0cpyQYtj3aYMFrY9ZdkTPM3YEginhQG+6vZv5tvXjyIueSumQLaAnyCXilvYa/bUd7bhivg4tczTN9befRagLCq5vFdlM3kvdUWua1dktDHDNFWsWu7IiC2Mt+dRPvGYsDUxClqYfYCZvrOzA84Ya83e+O6xxMdc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=2I9NJMGv; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="2I9NJMGv" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2945B1F00893; Sat, 30 May 2026 18:22:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1780165333; bh=me4DghIrPRAPac8SN0ZEe07vkP5zu0I9lMSPj/BAbYo=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=2I9NJMGvpP7R0JnPvbnIIeT+mJOLNtT41WbdeQVYHbIo9QMtFZjHYS6ebDAK9N2HW n888QNQ9/3O2OLk9vPH3dZGxFGybqkQNcRIMvBcW7+m7+rpX69QhgaXvXuWpgA46gs umA+6vIgFe0yEfK5BvLO7/TEJgRjTYfqsDtEPl6o= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, stable , Jiri Kosina , Benjamin Tissoires , linux-input@vger.kernel.org, Jiri Kosina Subject: [PATCH 5.10 048/589] HID: core: clamp report_size in s32ton() to avoid undefined shift Date: Sat, 30 May 2026 17:58:49 +0200 Message-ID: <20260530160225.854423750@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260530160224.570625122@linuxfoundation.org> References: <20260530160224.570625122@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Greg Kroah-Hartman commit 69c02ffde6ed4d535fa4e693a9e572729cad3d0d upstream. s32ton() shifts by n-1 where n is the field's report_size, a value that comes directly from a HID device. The HID parser bounds report_size only to <= 256, so a broken HID device can supply a report descriptor with a wide field that triggers shift exponents up to 256 on a 32-bit type when an output report is built via hid_output_field() or hid_set_field(). Commit ec61b41918587 ("HID: core: fix shift-out-of-bounds in hid_report_raw_event") added the same n > 32 clamp to the function snto32(), but s32ton() was never given the same fix as I guess syzbot hadn't figured out how to fuzz a device the same way. Fix this up by just clamping the max value of n, just like snto32() does. Cc: stable Cc: Jiri Kosina Cc: Benjamin Tissoires Cc: linux-input@vger.kernel.org Assisted-by: gregkh_clanker_t1000 Signed-off-by: Greg Kroah-Hartman Signed-off-by: Jiri Kosina Signed-off-by: Greg Kroah-Hartman --- drivers/hid/hid-core.c | 3 +++ 1 file changed, 3 insertions(+) --- a/drivers/hid/hid-core.c +++ b/drivers/hid/hid-core.c @@ -1354,6 +1354,9 @@ static u32 s32ton(__s32 value, unsigned if (!value || !n) return 0; + if (n > 32) + n = 32; + a = value >> (n - 1); if (a && a != -1) return value < 0 ? 1 << (n - 1) : (1 << (n - 1)) - 1;