From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DE88D342C8B for ; Mon, 1 Jun 2026 13:41:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780321292; cv=none; b=FwAxb6mjG1vtTfJDJic+I1sTJ94MBP/JUDwvys1OtrHUq+Qh7ylQhJ3fYDyFYoSl0mQrL3r8KG+NFQfCCSlSlkyoqjWxISRXQS+a/+ZV5ybO1sOFU4MXE/uN+VZQxClphjZ3q/JlVtdrGi76OrV1vj/ZgTwRKbhNca5L1pKoE1E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780321292; c=relaxed/simple; bh=0YLDz12FA6XVOzJeLn1d/oNTWjkdfsbZbtXn3imJwLo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=fzdyoA4M6lnPPUbrk298GXnpDp6w3eOfymQNzv2cz1hx1A3KPbfhtgBUvTwT/Kf55NQsHQA0RUZh2z+t4sSNmtxZZk9y0bydTUK/Vm3zy+qxDTyNJtFkmSIZw72cr8ND14jMPcW3lw8Eo/xGCVOtQMM9Za5tUdh9LZ6h8UzK2m0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IMk+YF7f; arc=none smtp.client-ip=209.85.216.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IMk+YF7f" Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-36b9ec98144so2548526a91.1 for ; Mon, 01 Jun 2026 06:41:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780321290; x=1780926090; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BE1QCAtAhg6sEZEseBz/loTBnTwntzM+QrWDys0rps4=; b=IMk+YF7fg3SVGEGzPHELBq/jc2sutMZbqHo9SMaly9ZZCbX99gwmAxXjbHvZfvTnC3 NMShzFGg7tI+l0hSKzd4E1K3iwwEr+270tIEWsRR+XJfYn5IFi8zKxieRTItYV9TPlk0 xwAW2IdfyAtWMIMwOQXNHC8EMy3j35fHDg4ZMg8yIp/CMBq6ptUlJaiKxzfHfvNKw6ra lJEptbVFGDI3mr7sR+mj+UBgiVn5W7q5jYyAu+HaeBvMnqeUAd8p2sARjNWjcyERXqMt zOAZ+Cgs8PuGgb66Uzjh0ql46oQXGoZGHVYTthA8OoYvJs9RyVdLrQG0OtQpmDJDhrsd Gvbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780321290; x=1780926090; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=BE1QCAtAhg6sEZEseBz/loTBnTwntzM+QrWDys0rps4=; b=C7guHRxSgeTPXr7zOMyBYMmfjOicVjaxwNH2pIUyj8gRJQyPb8h9snUZ5LZ7xIli5C AnpSDxgFkscvd8w1EBa6TN7QeGBAqWiIl+Ls35TcumW0YJcMlZqVFEeJpwoo94wcuLlH CJfNw8T9koFHgaQBeN53yWcjrwGtBZsrix1I/ykJ/mCxFdOahmR02PJpzu7KKvnt3VdZ f5YKniS6tkV/1qjwAkWunjmejcER4AkvaSvf77B7owrcUiG034wZdvjdNv57oBrEi/Py xuie2+np7D2Gt4QvbZONxyrC1+jc27oXyb7iRkpORKeYlxR8OVO1/FqFKOrOYy/Nei2Q 3RjQ== X-Gm-Message-State: AOJu0YyU5MS+V+8GRV8nHc6BVEGjEG0xGewbB9ExGbo0t0oWVRlSwlSJ mdLYFkIch+Qq6/HpxyWutj1vBcJRtj6iUa3zYr454swYpuGIiYP0Vd8hqDpW3njLAEE7HQ== X-Gm-Gg: Acq92OEpWksa9YpLj1pshCyT+h85YS6afJIjcCKFHTc4Rr2lZDmObAiIHt766uAl265 MDmTImSqBxIq2LYSy3KAoouNp8JGxX08Sc4JlSlvP9LIafCFpQK2NrCU9Nl+dtyYwkxQal6WMZi LppEMWFpfcbmdViTlFlt8DZ57DBPoTlxcQYk5V6b22O8ucAvcO3iprAIFxId0xUmAa75RL9OHz3 34gNrr1fMcUQ8MtpSv38hhtBkaHhddEEPGjN4cuiiMj3XOLX3h1KFPTHtKSzSShtx369SLw9zMk b0uiCO1lti8FRVV3cJJBnGQiBMMXENWTq9MfxocBeWJHCa5UkwiNZHeCtjYNscGNb7Y5D3gW6A4 o2esNWJCUs25mavjmMiX6gZnp12cX4JwFDIdEZkYGZEuUo4NE7oZWD1doWlRvrixSD0j4GNxIdS hTQ894N0PmJHRYZrIA1O9lcTwQojMZ5HeZYD6ZnZQYpplpfCNZf/Jwqz0P2M8= X-Received: by 2002:a17:90b:4a91:b0:36c:689c:a4c9 with SMTP id 98e67ed59e1d1-36c689cb2efmr10479463a91.21.1780321288984; Mon, 01 Jun 2026 06:41:28 -0700 (PDT) Received: from jmoon ([118.220.156.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36bc65e8490sm11496959a91.3.2026.06.01.06.41.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jun 2026 06:41:28 -0700 (PDT) From: Jinmo Yang To: linux-input@vger.kernel.org, dmitry.torokhov@gmail.com Cc: jikos@kernel.org, benjamin.tissoires@redhat.com, stable@vger.kernel.org, jinmo44.yang@gmail.com, Sashiko-bot Subject: [PATCH v2 1/2] HID: wacom: use GFP_ATOMIC in wacom_wac_queue_flush() Date: Mon, 1 Jun 2026 22:41:23 +0900 Message-ID: <20260601134124.1560886-2-jinmo44.yang@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260601134124.1560886-1-jinmo44.yang@gmail.com> References: <20260601134124.1560886-1-jinmo44.yang@gmail.com> Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit wacom_wac_queue_flush() is called via the .raw_event callback (wacom_raw_event → wacom_wac_pen_serial_enforce → wacom_wac_queue_flush). For USB HID devices, this callback is invoked from hid_irq_in(), which is a URB completion handler running in atomic context. Using GFP_KERNEL in this path can sleep, leading to a "scheduling while atomic" bug. Use GFP_ATOMIC instead. The existing code already handles allocation failure by skipping the fifo entry and continuing. Reported-by: Sashiko-bot Fixes: 5e013ad20689 ("HID: wacom: Remove static WACOM_PKGLEN_MAX limit") Cc: stable@vger.kernel.org Reviewed-by: Dmitry Torokhov Signed-off-by: Jinmo Yang --- drivers/hid/wacom_sys.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/wacom_sys.c b/drivers/hid/wacom_sys.c index a32320b35..2e237bdd2 100644 --- a/drivers/hid/wacom_sys.c +++ b/drivers/hid/wacom_sys.c @@ -74,7 +74,7 @@ static void wacom_wac_queue_flush(struct hid_device *hdev, unsigned int count; int err; - buf = kzalloc(size, GFP_KERNEL); + buf = kzalloc(size, GFP_ATOMIC); if (!buf) { kfifo_skip(fifo); continue; -- 2.53.0