Re: [PATCH 7/8] dt-bindings: input: microchip,cap11xx: Add CAP1114 support

[Jun Yan <jerrysteve1101@gmail.com>]

> On Tue, Jun 09, 2026 at 10:08:27PM +0800, Jun Yan wrote:
> > > On Sat, Jun 06, 2026 at 11:04:00PM +0800, Jun Yan wrote:
> > > > CAP1114 is a 14-channel capacitive touch sensor with 11 LED outputs
> > > > and hardware reset support.
> > > >=3D20
> > > > Add the compatible string for CAP1114, include its datasheet URL,
> > > > and update the maximum count of LED channels and linux,keycodes entri=
> es.
> > > >=3D20
> > > > Add description for microchip,input-threshold: CAP1114 only provides =
> eight
> > > > threshold entries, which does not match its total channel count.
> > > >=3D20
> > > > Signed-off-by: Jun Yan <jerrysteve1101@gmail.com>
> > > > ---
> > > >  .../bindings/input/microchip,cap11xx.yaml     | 21 +++++++++++++++++=
> --
> > > >  1 file changed, 19 insertions(+), 2 deletions(-)
> > > >=3D20
> > > > diff --git a/Documentation/devicetree/bindings/input/microchip,cap11x=
> x.ya=3D
> > > ml b/Documentation/devicetree/bindings/input/microchip,cap11xx.yaml
> > > > index e307628350c2..08233386a433 100644
> > > > --- a/Documentation/devicetree/bindings/input/microchip,cap11xx.yaml
> > > > +++ b/Documentation/devicetree/bindings/input/microchip,cap11xx.yaml
> > > > @@ -12,6 +12,7 @@ description: |
> > > > =3D20
> > > >    For more product information please see the links below:
> > > >      CAP1106: https://ww1.microchip.com/downloads/en/DeviceDoc/000016=
> 24B.=3D
> > > pdf
> > > > +    CAP1114: https://ww1.microchip.com/downloads/en/DeviceDoc/000024=
> 44A.=3D
> > > pdf
> > > >      CAP1126: https://ww1.microchip.com/downloads/en/DeviceDoc/000016=
> 23B.=3D
> > > pdf
> > > >      CAP1188: https://ww1.microchip.com/downloads/en/DeviceDoc/000016=
> 20C.=3D
> > > pdf
> > > >      CAP1203: https://ww1.microchip.com/downloads/en/DeviceDoc/000015=
> 72B.=3D
> > > pdf
> > > > @@ -26,6 +27,7 @@ properties:
> > > >    compatible:
> > > >      enum:
> > > >        - microchip,cap1106
> > > > +      - microchip,cap1114
> > > >        - microchip,cap1126
> > > >        - microchip,cap1188
> > > >        - microchip,cap1203
> > > > @@ -62,7 +64,7 @@ properties:
> > > > =3D20
> > > >    linux,keycodes:
> > > >      minItems: 3
> > > > -    maxItems: 8
> > > > +    maxItems: 14
> > > >      description: |
> > > >        Specifies an array of numeric keycode values to
> > > >        be used for the channels. If this property is
> > > > @@ -122,6 +124,8 @@ properties:
> > > >        is required for a touch to be registered, making the touch sen=
> sor =3D
> > > less
> > > >        sensitive.
> > > >        The number of entries must correspond to the number of channel=
> s.
> > > > +      CAP1114 is an exception where channels 8~14 reuse the eighth e=
> ntry=3D
> > > 's
> > > > +      threshold, so counts differ.
> > > > =3D20
> > > >    microchip,calib-sensitivity:
> > > >      $ref: /schemas/types.yaml#/definitions/uint32-array
> > > > @@ -149,7 +153,7 @@ patternProperties:
> > > >        reg:
> > > >          description: LED channel number
> > > >          minimum: 0
> > > > -        maximum: 7
> > > > +        maximum: 10
> > > > =3D20
> > > >      required:
> > > >        - reg
> > > > @@ -199,6 +203,19 @@ allOf:
> > > >              reg:
> > > >                maximum: 1
> > > > =3D20
> > > > +  - if:
> > > > +      properties:
> > > > +        compatible:
> > > > +          contains:
> > > > +            enum:
> > > > +              - microchip,cap1188
> > >=20
> > > I don't understand this restriction, shouldn't this be
> > > if: properties: compatible: not: contains: microchip,cap1114
> > > so that the constraints before your change are retained?
> > >=20
> >=20
> > Previously, the LED reg property had a default maximum of 7 for CAP1188.=
> =20
> > With the addition of CAP1114, the default maximum is now 11.=20
> > An if-then constraint is added to limit the LED count for CAP1188.
> 
> Ah, is this because cap1188 is the only existing device in the binding
> that actually has LEDs?

- CAP1126: max 2 LED channels (0-1)
- CAP1188: max 8 LED channels (0-7)
- CAP1106, CAP12xx: no LED support

The LED reg property constraints for CAP1126 were added in Patch 3 [1].

[1] https://lore.kernel.org/linux-input/20260606150458.250606-4-jerrysteve1101@gmail.com/