Re: [PATCH v6 1/7] dt-bindings: mfd: mt6397: Add MT6392 PMIC

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The dt-bindings schema for the MT6392 PMIC omits the 'mediatek,mt6392-regulator' compatible string for the 'regulators' child node. Since the 'regulators' node is unconditionally marked as required in the schema, any complete device tree correctly describing the MT6392 hardware must include it. Omitting the MT6392-specific regulator compatible string from the schema forces DT authors to either write incomplete DTs (which fail validation because the node is required) or use incorrect/generic compatible strings, causing schema validation failures when they attempt to properly describe the hardware with 'mediatek,mt6392-regulator'.
--

commit a20444c8e4c98a81558d6d5c619b650c00235e18
Author: Fabien Parent <parent.f@gmail.com>

dt-bindings: mfd: mt6397: Add MT6392 PMIC

Add the initial bindings for the MT6392 PMIC and its RTC device.

> diff --git a/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml b/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml
> index 3cbc0dc12c319..e39e81aa99249 100644
> --- a/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml
> +++ b/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml

[ ... ]

> @@ -72,6 +76,10 @@ properties:
>                - mediatek,mt6331-rtc
>                - mediatek,mt6358-rtc
>                - mediatek,mt6397-rtc
> +          - items:
> +              - enum:
> +                  - mediatek,mt6392-rtc
> +              - const: mediatek,mt6323-rtc

[Severity: Medium]
Should the mediatek,mt6392-regulator compatible string be added to the
regulators child node as well?

Since the regulators node is unconditionally marked as required in the schema,
any complete device tree describing the MT6392 hardware must include it.

Does this missing string cause a regression where DT authors are forced to
either write incomplete DTs (which fail validation) or use incorrect compatible
strings?

This causes schema validation failures when authors attempt to properly describe
the hardware with mediatek,mt6392-regulator:

Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml:
  regulators:
    ...
    properties:
      compatible:
        oneOf:
          - enum:
              - mediatek,mt6323-regulator
              - mediatek,mt6328-regulator
              ...

>            - items:
>                - enum:
>                    - mediatek,mt6359-rtc

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260612200717.361018-1-l.scorcia@gmail.com?part=1