Re: [PATCH] Input: synaptics - disable InterTouch on ThinkPad T440p (board id 2722)

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Format specifier type mismatch in `psmouse_info` call.
--

commit 0fa38fb74cf1360727ab0551657ea6c7dcbf7b75
Author: Raphaël Larocque <rlarocque@disroot.org>

Input: synaptics - disable InterTouch on ThinkPad T440p (board id 2722)

This commit disables SMBus InterTouch for the ThinkPad T440p (board id 2722)
by matching its PNP ID and board ID. This ensures the touchpad works via
PS/2 immediately at boot, bypassing a long delay caused by the SMBus
companion device taking time to initialize.

> diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
> --- a/drivers/input/mouse/synaptics.c
> +++ b/drivers/input/mouse/synaptics.c
> @@ -1837,6 +1837,16 @@ static int synaptics_setup_intertouch(struct psmouse *psmouse,
[ ... ]
> +		/* Disable intertouch on known-broken board revisions */
> +		if (psmouse_matches_pnp_id(psmouse,
> +				(const char * const []){"LEN0036", NULL}) &&
> +		    info->board_id == 2722) {
> +			psmouse_info(psmouse,
> +				     "Disabling intertouch for board id %d\n",
> +				     info->board_id);

[Severity: Low]
This isn't a bug, but should the format specifier for info->board_id be %u
instead of %d?

Looking at struct synaptics_device_info, board_id is declared as a u32:

struct synaptics_device_info {
	...
	u32 board_id;		/* Board-ID */
	...
};

While 2722 easily fits in a signed integer, using %u would avoid potential
format string warnings under stricter warning levels.

> +			return -ENXIO;
> +		}
>  	}

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260617025619.41237-1-rlarocque@disroot.org?part=1