[PATCH] HID: nintendo: fix clang build of switch2_probe guard/goto

[Ryan McClelland <rymcclel@gmail.com>]

clang rejects the forward `goto err_close/err_stop` in switch2_probe()
because they jump across the scope of the `guard(mutex)(&ns2->lock)`
cleanup variable ("cannot jump from this goto statement to its label").
All three early error paths run before the lock is acquired, so replace
the gotos with explicit hid_hw_close()/hid_hw_stop() cleanup and drop the
now-unused labels. No functional change; gcc accepted the original.

Signed-off-by: Ryan McClelland <rymcclel@gmail.com>
---

Hi Vicki, I've been testing your Switch 2 series on a local machine here
with JC2, GC, and Pro all over USB and hits this clang build break, Patch below
, feel free to just squash it in.

drivers/hid/hid-nintendo.c:4147:3: error: cannot jump from this goto
statement to its label
drivers/hid/hid-nintendo.c:4153:3: error: cannot jump from this goto
statement to its label

with the explanatory notes pointing at:
 note: jump bypasses initialization of variable with __attribute__((cleanup))
  guard(mutex)(&ns2->lock);


 drivers/hid/hid-nintendo.c | 14 +++++---------
 1 file changed, 5 insertions(+), 9 deletions(-)

diff --git a/drivers/hid/hid-nintendo.c b/drivers/hid/hid-nintendo.c
index 40f57036d810..6a286d49e5bd 100644
--- a/drivers/hid/hid-nintendo.c
+++ b/drivers/hid/hid-nintendo.c
@@ -4144,13 +4144,16 @@ static int switch2_probe(struct hid_device *hdev, const struct hid_device_id *id
 	ret = hid_hw_open(hdev);
 	if (ret) {
 		hid_err(hdev, "hw_open failed %d\n", ret);
-		goto err_stop;
+		hid_hw_stop(hdev);
+		return ret;
 	}
 
 	ns2 = switch2_get_controller(phys);
 	if (IS_ERR(ns2)) {
 		ret = PTR_ERR(ns2);
-		goto err_close;
+		hid_hw_close(hdev);
+		hid_hw_stop(hdev);
+		return ret;
 	}
 
 	guard(mutex)(&ns2->lock);
@@ -4194,13 +4197,6 @@ static int switch2_probe(struct hid_device *hdev, const struct hid_device_id *id
 		return switch2_init_controller(ns2);
 
 	return 0;
-
-err_close:
-	hid_hw_close(hdev);
-err_stop:
-	hid_hw_stop(hdev);
-
-	return ret;
 }
 
 static void switch2_remove(struct hid_device *hdev)
-- 
2.54.0