From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f43.google.com (mail-yx1-f43.google.com [74.125.224.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6AF862C029D for ; Sun, 28 Jun 2026 16:31:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782664265; cv=none; b=HmaNjlwCAd+sKWMNwlUP0oZzcCwLQ4a2xUiUL07jDUn2OwERZfSsYgylOFl/Ef4mFSdsOseyl2ePe74TSU0Bs5J9aU8ludzjYrXUuGpY+OwZBBzKiKbGDj/YQwWi151e9VYgmTMzfJo1FX7/BPAJyxxstKaFkUerrCTQ26jXlU0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782664265; c=relaxed/simple; bh=pwNe+XoOzjXv09t/4Ep12hexyuF5uQcuJZEVEzLOuZo=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=XoGWAguHamwJTcGq/iuGg+nI3tKu1dpbukwVQ7vQTKaxytC6zPx/ocoGgXFIp6vlmPSYMtmb1MAP4oi+pMR295pYJwW6gNTHrdf482FbHVVapy+FbtKaPWTzMKANTxShBLjXMwLga59RjIvSnssdxSfGlA4mxU9o0qsTsg1Xtss= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AMXpZFuk; arc=none smtp.client-ip=74.125.224.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AMXpZFuk" Received: by mail-yx1-f43.google.com with SMTP id 956f58d0204a3-664d22d7337so435617d50.1 for ; Sun, 28 Jun 2026 09:31:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782664263; x=1783269063; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=fuM5aqUk7y4LethrziGqS6AGoxMIRZ2CRfrmTBywl70=; b=AMXpZFukW3S6ATZL5HzARMJJ/inn9nft3qulpQMuQ/RshuaA8HY0m3iRbreQGiIs63 /AXMO+tIrCREAgsFwKUP1lfW0BruEH2WaenUvyQxgWz7XPyPTNh/oxS/VC3okksQ6lfR rNADs1GZzDmOWLAjS+I58goIf2QC8DOKhg6gzVautn7vCYpMEK5R7oMkKWzEumK2csiM kq6rlrYUFrlFoHuEjxupVA3TEZ26jjqpOFvV3SB1MgCa42VNLqQjQzBjpkJ86LXdmM0L 8eKsKItniDwwImgx4JhNt3vbdcIc/4x+gLybwMMwxuEFRTU1f1a65SlrXIQl/QXoGvNt Mqzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782664263; x=1783269063; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=fuM5aqUk7y4LethrziGqS6AGoxMIRZ2CRfrmTBywl70=; b=FmtXmR5n4RCNJ/7en0IbjdQtDiy1NyODQGQvdokO3X5P0XN/GBQdwaVqP28FZNwckd S0Rflfc/ISIsipCSmEY+BqDwclFL82PBB3rhNSkqRGfekIiRfoLY+n4iuTJSQg2z8idB DVc/GRIdSr9T5rdFwHz4mv0sO4JbAKAMDT3hLOuf457P4EcyvltMVZNrEufwWEa+Fbc7 XnVw6qv4KIs0YrphMDYS392wOm/AOlnPcUqsTds7eidwX5CDwgp8Fype93JU90GuGLdO 3NU9woNV0+46DeYrHSRMLhpG/nt6ldQ2EsFVKywkHc+1eb6ynkOEFGrmTkjo7c2zNSGB dn8w== X-Gm-Message-State: AOJu0YxejJuUMk7BG1ok19dMq4yRIO28vELwySaR63niNTZW0ZsQ+l4g b0fNtvFrjv179SPT3BOGZ47IUUh8LeeaL+iPDRewyMtnDRQvsqR2swHJbPsZdtCIN5q0Fw== X-Gm-Gg: AfdE7cn+AiInfVYOWrZBA0XX7aw21z09zJkfU2WFag2sDapc+p/7j4fe8EISjRqRTJV JUs+kN1wn5IGuQAAB1jHtoc1IqMswd2ImV6k+NKs6Rk8cfCGbrpT+mR75xu/xsuvluapkge2k5L JuQHBx/Nkl8lWgP9UDiIh02NsfEHJ4NJ/YFjVNRYmCkZAtZZTUHfJ7eWxI+QBAO46KI/qPP+Rvq //C6tx4GdYQQ6eKOyXkBbN0jpgnYjTEg6raKEn7MTLdPpF4zcDJE9MpyQBYz+XlVi+5NnQdsQQW 9IdiOw1HFJiOe97FtJf6HqQXgY0PbIVh5rXISBz6NlzOflreI/PkpVZsTMIbVCH8BSVRzgJJ9nA DXud9g6JBmW85OPpJVt8Ob5F0JhusGCMCb5G7f5xktfywV4fxefKvK4Kq/Mr0WmkSlK0LgexABI K8Pvk/5B7ewHWqFhO39VfbkWnQV5VhMQd0y+nU X-Received: by 2002:a05:690e:128b:b0:664:c444:39b1 with SMTP id 956f58d0204a3-664c4443d37mr3345018d50.39.1782664263434; Sun, 28 Jun 2026 09:31:03 -0700 (PDT) Received: from Dev-Null-MSI ([2a0d:3344:52ac:a808:98a4:4381:be45:536f]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-664cbe0a2basm1164814d50.7.2026.06.28.09.31.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Jun 2026 09:31:03 -0700 (PDT) From: Yousef Alhouseen To: Jiri Kosina , Benjamin Tissoires Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Yousef Alhouseen Subject: [PATCH] HID: mcp2200: reject short read-all responses Date: Sun, 28 Jun 2026 18:30:35 +0200 Message-ID: <20260628163035.12212-1-alhouseenyousef@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit mcp2200_raw_event() casts every READ_ALL response to the full 16-byte response structure and reads fields through byte 10 without checking the received report size. A malformed USB device can therefore trigger out-of-bounds reads from the input buffer. Complete the pending command with -EMSGSIZE when the response is short. Fixes: 740329d7120f ("HID: mcp2200: added driver for GPIOs of MCP2200") Cc: stable@vger.kernel.org Signed-off-by: Yousef Alhouseen --- drivers/hid/hid-mcp2200.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/hid/hid-mcp2200.c b/drivers/hid/hid-mcp2200.c index dafdd5b4a079..d49f3aa44448 100644 --- a/drivers/hid/hid-mcp2200.c +++ b/drivers/hid/hid-mcp2200.c @@ -302,6 +302,10 @@ static int mcp2200_raw_event(struct hid_device *hdev, struct hid_report *report, switch (data[0]) { case READ_ALL: all_resp = (struct mcp_read_all_resp *) data; + if (size < sizeof(*all_resp)) { + mcp->status = -EMSGSIZE; + break; + } mcp->status = 0; mcp->gpio_inval = all_resp->io_port_val_bmap; mcp->baud_h = all_resp->baud_h; -- 2.54.0