From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0EC4E36EAA7; Mon, 29 Jun 2026 13:25:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782739507; cv=none; b=cg6Y0mV4Zujb+zB6djwAvDmTtyA9roqUqGplY4+f/qnoxSwKUGbBUjVOPXMF5RlzpZy3RT7rT3AEjbbFsfINmGFkI+N1pqdkDafPWrLzqrKK6U+4nRONPhVr85k27ONRkEh22C0qL3HFB7OTh7t0Z7BHW5NrmANnU9G9uVis0MI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782739507; c=relaxed/simple; bh=1hmK4kR6HF7Gta7tXwU42CkYKLd5g0ySBKIpa0699d4=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=aLo7SpJdozBlxbX6WRloA7JT0MEp7fQ1BIT+4QCXWCO+0fJTTOi5uLTVF3XH1TVXz4x8RTZCQegCRGLNuR4TslRX4BZho1a6pUwZmLUSnAuDc5atvFYbjJB9sQhLDoFTea1JLYYGBOCnbumLs+DzbN9LCVEnbDlGnTqTvtgetPo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=aqVlWE1j; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="aqVlWE1j" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A53EB1F000E9; Mon, 29 Jun 2026 13:25:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782739506; bh=sgRsY4zYtIbLv8rc2NSjx7kjzejcvcpW4xrjI6sFxYQ=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=aqVlWE1jmO2Gfb0adrc11FvVfgpThXO75fChvAIafjVEl5O4gqNLxCU5ZfrugpfQW TN+K71uwsmzKOPQB23HjhJYZkS3ftqyLQD2Pg4B9F6qVow5tlE69lDv0TKMGUC+C9i ilRoxjdogoYbHaxrkrXlCMBagbHoiXZPuXLBsR5PtUCApHqVhzjnhpMzyAYap/xbFw Niz+KQibNssVK7KQAZq2n7xDg6QWmXEPYh+D+YlQPCGD5W9p8KgclHxa1mKhYNhmHX A8uNTJsaOrXkLAP8burFvOm5rZ3vo8e7YOBgpc9wOrZMFOzfZ/vd1VZ8E5pWrclBMa kf3AQEVVPSjwQ== From: sashiko-bot@kernel.org Subject: Re: [PATCH 2/6] [v5] x86/olpc: select GPIOLIB_LEGACY Reply-To: sashiko-reviews@lists.linux.dev To: "Arnd Bergmann" Cc: linux-input@vger.kernel.org, lee@kernel.org, dmitry.torokhov@gmail.com, linux-leds@vger.kernel.org In-Reply-To: <20260629130329.1291953-3-arnd@kernel.org> References: <20260629130329.1291953-1-arnd@kernel.org> <20260629130329.1291953-3-arnd@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Mon, 29 Jun 2026 13:25:05 +0000 Message-Id: <20260629132505.A53EB1F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Low] The patch introduces `#include ` but this file= does not exist in the tree, causing a fatal compiler error. -- commit 0da87dc4a65872189dc6e83e56582e1870d842f6 Author: Arnd Bergmann x86/olpc: select GPIOLIB_LEGACY This commit selects CONFIG_GPIOLIB_LEGACY for the OLPC platform to resolve implicit declaration warnings for legacy GPIO functions. It also updates dependencies for the cs5535audio driver to require the legacy GPIO library. [ ... ] > diff --git a/arch/x86/platform/olpc/olpc-xo1-sci.c b/arch/x86/platform/ol= pc/olpc-xo1-sci.c > index 30751b42d54ef..a5b47960ba32e 100644 > --- a/arch/x86/platform/olpc/olpc-xo1-sci.c > +++ b/arch/x86/platform/olpc/olpc-xo1-sci.c > @@ -9,7 +9,7 @@ > =20 > #include > #include > -#include > +#include [Severity: Low] Does this cause a build failure when setup_ec_sci() and other functions in this file are compiled? It appears include/linux/gpio/legacy.h does not exi= st in the tree, and the legacy GPIO APIs might still be declared directly in include/linux/gpio.h. [ ... ] > diff --git a/sound/pci/cs5535audio/cs5535audio_olpc.c b/sound/pci/cs5535a= udio/cs5535audio_olpc.c > index 122170a410d9e..cfdcc5bf4341e 100644 > --- a/sound/pci/cs5535audio/cs5535audio_olpc.c > +++ b/sound/pci/cs5535audio/cs5535audio_olpc.c > @@ -9,7 +9,7 @@ > #include > #include > #include > -#include > +#include [Severity: Low] Could this missing include file similarly break the compilation of olpc_analog_input() in the sound driver? [ ... ] --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260629130329.1291= 953-1-arnd@kernel.org?part=3D2